)]}'
{"nova/tests/unit/virt/xenapi/test_volume_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"517426d07e488330b4aae91e039cec61eaa428d4","unresolved":false,"context_lines":[{"line_number":231,"context_line":""},{"line_number":232,"context_line":"class IntroduceSRTestCase(stubs.XenAPITestBaseNoDB):"},{"line_number":233,"context_line":"    @mock.patch.object(volume_utils, \u0027_create_pbd\u0027)"},{"line_number":234,"context_line":"    def test_bug_1502929(self, create_pbd):"},{"line_number":235,"context_line":"        session \u003d mock.Mock()"},{"line_number":236,"context_line":"        session.product_version \u003d (6, 5, 0)"},{"line_number":237,"context_line":"        session.call_xenapi.return_value \u003d \u0027sr_ref\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_f8b437d2","line":234,"updated":"2015-10-13 16:20:45.000000000","message":"nit: seems like it would be nicer to test \"backend-kind\" rather that the bug number","commit_id":"48654119a4e7fa0e780021e42c48591800477d89"}],"nova/virt/xenapi/volume_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"517426d07e488330b4aae91e039cec61eaa428d4","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    return sr_ref"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _hypervisor_vbd_bug(version):"},{"line_number":141,"context_line":"    # Fix for Bug #1502929"},{"line_number":142,"context_line":"    version_as_string \u003d \u0027.\u0027.join(str(v) for v in version)"},{"line_number":143,"context_line":"    return (versionutils.is_compatible(\u00276.5\u0027, version_as_string))"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_b8f55f84","line":140,"updated":"2015-10-13 16:20:45.000000000","message":"nit: requires_backend_kind seems nicer than encoding the bug.","commit_id":"48654119a4e7fa0e780021e42c48591800477d89"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9c13b8954c9c866b10eff8a470088c3cb03a015b","unresolved":false,"context_lines":[{"line_number":137,"context_line":"    return sr_ref"},{"line_number":138,"context_line":""},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _hypervisor_vbd_bug(version):"},{"line_number":141,"context_line":"    # Fix for Bug #1502929"},{"line_number":142,"context_line":"    version_as_string \u003d \u0027.\u0027.join(str(v) for v in version)"},{"line_number":143,"context_line":"    return (versionutils.is_compatible(\u00276.5\u0027, version_as_string))"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_68809a8b","line":140,"in_reply_to":"5a2ca52d_b8f55f84","updated":"2015-11-12 16:42:29.000000000","message":"Done","commit_id":"48654119a4e7fa0e780021e42c48591800477d89"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"517426d07e488330b4aae91e039cec61eaa428d4","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _hypervisor_vbd_bug(version):"},{"line_number":141,"context_line":"    # Fix for Bug #1502929"},{"line_number":142,"context_line":"    version_as_string \u003d \u0027.\u0027.join(str(v) for v in version)"},{"line_number":143,"context_line":"    return (versionutils.is_compatible(\u00276.5\u0027, version_as_string))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_f8867712","line":142,"updated":"2015-10-13 16:20:45.000000000","message":"nit: I think we need to use six to do that kind of conversion, really.","commit_id":"48654119a4e7fa0e780021e42c48591800477d89"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"9c13b8954c9c866b10eff8a470088c3cb03a015b","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":"def _hypervisor_vbd_bug(version):"},{"line_number":141,"context_line":"    # Fix for Bug #1502929"},{"line_number":142,"context_line":"    version_as_string \u003d \u0027.\u0027.join(str(v) for v in version)"},{"line_number":143,"context_line":"    return (versionutils.is_compatible(\u00276.5\u0027, version_as_string))"},{"line_number":144,"context_line":""},{"line_number":145,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_b8100b5a","line":142,"in_reply_to":"5a2ca52d_f8867712","updated":"2015-11-12 16:42:29.000000000","message":"This code is exercised in the py34 unit tests so is py3 safe.","commit_id":"48654119a4e7fa0e780021e42c48591800477d89"}]}