)]}'
{"nova/conductor/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"8a2efb9f1839f01f0fbf075ab879549bef935518","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                                           values)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def instance_type_get(self, context, instance_type_id, read_deleted\u003dFalse):"},{"line_number":291,"context_line":"        result \u003d self.db.instance_type_get(context, instance_type_id,"},{"line_number":292,"context_line":"                                           read_deleted\u003dread_deleted)"},{"line_number":293,"context_line":"        return jsonutils.to_primitive(result)"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2B44%3D","line":291,"updated":"2013-02-28 17:33:44.000000000","message":"I think you could use:\n\nwith utils.temporary_mutation(context,read_deleted\u003dread_deleted): self.db.instance_type_get(context, instance_type_id)\n\nSee other comment in sqlalchemy/api.  Also read_deleted is \u0027yes\u0027, \u0027no\u0027, or \u0027only\u0027.","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6274f4e8639418ae6a11bb0b953ffc388f9b5b02","unresolved":false,"context_lines":[{"line_number":288,"context_line":"                                           values)"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    def instance_type_get(self, context, instance_type_id, read_deleted\u003dFalse):"},{"line_number":291,"context_line":"        result \u003d self.db.instance_type_get(context, instance_type_id,"},{"line_number":292,"context_line":"                                           read_deleted\u003dread_deleted)"},{"line_number":293,"context_line":"        return jsonutils.to_primitive(result)"},{"line_number":294,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2Br8%3D","line":291,"in_reply_to":"AAAANH%2F%2F%2B44%3D","updated":"2013-02-28 19:12:03.000000000","message":"Nifty!","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"}],"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"8a2efb9f1839f01f0fbf075ab879549bef935518","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"def instance_type_get(context, id, session\u003dNone, read_deleted\u003dFalse):"},{"line_number":3600,"context_line":"    \"\"\"Returns a dict describing specific instance_type.\"\"\""},{"line_number":3601,"context_line":"    result \u003d _instance_type_get_query(context, session\u003dsession,"},{"line_number":3602,"context_line":"                                      read_deleted\u003dread_deleted).\\"},{"line_number":3603,"context_line":"                    filter_by(id\u003did).\\"},{"line_number":3604,"context_line":"                    first()"},{"line_number":3605,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2B4o%3D","line":3602,"updated":"2013-02-28 17:33:44.000000000","message":"This ends up overriding what context.read_deleted() is set to, right?  If there\u0027s areas of the code that have a context.read_deleted of \u0027yes\u0027 before calling this, then this will override that now.","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6274f4e8639418ae6a11bb0b953ffc388f9b5b02","unresolved":false,"context_lines":[{"line_number":3599,"context_line":"def instance_type_get(context, id, session\u003dNone, read_deleted\u003dFalse):"},{"line_number":3600,"context_line":"    \"\"\"Returns a dict describing specific instance_type.\"\"\""},{"line_number":3601,"context_line":"    result \u003d _instance_type_get_query(context, session\u003dsession,"},{"line_number":3602,"context_line":"                                      read_deleted\u003dread_deleted).\\"},{"line_number":3603,"context_line":"                    filter_by(id\u003did).\\"},{"line_number":3604,"context_line":"                    first()"},{"line_number":3605,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2BsA%3D","line":3602,"in_reply_to":"AAAANH%2F%2F%2B4o%3D","updated":"2013-02-28 19:12:03.000000000","message":"Right, I always forget that read_deleted is a property of context. Probably because it seems out of place to me there.","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"}],"nova/virt/baremetal/pxe.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"917bfd56464978db3a15af4b0acb1da274246334","unresolved":false,"context_lines":[{"line_number":420,"context_line":"        except exception.NodeNotFound:"},{"line_number":421,"context_line":"            pass"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"        instance_type \u003d self.virtapi.instance_type_get("},{"line_number":424,"context_line":"            context, instance[\u0027instance_type_id\u0027])"},{"line_number":425,"context_line":"        try:"},{"line_number":426,"context_line":"            image_info \u003d get_tftp_image_info(instance, instance_type)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Bi8E%3D","line":423,"updated":"2013-02-27 21:21:19.000000000","message":"We dont really need the image UUIDs to clean up the image files from disk here, so we can just pass a fake instance_type[\u0027extra_specs\u0027] to get_tftp_image_info here and avoid the issue.","commit_id":"97ba3abb1b4f544daf5c51d4ecca1934ae542025"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"8a2efb9f1839f01f0fbf075ab879549bef935518","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                                              deploy_kernel_id\u003d\u0027ignore\u0027))"},{"line_number":428,"context_line":"        try:"},{"line_number":429,"context_line":"            image_info \u003d get_tftp_image_info(instance, instance_type)"},{"line_number":430,"context_line":"        except exception.NovaException, e:"},{"line_number":431,"context_line":"            pass"},{"line_number":432,"context_line":"        else:"},{"line_number":433,"context_line":"            for label in image_info.keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2B4Y%3D","line":430,"updated":"2013-02-28 17:33:44.000000000","message":"No need for the \u0027e\u0027 here.","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6274f4e8639418ae6a11bb0b953ffc388f9b5b02","unresolved":false,"context_lines":[{"line_number":427,"context_line":"                                              deploy_kernel_id\u003d\u0027ignore\u0027))"},{"line_number":428,"context_line":"        try:"},{"line_number":429,"context_line":"            image_info \u003d get_tftp_image_info(instance, instance_type)"},{"line_number":430,"context_line":"        except exception.NovaException, e:"},{"line_number":431,"context_line":"            pass"},{"line_number":432,"context_line":"        else:"},{"line_number":433,"context_line":"            for label in image_info.keys():"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2Brw%3D","line":430,"in_reply_to":"AAAANH%2F%2F%2B4Y%3D","updated":"2013-02-28 19:12:03.000000000","message":"Leftover from debugging... It\u0027s really hard to debug tests that fail because of things inside an \"except Exception\" .. :(","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0aa31591c8a46950ad051caf5efe6c1df900a4cf","unresolved":false,"context_lines":[{"line_number":1993,"context_line":"                                         image_type)"},{"line_number":1994,"context_line":"        disk_info \u003d disk_mapping[name]"},{"line_number":1995,"context_line":"        instance_type_extra_specs \u003d self.virtapi.instance_type_get("},{"line_number":1996,"context_line":"            nova_context.get_admin_context(), instance[\u0027instance_type_id\u0027])"},{"line_number":1997,"context_line":"        return image.libvirt_info(disk_info[\u0027bus\u0027],"},{"line_number":1998,"context_line":"                                  disk_info[\u0027dev\u0027],"},{"line_number":1999,"context_line":"                                  disk_info[\u0027type\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2Biwo%3D","line":1996,"updated":"2013-02-27 22:29:19.000000000","message":"This variable would be more appropriately named as just \u0027instance_type\u0027, yes?","commit_id":"97ba3abb1b4f544daf5c51d4ecca1934ae542025"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0aa31591c8a46950ad051caf5efe6c1df900a4cf","unresolved":false,"context_lines":[{"line_number":1998,"context_line":"                                  disk_info[\u0027dev\u0027],"},{"line_number":1999,"context_line":"                                  disk_info[\u0027type\u0027],"},{"line_number":2000,"context_line":"                                  self.disk_cachemode,"},{"line_number":2001,"context_line":"                                  instance_type_extra_specs)"},{"line_number":2002,"context_line":""},{"line_number":2003,"context_line":"    def get_guest_storage_config(self, instance, image_meta,"},{"line_number":2004,"context_line":"                                 disk_info,"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BiwQ%3D","line":2001,"updated":"2013-02-27 22:29:19.000000000","message":"Then this would be instance_type[\u0027extra_specs\u0027] ?","commit_id":"97ba3abb1b4f544daf5c51d4ecca1934ae542025"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"0aa31591c8a46950ad051caf5efe6c1df900a4cf","unresolved":false,"context_lines":[{"line_number":2116,"context_line":"        quota_items \u003d [\u0027cpu_shares\u0027, \u0027cpu_period\u0027, \u0027cpu_quota\u0027]"},{"line_number":2117,"context_line":"        instance_type_extra_specs \u003d self.virtapi.instance_type_get("},{"line_number":2118,"context_line":"            nova_context.get_admin_context(), instance[\u0027instance_type_id\u0027])"},{"line_number":2119,"context_line":"        for key, value in instance_type_extra_specs.iteritems():"},{"line_number":2120,"context_line":"            if key in quota_items:"},{"line_number":2121,"context_line":"                setattr(guest, key, value)"},{"line_number":2122,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAM3%2F%2BiwY%3D","line":2119,"updated":"2013-02-27 22:29:19.000000000","message":"Ditto.  And shouldn\u0027t this then be instance_type[\u0027extra_specs\u0027].iteritems() ?","commit_id":"97ba3abb1b4f544daf5c51d4ecca1934ae542025"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"8a2efb9f1839f01f0fbf075ab879549bef935518","unresolved":false,"context_lines":[{"line_number":2109,"context_line":""},{"line_number":2110,"context_line":"        inst_type \u003d self.virtapi.instance_type_get("},{"line_number":2111,"context_line":"            nova_context.get_admin_context(), instance[\u0027instance_type_id\u0027],"},{"line_number":2112,"context_line":"            read_deleted\u003dTrue)"},{"line_number":2113,"context_line":"        inst_path \u003d libvirt_utils.get_instance_path(instance)"},{"line_number":2114,"context_line":"        disk_mapping \u003d disk_info[\u0027mapping\u0027]"},{"line_number":2115,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F%2B4A%3D","line":2112,"updated":"2013-02-28 17:33:44.000000000","message":"read_deleted is supposed to be \u0027yes\u0027, \u0027no\u0027, or \u0027only\u0027.  Also, I think this should be set in context.read_deleted().  See other comments.","commit_id":"28225de3da64099a17bd10b592fd3494b2650af7"}]}