)]}'
{"id":"openstack%2Fnova~23137","triplet_id":"openstack%2Fnova~master~I781fa4796908bea684d4499fa9ff5e4d7a18fbd4","project":"openstack/nova","branch":"master","topic":"fix_migration_walk","hashtags":[],"change_id":"I781fa4796908bea684d4499fa9ff5e4d7a18fbd4","subject":"Fix `with_data` handling in test-migrations.","status":"MERGED","created":"2013-02-27 23:36:59.000000000","updated":"2013-02-28 16:58:17.000000000","submitted":"2013-02-28 16:58:15.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"3a0a091d924e575474bb581e7507f93f271baea3","_number":23137,"virtual_id_number":23137,"owner":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":2,"date":"2013-02-28 16:58:15.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"all":[{"value":2,"date":"2013-02-28 16:12:38.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":1,"date":"2013-02-28 16:58:13.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":2,"date":"2013-02-28 16:16:13.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"all":[{"value":0,"date":"2013-02-28 16:12:38.000000000","_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":1,"date":"2013-02-28 16:16:13.000000000","_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},{"value":0,"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-28 16:12:38.000000000","updated_by":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"reviewer":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"state":"REVIEWER"},{"updated":"2013-02-28 16:16:13.000000000","updated_by":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"reviewer":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"state":"REVIEWER"},{"updated":"2013-02-28 16:58:13.000000000","updated_by":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"reviewer":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"state":"REVIEWER"},{"updated":"2013-02-28 16:58:15.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"28e1edde16f8ec5ac5804c4cc2df2be0d5ac6276","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 00:24:21.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23137/1/check/gate-nova-pep8/21761 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-nova-docs/16256 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-nova-python26/17687 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-nova-python27/17754 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-tempest-devstack-vm-full/5983 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-tempest-devstack-vm-postgres-full/5702 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-tempest-devstack-vm-quantum/10750 : SUCCESS\n- http://logs.openstack.org/23137/1/check/gate-nova-pylint/8932 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"e6aeabddd41fc7538ad942fddab685293cf93b36","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 16:12:38.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":1},{"id":"bab4cfafc93e8c879ea638204b69cf7d006456f5","author":{"_account_id":642,"name":"Matt Dietz","email":"matthew.dietz@gmail.com","username":"cerberus"},"date":"2013-02-28 16:16:13.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"030362c03d9a3c3bbe1cf15f748c039bebf88367","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 16:16:17.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"90d34156ad8e6906f9d455d05cc0198e7a3527fd","author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"date":"2013-02-28 16:58:13.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":1},{"id":"152f9f3ac57de807df97fe6bcb7212304ed77c54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 16:58:15.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23137/1/gate/gate-nova-docs/16285 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-nova-pep8/21794 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-nova-python26/17716 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-nova-python27/17783 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-tempest-devstack-vm-full/6078 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-tempest-devstack-vm-postgres-full/5797 : SUCCESS\n- http://logs.openstack.org/23137/1/gate/gate-tempest-devstack-vm-quantum/10868 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"c4994f39cae5ea688e94683e4ebc196b5b9b7f0c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 16:58:17.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"547a9d795e30fb8ef94d071f02780f3f360c3c17","revisions":{"547a9d795e30fb8ef94d071f02780f3f360c3c17":{"kind":"REWORK","_number":1,"created":"2013-02-27 23:36:59.000000000","uploader":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"ref":"refs/changes/37/23137/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/37/23137/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/23137/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/23137/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/37/23137/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/37/23137/1"}}},"commit":{"parents":[{"commit":"09a3566a46bf2d19bc30065f31a2cc3ad15a33b1","subject":"BM Migration 004: Actually drop column","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/09a3566a46bf2d19bc30065f31a2cc3ad15a33b1"}]}],"author":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2013-02-27 23:32:40.000000000","tz":0},"committer":{"name":"Rick Harris","email":"rconradharris@gmail.com","date":"2013-02-27 23:32:40.000000000","tz":0},"subject":"Fix `with_data` handling in test-migrations.","message":"Fix `with_data` handling in test-migrations.\n\nTwo issues with the existing code:\n\n1) migrate-down wasn\u0027t respecting the `with_data` flag\n\n2) migrate-up was not actually migrating unless `with_data` was True.\nThe correct behavior is to always migrate up, but only run checks when\n`with_data` is set.\n\nChange-Id: I781fa4796908bea684d4499fa9ff5e4d7a18fbd4\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/547a9d795e30fb8ef94d071f02780f3f360c3c17"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/547a9d795e30fb8ef94d071f02780f3f360c3c17"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"09a3566a46bf2d19bc30065f31a2cc3ad15a33b1","is_merged_in_target_branch":true,"change_id":"I1bcc28511d652df44f7168fb84c8be7dacd60cfd","change_number":23133,"patch_set_number":1,"change_status":"MERGED"}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}