)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"db7c5247a500d88acd9b3215da37f608dc413464","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Support for new --status parameter to \"nova-manage vm list\" command"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently \"nova-manage vm list\" command is displaying the list of all"},{"line_number":10,"context_line":"vms irrespective of vm_state(active,error..)."},{"line_number":11,"context_line":"As suggested in bug, Added CLI support for new parameter \"status\" to"},{"line_number":12,"context_line":"filter the VMs based on vm_state in db. If status is not provided,"},{"line_number":13,"context_line":"all vms(active,error..) will be displayed."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_00937c50","line":10,"updated":"2015-10-07 06:42:14.000000000","message":"VMs; vm_state (active, error, etc.).","commit_id":"228538e11293f2c50f9217189baef4c079d17f61"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"db7c5247a500d88acd9b3215da37f608dc413464","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently \"nova-manage vm list\" command is displaying the list of all"},{"line_number":10,"context_line":"vms irrespective of vm_state(active,error..)."},{"line_number":11,"context_line":"As suggested in bug, Added CLI support for new parameter \"status\" to"},{"line_number":12,"context_line":"filter the VMs based on vm_state in db. If status is not provided,"},{"line_number":13,"context_line":"all vms(active,error..) will be displayed."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7a2fa921_809f8c4f","line":11,"updated":"2015-10-07 06:42:14.000000000","message":"Adds CLI support for ...","commit_id":"228538e11293f2c50f9217189baef4c079d17f61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"fa171da313631eb0b52e6853e2910c75a5867c16","unresolved":false,"context_lines":[{"line_number":13,"context_line":"all vms(active,error..) will be displayed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ebc3ddd4d8c5506684122bcbc12bec551a9cb83"},{"line_number":16,"context_line":"Closes-Bug: #1494841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_a4be3cd2","line":16,"updated":"2015-10-07 17:36:04.000000000","message":"This is not really a bug, it\u0027s really a feature add to add a new option to the CLI, see:\n\nhttps://blueprints.launchpad.net/nova/+spec/print-table-archived-rows\n\nPlease open a simple blueprint for this and ping me and I\u0027ll get it approved.  This doesn\u0027t require a spec IMO.","commit_id":"cf360aa9d450a117b485f1352e183cfd9c213a6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"680887fd790907997fadc76b6d59ab2254de42b6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"all vms(active,error..) will be displayed."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Change-Id: I6ebc3ddd4d8c5506684122bcbc12bec551a9cb83"},{"line_number":16,"context_line":"Closes-Bug: #1494841"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"7a2fa921_d6570e56","line":16,"in_reply_to":"7a2fa921_a4be3cd2","updated":"2015-10-09 13:40:19.000000000","message":"Change closes-bug to:\n\nImplements blueprint filter-nova-manage-vm-list","commit_id":"cf360aa9d450a117b485f1352e183cfd9c213a6c"}],"nova/cmd/manage.py":[{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"db7c5247a500d88acd9b3215da37f608dc413464","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    \"\"\"Class for managing VM instances.\"\"\""},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    @args(\u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, help\u003d\u0027Host\u0027)"},{"line_number":660,"context_line":"    @args(\u0027--status\u0027, metavar\u003d\u0027\u003cstatus\u003e\u0027, help\u003d\u0027Vm state\u0027)"},{"line_number":661,"context_line":"    def list(self, host\u003dNone, status\u003dNone):"},{"line_number":662,"context_line":"        \"\"\"Show a list of all instances.\"\"\""},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_8091cc54","line":660,"updated":"2015-10-07 06:42:14.000000000","message":"s/Vm/VM\n\nAre we sure we want to call this status?  I know the nova-list command uses --status but it seems like it makes more sense to just use state?  Just posing the question - not a big deal.","commit_id":"228538e11293f2c50f9217189baef4c079d17f61"},{"author":{"_account_id":13289,"name":"Taylor Peoples","email":"tpeoples@us.ibm.com","username":"tpeoples"},"change_message_id":"db7c5247a500d88acd9b3215da37f608dc413464","unresolved":false,"context_lines":[{"line_number":674,"context_line":"                                             _(\u0027user\u0027),"},{"line_number":675,"context_line":"                                             _(\u0027zone\u0027),"},{"line_number":676,"context_line":"                                             _(\u0027index\u0027))))"},{"line_number":677,"context_line":"        if status is not None:"},{"line_number":678,"context_line":"            filters \u003d {\u0027vm_state\u0027: status}"},{"line_number":679,"context_line":"        else:"},{"line_number":680,"context_line":"            filters \u003d {}"}],"source_content_type":"text/x-python","patch_set":2,"id":"7a2fa921_c0aee497","line":677,"updated":"2015-10-07 06:42:14.000000000","message":"Nit: in the future someone might want to add something else to the filters.  This might be more conducive to that in the future:\n\nfilters \u003d {}\nif status is not None:\n    filters[\u0027vm_state\u0027] \u003d status","commit_id":"228538e11293f2c50f9217189baef4c079d17f61"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"680887fd790907997fadc76b6d59ab2254de42b6","unresolved":false,"context_lines":[{"line_number":657,"context_line":"    \"\"\"Class for managing VM instances.\"\"\""},{"line_number":658,"context_line":""},{"line_number":659,"context_line":"    @args(\u0027--host\u0027, metavar\u003d\u0027\u003chost\u003e\u0027, help\u003d\u0027Host\u0027)"},{"line_number":660,"context_line":"    @args(\u0027--status\u0027, metavar\u003d\u0027\u003cstatus\u003e\u0027, help\u003d\u0027VM state\u0027)"},{"line_number":661,"context_line":"    def list(self, host\u003dNone, status\u003dNone):"},{"line_number":662,"context_line":"        \"\"\"Show a list of all instances.\"\"\""},{"line_number":663,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_117b507c","line":660,"updated":"2015-10-09 13:40:19.000000000","message":"I\u0027d change the help to say \"Filter results by VM state\".","commit_id":"cf360aa9d450a117b485f1352e183cfd9c213a6c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"680887fd790907997fadc76b6d59ab2254de42b6","unresolved":false,"context_lines":[{"line_number":676,"context_line":"                                             _(\u0027index\u0027))))"},{"line_number":677,"context_line":"        filters \u003d {}"},{"line_number":678,"context_line":"        if status is not None:"},{"line_number":679,"context_line":"            filters \u003d {\u0027vm_state\u0027: status}"},{"line_number":680,"context_line":""},{"line_number":681,"context_line":"        if host is None:"},{"line_number":682,"context_line":"            instances \u003d objects.InstanceList.get_by_filters("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a2fa921_519ea8b9","line":679,"updated":"2015-10-09 13:40:19.000000000","message":"The status value should be validated, otherwise I could send --status foo and it wouldn\u0027t fail but I wouldn\u0027t get anything back either.\n\nThe API side filters those out here:\n\nhttps://github.com/openstack/nova/blob/master/nova/api/openstack/compute/servers.py#L300\n\nI\u0027d think you\u0027d want something similar here and if it\u0027s an invalid status print an error and return 1 so it\u0027s a failure.","commit_id":"cf360aa9d450a117b485f1352e183cfd9c213a6c"}]}