)]}'
{"nova/virt/xenapi/vm_utils.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"cdf23c26799c6278723ce3292c909d029fe2ff7c","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        rec[\u0027HVM_boot_policy\u0027] \u003d \u0027BIOS order\u0027"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if device_id:"},{"line_number":309,"context_line":"        rec[\u0027platform\u0027][\u0027device_id\u0027] \u003d str(device_id).zfill(4)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    vm_ref \u003d session.VM.create(rec)"},{"line_number":312,"context_line":"    LOG.debug(\u0027Created VM\u0027, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_c2081394","line":309,"updated":"2015-10-07 15:10:00.000000000","message":"is the zfill actually required here?","commit_id":"b03ab6c2981aa0e8d71ae5b1374a44e64e8bbbf7"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"50d76ff23c0863e3143d3c2e634ef151540016b1","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        rec[\u0027HVM_boot_policy\u0027] \u003d \u0027BIOS order\u0027"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if device_id:"},{"line_number":309,"context_line":"        rec[\u0027platform\u0027][\u0027device_id\u0027] \u003d str(device_id).zfill(4)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    vm_ref \u003d session.VM.create(rec)"},{"line_number":312,"context_line":"    LOG.debug(\u0027Created VM\u0027, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_d4a437a7","line":309,"in_reply_to":"7a2fa921_78ac52a0","updated":"2015-11-05 19:57:12.000000000","message":"The toolstack always uses 0001 and 0002 but in theory qemu shouldn\u0027t mind whether it\u0027s zfilled.\n\nHowever, I would much prefer to keep things as with the toolstack - i.e. zfill is the safe thing to do here, so there\u0027s no point risking doing something potentially less safe.","commit_id":"b03ab6c2981aa0e8d71ae5b1374a44e64e8bbbf7"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"a06f8537f115a642bb8d25c88b0d19eaabdd9a5e","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        rec[\u0027HVM_boot_policy\u0027] \u003d \u0027BIOS order\u0027"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if device_id:"},{"line_number":309,"context_line":"        rec[\u0027platform\u0027][\u0027device_id\u0027] \u003d str(device_id).zfill(4)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    vm_ref \u003d session.VM.create(rec)"},{"line_number":312,"context_line":"    LOG.debug(\u0027Created VM\u0027, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7a2fa921_78ac52a0","line":309,"in_reply_to":"7a2fa921_c2081394","updated":"2015-10-07 15:41:01.000000000","message":"I do not know. I defer to someone who knows this code and xapi well. Not sure how xapi treats \u00270002\u0027 vs \u00272\u0027.","commit_id":"b03ab6c2981aa0e8d71ae5b1374a44e64e8bbbf7"},{"author":{"_account_id":11642,"name":"Jesse J. Cook","email":"jesse.cook@rackspace.com","username":"crashenx"},"change_message_id":"d2b4ed6ce79ce490f289b4f0b1e8f6af1a83532b","unresolved":false,"context_lines":[{"line_number":306,"context_line":"        rec[\u0027HVM_boot_policy\u0027] \u003d \u0027BIOS order\u0027"},{"line_number":307,"context_line":""},{"line_number":308,"context_line":"    if device_id:"},{"line_number":309,"context_line":"        rec[\u0027platform\u0027][\u0027device_id\u0027] \u003d str(device_id).zfill(4)"},{"line_number":310,"context_line":""},{"line_number":311,"context_line":"    vm_ref \u003d session.VM.create(rec)"},{"line_number":312,"context_line":"    LOG.debug(\u0027Created VM\u0027, instance\u003dinstance)"}],"source_content_type":"text/x-python","patch_set":3,"id":"fa80f949_820c2aee","line":309,"in_reply_to":"fa80f949_d4a437a7","updated":"2015-11-05 22:29:44.000000000","message":"Thanks for the clarity!","commit_id":"b03ab6c2981aa0e8d71ae5b1374a44e64e8bbbf7"}]}