)]}'
{"nova/virt/baremetal/virtual_power_driver.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"955325ba10e555be8bbd8332386d57688d43ebce","unresolved":false,"context_lines":[{"line_number":108,"context_line":"                _(\u0027virtual_power_host_user not defined. Can not Start\u0027))"},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"        if not CONF.baremetal.virtual_power_host_pass:"},{"line_number":111,"context_line":"            # it is ok to not have a password if you have a keyfile"},{"line_number":112,"context_line":"            if CONF.baremetal.virtual_power_host_key is None:"},{"line_number":113,"context_line":"                raise exception.NovaException("},{"line_number":114,"context_line":"                    _(\u0027virtual_power_host_pass/key not set. Can not Start\u0027))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAANH%2F%2F%2FAw%3D","line":111,"updated":"2013-02-28 16:29:59.000000000","message":"Just for readability, I would condense this to a single if statement.","commit_id":"88a8caab6c921f03bfacd8a04d60d9cd30796eb8"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"69cf2bd3d6e0dcd4d71dccbd483337653ce2da71","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               default\u003d\u002722\u0027,"},{"line_number":36,"context_line":"               help\u003d\u0027Port to use for ssh to virtual power host\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027virtual_power_type\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027virsh\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027base command to use for virtual power(vbox,virsh)\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027virtual_power_host_user\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F8AI%3D","line":38,"updated":"2013-03-02 19:46:09.000000000","message":"Was this change intended?  I don\u0027t see anything in the commit message about it.. nor does it seem to apply to the bug.","commit_id":"0898705257ecd9b7d84c88d5ba9e27800d6f61e3"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"6b46d5df594d2ae9ad0a00ef0f1176a8ca65d395","unresolved":false,"context_lines":[{"line_number":35,"context_line":"               default\u003d\u002722\u0027,"},{"line_number":36,"context_line":"               help\u003d\u0027Port to use for ssh to virtual power host\u0027),"},{"line_number":37,"context_line":"    cfg.StrOpt(\u0027virtual_power_type\u0027,"},{"line_number":38,"context_line":"               default\u003d\u0027virsh\u0027,"},{"line_number":39,"context_line":"               help\u003d\u0027base command to use for virtual power(vbox,virsh)\u0027),"},{"line_number":40,"context_line":"    cfg.StrOpt(\u0027virtual_power_host_user\u0027,"},{"line_number":41,"context_line":"               default\u003d\u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAANH%2F%2F76c%3D","line":38,"in_reply_to":"AAAANH%2F%2F8AI%3D","updated":"2013-03-03 03:11:45.000000000","message":"Not directly related. The CI framework we\u0027re starting to work on -- and i suspect most folks who Dev/test this -- will use virsh, since it seems to be the standard on Ubuntu. It\u0027s a simple enough option to change during testing, but I would like to align the default with what appears to be the common environment. This could be done as a separate one line patch, if that\u0027s better.","commit_id":"0898705257ecd9b7d84c88d5ba9e27800d6f61e3"}]}