)]}'
{"id":"openstack%2Fnova~23199","triplet_id":"openstack%2Fnova~master~I6130863a95567eabd3ae05a09e4a9f26bb5f5098","project":"openstack/nova","branch":"master","topic":"bug/1046870","hashtags":[],"change_id":"I6130863a95567eabd3ae05a09e4a9f26bb5f5098","subject":"don\u0027t stack trace if long ints are passed to db","status":"MERGED","created":"2013-02-28 20:04:32.000000000","updated":"2013-03-01 22:14:39.000000000","submitted":"2013-03-01 22:14:37.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":1,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"432f54c08cde48efe17b447f14054b541deb70b6","_number":23199,"virtual_id_number":23199,"owner":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"recommended":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":1,"date":"2013-03-01 02:48:21.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":2,"date":"2013-03-01 22:14:37.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":2,"date":"2013-03-01 15:05:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":2,"date":"2013-03-01 14:27:45.000000000","permitted_voting_range":{"min":2,"max":2},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":2,"date":"2013-03-01 15:18:15.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":1,"date":"2013-03-01 14:32:26.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2013-03-01 15:06:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"date":"2013-03-01 15:05:20.000000000","_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"date":"2013-03-01 14:27:45.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":1,"date":"2013-03-01 15:18:15.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"value":0,"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"value":0,"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"value":0,"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-02-28 22:33:22.000000000","updated_by":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"reviewer":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"state":"REVIEWER"},{"updated":"2013-03-01 02:48:21.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-03-01 14:27:45.000000000","updated_by":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"reviewer":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"state":"REVIEWER"},{"updated":"2013-03-01 14:32:26.000000000","updated_by":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"reviewer":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"state":"REVIEWER"},{"updated":"2013-03-01 15:05:20.000000000","updated_by":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"reviewer":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"state":"REVIEWER"},{"updated":"2013-03-01 15:06:59.000000000","updated_by":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"reviewer":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"state":"REVIEWER"},{"updated":"2013-03-01 15:18:15.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-03-01 22:14:37.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"98f1834cdd4733d3192dc0b2160162f47ac691d6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 20:50:23.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23199/1/check/gate-nova-pep8/21824 : SUCCESS\n- http://logs.openstack.org/23199/1/check/gate-nova-docs/16314 : SUCCESS\n- http://logs.openstack.org/23199/1/check/gate-nova-python26/17742 : SUCCESS\n- http://logs.openstack.org/23199/1/check/gate-nova-python27/17812 : SUCCESS\n- http://logs.openstack.org/23199/1/check/gate-tempest-devstack-vm-full/6141 : FAILURE\n- http://logs.openstack.org/23199/1/check/gate-tempest-devstack-vm-postgres-full/5860 : FAILURE\n- http://logs.openstack.org/23199/1/check/gate-tempest-devstack-vm-quantum/10942 : SUCCESS\n- http://logs.openstack.org/23199/1/check/gate-nova-pylint/8964 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"1d80d038a7bf5a058cdedc1cbf13ebc4de9f6047","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-02-28 21:29:40.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nIMHO, this is the wrong place to solve this. I think this should be nova-api-level validation of things like integral ids. Taking a string for something that should be an int and covering it up with a simple \"not found\" is throwing away too much information, I\u0027d say.\n\nThat said, are we actually taking a database ID from the API? If so, I definitely think it should be sanity-checked way (way) above the db layer.","accounts_in_message":[],"_revision_number":1},{"id":"09a7e7a54c2e91a0382bc588b855c4eeeae2b428","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 21:50:43.000000000","message":"Patch Set 1:\n\nwe do already sanity check above the db API, see https://github.com/openstack/nova/blob/master/nova/compute/api.py#L1308\n\nHowever, extremely long int like values can still get through. Given that the details on exactly how long of an int we support isn\u0027t totally clear, it seems ok to handle the edge case here.","accounts_in_message":[],"_revision_number":1},{"id":"e46d3a7bdb179f297fe5f58fab610be5b1ba4261","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 22:14:15.000000000","message":"Uploaded patch set 2.","accounts_in_message":[],"_revision_number":2},{"id":"6a8df5d8540472f810996a8395fc852a0823525c","author":{"_account_id":5494,"name":"Trivial Rebase","email":"trivial-rebase@review.openstack.org","username":"trivial-rebase"},"date":"2013-02-28 22:14:30.000000000","message":"Patch Set 2:\n\nNew patchset patch-id matches previous patchset, but commit message has changed.","accounts_in_message":[],"_revision_number":2},{"id":"4823b31821a694d088e6b6ee9d1631d07be0f543","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-02-28 22:20:16.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nMy complaint stands that we\u0027re raising a NotFound error deep in the database API for something that isn\u0027t a NotFound (confusing the case with the legitimate NotFound condition that function can already raise). IMHO, the interpretation of \"this integer is larger than the databse can handle for this column\" differs at the db/compute layer (where it is a serious error) and the user-facing API layer (where it is a validation question). Raising a NotFound that deep for that odd of a reason just so that it bubbles up to nova-api as the right thing is the Wrong Solution, IMHO.","accounts_in_message":[],"_revision_number":2},{"id":"cb18230de05e4a06220c451dd4ba14f922fcd175","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 22:26:34.000000000","message":"Patch Set 2:\n\nI believe this is an implementation detail below the api. If we implement the API with a different back end the reason why an id is not found is not really interesting, just that it isn\u0027t. Leaking that info up from SQLalchemy layer at all seems like bad form.\n\nThe id returns no valid instance. The reasons why, in this case that it was impossible that it ever could if it was run on pgsql (though it won\u0027t generate the error on mysql), is implementation specific based on the back end, so exposing those implementation details up seems wrong.","accounts_in_message":[],"_revision_number":2},{"id":"4658d0157d3944e0b338a532194f9be1d398c49d","author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"date":"2013-02-28 22:33:22.000000000","message":"Patch Set 2: Looks good to me, but someone else must approve\n\nI think this is fine: logic as follows:\n - if this was a mutating operation, the dataerror would be semantic, it would be saying \u0027we cannot store this\u0027, and the caller needs to know.\n\n - but this is a lookup. *any* mismatch on the lookup is a NotFound, regardless of the reason [ vs e.g. a DB server being inaccessible which would be different ].","accounts_in_message":[],"_revision_number":2},{"id":"f1cf63ec506b0224d750d43f93424df28c04eb32","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-02-28 22:54:15.000000000","message":"Patch Set 2:\n\nI share dansmith\u0027s unease about swallowing the DataError.  But it\u0027s a subtle point and a multi-person IRC discussion didn\u0027t really resolve it, so tie goes to whoever\u0027s writing the code, so I\u0027m +0.","accounts_in_message":[],"_revision_number":2},{"id":"f68454cf99fcdf92b6db5be8c479d6fd7687631f","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 22:57:46.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"59bc678b5db8a138cfb84ef4de81b1990f1b82dd","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-02-28 23:00:10.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"e2b01d29ac0020f0593789d5cbdeb3971c796bb9","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-02-28 23:03:45.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n(1 inline comment)\n\nComments inline, but I\u0027m fine with it as is.","accounts_in_message":[],"_revision_number":3},{"id":"57d5b3610e77f30115ff53ad735359a0a8b66d54","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 23:04:46.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23199/3/check/gate-nova-pep8/21842 : FAILURE\n- gate-nova-docs : SKIPPED\n- gate-nova-python26 : SKIPPED\n- gate-nova-python27 : SKIPPED\n- gate-tempest-devstack-vm-full : SKIPPED\n- gate-tempest-devstack-vm-postgres-full : SKIPPED\n- gate-tempest-devstack-vm-quantum : SKIPPED\n- gate-nova-pylint : SKIPPED (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"90c9bd59084083024b25f264178446f408d09ea8","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-02-28 23:09:52.000000000","message":"Uploaded patch set 4.","accounts_in_message":[],"_revision_number":4},{"id":"f84713c7cdd11c819ceba1c638717bbad67bdd89","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-02-28 23:49:12.000000000","message":"Patch Set 4: Works for me\n\nSmokeStack Results (patch set 4):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/75556\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/75557\n","accounts_in_message":[],"_revision_number":4},{"id":"875e0bbfe70f337b06c0ccd353c32afe4e070b6b","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-02-28 23:55:03.000000000","message":"Patch Set 4: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23199/4/check/gate-nova-pep8/21847 : SUCCESS\n- http://logs.openstack.org/23199/4/check/gate-nova-docs/16329 : SUCCESS\n- http://logs.openstack.org/23199/4/check/gate-nova-python26/17757 : FAILURE\n- http://logs.openstack.org/23199/4/check/gate-nova-python27/17827 : FAILURE\n- http://logs.openstack.org/23199/4/check/gate-tempest-devstack-vm-full/6168 : FAILURE\n- http://logs.openstack.org/23199/4/check/gate-tempest-devstack-vm-postgres-full/5887 : FAILURE\n- http://logs.openstack.org/23199/4/check/gate-tempest-devstack-vm-quantum/10974 : SUCCESS\n- http://logs.openstack.org/23199/4/check/gate-nova-pylint/8976 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":4},{"id":"19f0541dc88ef15003d4999ad634dfc8949b084d","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-03-01 00:55:59.000000000","message":"Uploaded patch set 5.","accounts_in_message":[],"_revision_number":5},{"id":"aa5896b50fef7892d35d88bfc041a66f284573b9","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-01 01:21:01.000000000","message":"Patch Set 5: Works for me\n\nSmokeStack Results (patch set 5):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/75606\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/75607\n","accounts_in_message":[],"_revision_number":5},{"id":"69d6966f13e15cbb22559b2a611918e1d77fac8a","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 01:42:39.000000000","message":"Patch Set 5: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23199/5/check/gate-nova-pep8/21860 : SUCCESS\n- http://logs.openstack.org/23199/5/check/gate-nova-docs/16340 : SUCCESS\n- http://logs.openstack.org/23199/5/check/gate-nova-python26/17768 : SUCCESS\n- http://logs.openstack.org/23199/5/check/gate-nova-python27/17838 : SUCCESS\n- http://logs.openstack.org/23199/5/check/gate-tempest-devstack-vm-full/6190 : FAILURE\n- http://logs.openstack.org/23199/5/check/gate-tempest-devstack-vm-postgres-full/5909 : FAILURE\n- http://logs.openstack.org/23199/5/check/gate-tempest-devstack-vm-quantum/11001 : SUCCESS\n- http://logs.openstack.org/23199/5/check/gate-nova-pylint/8986 : FAILURE (non-voting)\n","accounts_in_message":[],"_revision_number":5},{"id":"cfd0cbc4c04cfabbbe60772395d198c5ab167df2","author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"date":"2013-03-01 02:28:14.000000000","message":"Uploaded patch set 6.","accounts_in_message":[],"_revision_number":6},{"id":"b48b4de676f340c1fd0a77ce55341fec1eb55e15","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-01 02:48:21.000000000","message":"Patch Set 6: Works for me\n\nSmokeStack Results (patch set 6):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/75627\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/75628\n","accounts_in_message":[],"_revision_number":6},{"id":"a342d9709cda73159265f6bdd9f9b8ee266565a5","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 03:12:00.000000000","message":"Patch Set 6: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23199/6/check/gate-nova-pep8/21867 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-nova-docs/16345 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-nova-python26/17773 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-nova-python27/17843 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-tempest-devstack-vm-full/6203 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-tempest-devstack-vm-postgres-full/5922 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-tempest-devstack-vm-quantum/11017 : SUCCESS\n- http://logs.openstack.org/23199/6/check/gate-nova-pylint/8991 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":6},{"id":"1a73c92a0ec13fce7ff3529199a5a0cf50361038","author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"date":"2013-03-01 14:27:45.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"bec98fbc528bd29f858d0c1a4a2b92fb5b48cdc4","author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"date":"2013-03-01 14:32:26.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"e3a2eb92f02647e0d49ce3ac219e5f4808f56c4f","author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"date":"2013-03-01 15:05:20.000000000","message":"Patch Set 6: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":6},{"id":"b3d541612b4fe8e04a20916c9acd82a690513906","author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"date":"2013-03-01 15:06:59.000000000","message":"Patch Set 6: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":6},{"id":"78a3a7d0fcb1c1b2295b0bef849db6b0d80c0ea7","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-01 15:18:15.000000000","message":"Patch Set 6: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":6},{"id":"4c771bd17c5c411c353c44dfdbf9833d55808902","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 15:18:17.000000000","message":"Patch Set 6: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"06f07a043744b0d46bcc3242286b6287c7a59a85","author":{"_account_id":1,"name":"James E. Blair","email":"jim@acmegating.com","username":"corvus"},"date":"2013-03-01 18:55:28.000000000","message":"Patch Set 6:\n\nreverify no bug","accounts_in_message":[],"_revision_number":6},{"id":"7c40ed214dd21f251015f34a54b570814531fd39","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 18:58:38.000000000","message":"Patch Set 6:\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":6},{"id":"966549c5a847381749f0f07541bf0d0a750c9377","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 22:14:37.000000000","message":"Patch Set 6: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23199/6/gate/gate-nova-docs/16473 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-nova-pep8/22000 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-nova-python26/17899 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-nova-python27/17970 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-tempest-devstack-vm-full/6524 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-tempest-devstack-vm-postgres-full/6243 : SUCCESS\n- http://logs.openstack.org/23199/6/gate/gate-tempest-devstack-vm-quantum/11367 : SUCCESS\n","accounts_in_message":[],"_revision_number":6},{"id":"50046dd3f696cd48866176ff41dbf7a63a47fe60","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-01 22:14:39.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":6}],"current_revision_number":6,"current_revision":"d6999fbe8c545292a98c4e3d20f3b80e3e66d901","revisions":{"14185283204105352fa3399840e78251067b7716":{"kind":"REWORK","_number":1,"created":"2013-02-28 20:04:32.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/1"}}},"commit":{"parents":[{"commit":"14df42b15fabc70472bb23264cf73acf4bfbe83d","subject":"Additional tests for safe parsing with minidom","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14df42b15fabc70472bb23264cf73acf4bfbe83d"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 20:04:24.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass something that looks like an int to any of the rest\nAPI calls, but it exceeds the storage size for instance id in the\ndatabase, SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nvalue like 9223372036854775808 for the id.\n\nInstead, catch DataError exception and return the expected not\nfound.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14185283204105352fa3399840e78251067b7716"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14185283204105352fa3399840e78251067b7716"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"14df42b15fabc70472bb23264cf73acf4bfbe83d","is_merged_in_target_branch":true,"change_id":"If50f690e015f2bf837b403edf552e35d7af8c907","change_number":22442,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"f1bcebe14973628485661d86e414a4eebd518fc0":{"kind":"NO_CODE_CHANGE","_number":2,"created":"2013-02-28 22:14:15.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/2"}}},"commit":{"parents":[{"commit":"14df42b15fabc70472bb23264cf73acf4bfbe83d","subject":"Additional tests for safe parsing with minidom","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14df42b15fabc70472bb23264cf73acf4bfbe83d"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 22:12:33.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass a integer, which is longer than the id field in the\ndatabase, but a valid python integer into any of the REST API\ncalls SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nid of 9223372036854775808 (for instance).\n\nInstead, catch the DataError exception and return the expected\nnot found.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f1bcebe14973628485661d86e414a4eebd518fc0"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/f1bcebe14973628485661d86e414a4eebd518fc0"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"14df42b15fabc70472bb23264cf73acf4bfbe83d","is_merged_in_target_branch":true,"change_id":"If50f690e015f2bf837b403edf552e35d7af8c907","change_number":22442,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"6f4c235695396cd45640daffaa23462c48ca1607":{"kind":"REWORK","_number":3,"created":"2013-02-28 22:57:46.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/3"}}},"commit":{"parents":[{"commit":"14df42b15fabc70472bb23264cf73acf4bfbe83d","subject":"Additional tests for safe parsing with minidom","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14df42b15fabc70472bb23264cf73acf4bfbe83d"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 22:55:11.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass a integer, which is longer than the id field in the\ndatabase, but a valid python integer into any of the REST API\ncalls SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nid of 9223372036854775808 (for instance).\n\nThis issue is seen on postgresql, mysql and sqlite don\u0027t hit it.\n\nInstead, catch the DataError exception, and return an InvalidID\nexception. If InvalidID is thrown catch that at the API layer\nand return the expected not found.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6f4c235695396cd45640daffaa23462c48ca1607"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/6f4c235695396cd45640daffaa23462c48ca1607"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"14df42b15fabc70472bb23264cf73acf4bfbe83d","is_merged_in_target_branch":true,"change_id":"If50f690e015f2bf837b403edf552e35d7af8c907","change_number":22442,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"80ae4bd50b647c16482fed51a8d5e7ca4f522d4e":{"kind":"REWORK","_number":4,"created":"2013-02-28 23:09:52.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/4","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/4","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/4 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/4 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/4 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/4"}}},"commit":{"parents":[{"commit":"14df42b15fabc70472bb23264cf73acf4bfbe83d","subject":"Additional tests for safe parsing with minidom","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/14df42b15fabc70472bb23264cf73acf4bfbe83d"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 23:07:41.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass a integer, which is longer than the id field in the\ndatabase, but a valid python integer into any of the REST API\ncalls SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nid of 9223372036854775808 (for instance).\n\nThis issue is seen on postgresql, mysql and sqlite don\u0027t hit it.\n\nInstead, catch the DataError exception, and return an InvalidID\nexception. If InvalidID is thrown catch that at the API layer\nand return the expected not found.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80ae4bd50b647c16482fed51a8d5e7ca4f522d4e"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/80ae4bd50b647c16482fed51a8d5e7ca4f522d4e"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"14df42b15fabc70472bb23264cf73acf4bfbe83d","is_merged_in_target_branch":true,"change_id":"If50f690e015f2bf837b403edf552e35d7af8c907","change_number":22442,"patch_set_number":5,"change_status":"MERGED"}],"branch":"refs/heads/master"},"45136c3253a0e7a30763b1edbe47c63ae26ff20b":{"kind":"REWORK","_number":5,"created":"2013-03-01 00:55:59.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/5","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/5","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/5 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/5 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/5 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/5"}}},"commit":{"parents":[{"commit":"b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05","subject":"Merge \"Fix crash in quantumapi if no network or port id is specified\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-03-01 00:18:03.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass a integer, which is longer than the id field in the\ndatabase, but a valid python integer into any of the REST API\ncalls SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nid of 9223372036854775808 (for instance).\n\nThis issue is seen on postgresql, mysql and sqlite don\u0027t hit it.\n\nInstead, catch the DataError exception, and return an InvalidID\nexception. If InvalidID is thrown catch that at the API layer\nand return the expected not found.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/45136c3253a0e7a30763b1edbe47c63ae26ff20b"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/45136c3253a0e7a30763b1edbe47c63ae26ff20b"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"d6999fbe8c545292a98c4e3d20f3b80e3e66d901":{"kind":"REWORK","_number":6,"created":"2013-03-01 02:28:14.000000000","uploader":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"ref":"refs/changes/99/23199/6","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/99/23199/6","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/6 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/6 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/99/23199/6 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/99/23199/6"}}},"commit":{"parents":[{"commit":"b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05","subject":"Merge \"Fix crash in quantumapi if no network or port id is specified\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05"}]}],"author":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-02-28 19:58:42.000000000","tz":-300},"committer":{"name":"Sean Dague","email":"sdague@linux.vnet.ibm.com","date":"2013-03-01 02:27:49.000000000","tz":-300},"subject":"don\u0027t stack trace if long ints are passed to db","message":"don\u0027t stack trace if long ints are passed to db\n\nIf we pass a integer, which is longer than the id field in the\ndatabase, but a valid python integer into any of the REST API\ncalls SQLalchemy throws a DataError, and the user sees a 500\ninstead of InstanceNotFound. This can be triggered by using a\nid of 9223372036854775808 (for instance).\n\nThis issue is seen on postgresql, mysql and sqlite don\u0027t hit it.\n\nInstead, catch the DataError exception, and return an InvalidID\nexception. If InvalidID is thrown catch that at the API layer\nand return the expected not found.\n\nThis was caught when reenabling tempest tests for bug #1046870\nand is one of serveral patches in nova needed to enable\ntest_servers_negative.py in tempest.\n\nChange-Id: I6130863a95567eabd3ae05a09e4a9f26bb5f5098\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d6999fbe8c545292a98c4e3d20f3b80e3e66d901"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d6999fbe8c545292a98c4e3d20f3b80e3e66d901"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"b58bd0cd9a6ecb960a7c833d1f4857629ed1ab05","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}