)]}'
{"id":"openstack%2Fnova~2321","triplet_id":"openstack%2Fnova~master~I287058d3b2315562f2980999239fcd3240d2b1ec","project":"openstack/nova","branch":"master","topic":"jd/virt-staticmethods","hashtags":[],"change_id":"I287058d3b2315562f2980999239fcd3240d2b1ec","subject":"Make various methods static","status":"MERGED","created":"2011-12-14 15:41:55.000000000","updated":"2011-12-15 03:02:52.000000000","submitted":"2011-12-15 03:02:51.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"b48a14eb50ee1acc8b9ca6e18a9bc5e5c36e27dc","_number":2321,"virtual_id_number":2321,"owner":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"actions":{},"labels":{"Verified":{"recommended":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":1,"date":"2011-12-15 03:02:51.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","value":1,"default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"recommended":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"all":[{"value":1,"date":"2011-12-14 18:52:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"date":"2011-12-15 03:02:51.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"date":"2011-12-14 17:00:48.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":1,"date":"2011-12-14 20:48:59.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":2,"date":"2011-12-15 02:53:15.000000000","_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"value":0,"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2011-12-14 17:00:48.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2011-12-14 18:52:46.000000000","updated_by":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"reviewer":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"state":"REVIEWER"},{"updated":"2011-12-14 20:48:59.000000000","updated_by":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"reviewer":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"state":"REVIEWER"},{"updated":"2011-12-15 02:53:15.000000000","updated_by":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"reviewer":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"state":"REVIEWER"},{"updated":"2011-12-15 03:02:51.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"eda3d745702747c14b98a5a18e1ff7b9782cd2a6","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2011-12-14 17:00:48.000000000","message":"Patch Set 1:\n\nSmokeStack Results (patch set 1):\n\tUnit Success: http://smokestack.openstack.org/?go\u003d/jobs/5857\n\tLibvirt Success: http://smokestack.openstack.org/?go\u003d/jobs/5855\n\tXenServer Success: http://smokestack.openstack.org/?go\u003d/jobs/5856","accounts_in_message":[],"_revision_number":1},{"id":"8e9e308caafe25e1ec027865ed1028886cbe9172","author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"date":"2011-12-14 18:52:46.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nnice refactor","accounts_in_message":[],"_revision_number":1},{"id":"f3f831194946a16dc56641a9e18bc7c99d6ca156","author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"date":"2011-12-14 20:48:59.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nlgtm.","accounts_in_message":[],"_revision_number":1},{"id":"1c02cba9a48ca44950b7dcd62eaf6a1ea3058bc2","author":{"_account_id":1132,"name":"Brian Waldon","email":"brian@waldon.cc","username":"bcwaldon"},"date":"2011-12-15 02:53:15.000000000","message":"Patch Set 1: Looks good to me, approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"d1ce9ed819ef5a910058722ad2a11bdfdd24c3f8","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-15 03:02:51.000000000","message":"Patch Set 1: Verified\n\nBuild Successful \n \nhttps://jenkins.openstack.org/job/gate-nova-unittests/264/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-pep8/2027/ : SUCCESS \nhttps://jenkins.openstack.org/job/gate-nova-merge/652/ : SUCCESS","accounts_in_message":[],"_revision_number":1},{"id":"d3a9cc86fb4da3b1d602a8aed88fda9f4f1d4568","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2011-12-15 03:02:52.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"a04a5fa0cc0f87193502da2e68efe5102aef55b3","revisions":{"a04a5fa0cc0f87193502da2e68efe5102aef55b3":{"kind":"REWORK","_number":1,"created":"2011-12-14 15:41:55.000000000","uploader":{"_account_id":1669,"name":"Julien Danjou","display_name":"jd","email":"julien@danjou.info","username":"jdanjou"},"ref":"refs/changes/21/2321/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/21/2321/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/2321/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/2321/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/21/2321/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/21/2321/1"}}},"commit":{"parents":[{"commit":"af54e79b7815c233c6e800bc79e428fe23f92eb7","subject":"Merge \"Added support for creating nova volume snapshots using OS API.\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/af54e79b7815c233c6e800bc79e428fe23f92eb7"}]}],"author":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-14 13:41:03.000000000","tz":60},"committer":{"name":"Julien Danjou","email":"julien.danjou@enovance.com","date":"2011-12-14 15:36:20.000000000","tz":60},"subject":"Make various methods static","message":"Make various methods static\n\nA lot of stuff in nova.virt contain methods that are\nactually static. Marking them this way makes the code clearer.\n\nChange-Id: I287058d3b2315562f2980999239fcd3240d2b1ec\nSigned-off-by: Julien Danjou \u003cjulien.danjou@enovance.com\u003e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a04a5fa0cc0f87193502da2e68efe5102aef55b3"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/a04a5fa0cc0f87193502da2e68efe5102aef55b3"}]},"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
