)]}'
{"nova/api/openstack/compute/servers.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"d2f629e97a8c4cb4c8837d98ae9571b784cf1f4b","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                exception.NetworkAmbiguous,"},{"line_number":667,"context_line":"                exception.NoUniqueMatch) as error:"},{"line_number":668,"context_line":"            raise exc.HTTPConflict(explanation\u003derror.format_message())"},{"line_number":669,"context_line":"        except exception.Invalid as error:"},{"line_number":670,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.format_message())"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        # If the caller wanted a reservation_id, return it"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_f7e914b8","line":669,"updated":"2015-11-11 13:08:00.000000000","message":"I feel this except is a little wide because \"create a server\" API executes a lot of operations and the above except will catch unexpected errors also which we don\u0027t expect.\n\nI feel\n\nhttps://github.com/openstack/nova/blob/master/nova/image/glance.py#L621\n\ncase should be translated to glance specific exception(new) and we need to catch it here instead of Invalid.","commit_id":"a61462724825c3a424731e673083aea5adafcf5e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"d06fbca9f4951e5657bdd56ab860574a11241df9","unresolved":false,"context_lines":[{"line_number":666,"context_line":"                exception.NetworkAmbiguous,"},{"line_number":667,"context_line":"                exception.NoUniqueMatch) as error:"},{"line_number":668,"context_line":"            raise exc.HTTPConflict(explanation\u003derror.format_message())"},{"line_number":669,"context_line":"        except exception.Invalid as error:"},{"line_number":670,"context_line":"            raise exc.HTTPBadRequest(explanation\u003derror.format_message())"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"        # If the caller wanted a reservation_id, return it"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_a4d558e5","line":669,"in_reply_to":"da85f559_f7e914b8","updated":"2015-11-12 12:34:10.000000000","message":"right, it\u0027s better, thanks","commit_id":"a61462724825c3a424731e673083aea5adafcf5e"}],"nova/exception.py":[{"author":{"_account_id":8866,"name":"Raildo Mascena de Sousa Filho","email":"rmascena@redhat.com","username":"raildo"},"change_message_id":"503a6764eba6bc34db38f5cc58cd063b94d1312e","unresolved":false,"context_lines":[{"line_number":558,"context_line":""},{"line_number":559,"context_line":""},{"line_number":560,"context_line":"class ImageBadRequest(Invalid):"},{"line_number":561,"context_line":"    msg_fmt \u003d _(\"Image reqest got BadRequest respones\")"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"class InstanceUnacceptable(Invalid):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_37a197f8","line":561,"updated":"2015-11-12 13:48:25.000000000","message":"s/reqest/request\n\ns/respones/responses.","commit_id":"b44ad1e25a301b0e1ad4b9b2532de7f1b518a7e9"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9a2d8734d5246dbc0bc0bf252fdb9995c83a5e54","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"class ImageBadRequest(Invalid):"},{"line_number":561,"context_line":"    msg_fmt \u003d _(\"Image request got BadRequest response\")"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"class InstanceUnacceptable(Invalid):"},{"line_number":565,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_id)s is unacceptable: %(reason)s\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_8ffd563d","line":562,"updated":"2015-11-16 02:52:41.000000000","message":"How about defining\n\n  msg_fmt \u003d _(\"Request of image %(image_id)s got BadRequest response\")\n\nfor easy knowing what image is wrong ?","commit_id":"a847856f2887e5408d1089804fe341f7c56a7bb9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"25c6494b2ef95d949669c1d50625f60ff46c0249","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"class ImageBadRequest(Invalid):"},{"line_number":561,"context_line":"    msg_fmt \u003d _(\"Image request got BadRequest response\")"},{"line_number":562,"context_line":""},{"line_number":563,"context_line":""},{"line_number":564,"context_line":"class InstanceUnacceptable(Invalid):"},{"line_number":565,"context_line":"    msg_fmt \u003d _(\"Instance %(instance_id)s is unacceptable: %(reason)s\")"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_9cd882f1","line":562,"in_reply_to":"da85f559_8ffd563d","updated":"2015-11-16 14:14:58.000000000","message":"ok, fixed it with \nRequest of image %(image_id)s got BadRequest response: %(response)s","commit_id":"a847856f2887e5408d1089804fe341f7c56a7bb9"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"b33b14432f87e8c409a0eb0d166fe6478172cd01","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"class ImageBadRequest(Invalid):"},{"line_number":561,"context_line":"    msg_fmt \u003d _(\"Request of image %(image_id)s got BadRequest response: \""},{"line_number":562,"context_line":"                \"(response)s\")"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"class InstanceUnacceptable(Invalid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_561af218","line":562,"updated":"2015-11-16 15:25:04.000000000","message":"response is format string here.","commit_id":"8d64d82d36aa215550e9838d77828f9abd663685"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"feb38d6f124baa4603423af3147e2cd50404e74c","unresolved":false,"context_lines":[{"line_number":559,"context_line":""},{"line_number":560,"context_line":"class ImageBadRequest(Invalid):"},{"line_number":561,"context_line":"    msg_fmt \u003d _(\"Request of image %(image_id)s got BadRequest response: \""},{"line_number":562,"context_line":"                \"(response)s\")"},{"line_number":563,"context_line":""},{"line_number":564,"context_line":""},{"line_number":565,"context_line":"class InstanceUnacceptable(Invalid):"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba8a016a_6e907696","line":562,"in_reply_to":"ba8a016a_561af218","updated":"2015-11-16 18:39:22.000000000","message":"I was bite by pig ...... you are right , will update","commit_id":"8d64d82d36aa215550e9838d77828f9abd663685"}],"nova/image/glance.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"9a2d8734d5246dbc0bc0bf252fdb9995c83a5e54","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    if isinstance(exc_value, glanceclient.exc.NotFound):"},{"line_number":619,"context_line":"        return exception.ImageNotFound(image_id\u003dimage_id)"},{"line_number":620,"context_line":"    if isinstance(exc_value, glanceclient.exc.BadRequest):"},{"line_number":621,"context_line":"        return exception.ImageBadRequest(six.text_type(exc_value))"},{"line_number":622,"context_line":"    return exc_value"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_4f49aeb6","line":621,"updated":"2015-11-16 02:52:41.000000000","message":"How about passing image_id like\n\n return exception.ImageBadRequest(image_id\u003dimage_id)\n\nrelated to exception.py comment ?","commit_id":"a847856f2887e5408d1089804fe341f7c56a7bb9"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"25c6494b2ef95d949669c1d50625f60ff46c0249","unresolved":false,"context_lines":[{"line_number":618,"context_line":"    if isinstance(exc_value, glanceclient.exc.NotFound):"},{"line_number":619,"context_line":"        return exception.ImageNotFound(image_id\u003dimage_id)"},{"line_number":620,"context_line":"    if isinstance(exc_value, glanceclient.exc.BadRequest):"},{"line_number":621,"context_line":"        return exception.ImageBadRequest(six.text_type(exc_value))"},{"line_number":622,"context_line":"    return exc_value"},{"line_number":623,"context_line":""},{"line_number":624,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_fc366eb3","line":621,"in_reply_to":"da85f559_4f49aeb6","updated":"2015-11-16 14:14:58.000000000","message":"ok, will do it","commit_id":"a847856f2887e5408d1089804fe341f7c56a7bb9"}],"nova/tests/unit/api/openstack/compute/test_serversV21.py":[{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1d475e7ea2db5f47afb6813ec19546634f6d4f2a","unresolved":false,"context_lines":[{"line_number":2955,"context_line":"                          self._test_create_extra, {})"},{"line_number":2956,"context_line":""},{"line_number":2957,"context_line":"    @mock.patch.object(compute_api.API, \u0027create\u0027,"},{"line_number":2958,"context_line":"                       side_effect\u003dexception.InstanceExists("},{"line_number":2959,"context_line":"                           name\u003d\u0027instance-name\u0027))"},{"line_number":2960,"context_line":"    def test_create_instance_raise_instance_exists(self, mock_create):"},{"line_number":2961,"context_line":"        self.assertRaises(webob.exc.HTTPConflict,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_d20a4ed2","line":2958,"updated":"2015-11-17 03:25:56.000000000","message":"here","commit_id":"1cb70f89b4948cee7de95568282043eb92de6b90"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"1d475e7ea2db5f47afb6813ec19546634f6d4f2a","unresolved":false,"context_lines":[{"line_number":2984,"context_line":"                          self.req, body\u003dself.body)"},{"line_number":2985,"context_line":""},{"line_number":2986,"context_line":"    @mock.patch.object(compute_api.API, \u0027create\u0027,"},{"line_number":2987,"context_line":"                       side_effect\u003dexception.ImageBadRequest)"},{"line_number":2988,"context_line":"    def test_create_instance_raise_invalid(self, mock_create):"},{"line_number":2989,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":2990,"context_line":"                          self.controller.create,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_720fe2e1","line":2987,"updated":"2015-11-17 03:25:56.000000000","message":"need to pass \"image_id\" and \"response\" like the other tests for passing unit test.","commit_id":"1cb70f89b4948cee7de95568282043eb92de6b90"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"bf1f27e10fb471a05caf7aadf23f9b4322979e8b","unresolved":false,"context_lines":[{"line_number":2984,"context_line":"                          self.req, body\u003dself.body)"},{"line_number":2985,"context_line":""},{"line_number":2986,"context_line":"    @mock.patch.object(compute_api.API, \u0027create\u0027,"},{"line_number":2987,"context_line":"                       side_effect\u003dexception.ImageBadRequest)"},{"line_number":2988,"context_line":"    def test_create_instance_raise_invalid(self, mock_create):"},{"line_number":2989,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":2990,"context_line":"                          self.controller.create,"}],"source_content_type":"text/x-python","patch_set":9,"id":"ba8a016a_0572bdad","line":2987,"in_reply_to":"ba8a016a_720fe2e1","updated":"2015-11-18 20:23:39.000000000","message":"indeed, forgot to run it locally...","commit_id":"1cb70f89b4948cee7de95568282043eb92de6b90"},{"author":{"_account_id":8556,"name":"Ghanshyam Maan","display_name":"Ghanshyam Maan","email":"gmaan.os14@gmail.com","username":"ghanshyam"},"change_message_id":"ffa1f3b20dfd504b4dbbb1ddd6af8268cb38fc99","unresolved":false,"context_lines":[{"line_number":2986,"context_line":"    @mock.patch.object(compute_api.API, \u0027create\u0027,"},{"line_number":2987,"context_line":"                       side_effect\u003dexception.ImageBadRequest("},{"line_number":2988,"context_line":"                        image_id\u003d\u0027dummy\u0027, response\u003d\u0027dummy\u0027))"},{"line_number":2989,"context_line":"    def test_create_instance_raise_invalid(self, mock_create):"},{"line_number":2990,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":2991,"context_line":"                          self.controller.create,"},{"line_number":2992,"context_line":"                          self.req, body\u003dself.body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_aac5953c","line":2989,"updated":"2015-11-18 04:02:44.000000000","message":"as ImageBadRequest is being raised how about renaming this test - test_create_instance_raise_invalid \u003d\u003e test_create_instance_raise_image_bad_request","commit_id":"f497565bb464952a08b70a791cc2b0e668a8eeb3"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c72b03b211e2588001432a93ca18e60e6ecb1eee","unresolved":false,"context_lines":[{"line_number":2986,"context_line":"    @mock.patch.object(compute_api.API, \u0027create\u0027,"},{"line_number":2987,"context_line":"                       side_effect\u003dexception.ImageBadRequest("},{"line_number":2988,"context_line":"                        image_id\u003d\u0027dummy\u0027, response\u003d\u0027dummy\u0027))"},{"line_number":2989,"context_line":"    def test_create_instance_raise_invalid(self, mock_create):"},{"line_number":2990,"context_line":"        self.assertRaises(webob.exc.HTTPBadRequest,"},{"line_number":2991,"context_line":"                          self.controller.create,"},{"line_number":2992,"context_line":"                          self.req, body\u003dself.body)"}],"source_content_type":"text/x-python","patch_set":10,"id":"ba8a016a_659a5070","line":2989,"in_reply_to":"ba8a016a_aac5953c","updated":"2015-11-18 20:22:18.000000000","message":"yes, make sense, thanks","commit_id":"f497565bb464952a08b70a791cc2b0e668a8eeb3"}]}