)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"61bb8c3720cde8396673eb371d61843383fb7205","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-08 16:17:21 +0200"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"added support for \u0027insecure\u0027 option to ironic section in nova.conf"},{"line_number":8,"context_line":"Closes-Bug: #1504033"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"Change-Id: I4edb4a35c611e390dfc394befaea83ad531d74fd"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3a29b11f_78c012e1","line":8,"updated":"2015-10-26 11:02:34.000000000","message":"closes-bug is shown in head line without blank line (seen in subject)","commit_id":"5c2c44182effee2c3afde0764b5b0eddbd36edff"},{"author":{"_account_id":7872,"name":"Marc Koderer","email":"marc@koderer.com","username":"mkoderer"},"change_message_id":"224dc7e33b2a9385326afd8c6c725cda6ba7432b","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To prevent SSL certificate verification, the \u0027insecure\u0027 option was not supported"},{"line_number":10,"context_line":"to be configurable in the ironic section of nova.conf. The underlying driver does"},{"line_number":11,"context_line":"support the \u0027insecure\u0027 option, it was just ignored, when configured in nova.conf."},{"line_number":12,"context_line":"This change allows and reads the \u0027insecure\u0027 parameter from the ironic section, which"},{"line_number":13,"context_line":"then will be passed to the underlying driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1504033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"fa80f949_46945d8a","line":12,"updated":"2015-11-04 13:18:23.000000000","message":"Please have a look to [1]: Subsequent lines should be wrapped at 72 characters.\n[1]: https://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"5ef56ab77623856309d8f88e3ecc2b6dfdfd961f"},{"author":{"_account_id":6167,"name":"Ken\u0027ichi Ohmichi","email":"ken1ohmichi@gmail.com","username":"oomichi"},"change_message_id":"490ca32a73546259d5dab6decb6eb190935b3422","unresolved":false,"context_lines":[{"line_number":9,"context_line":"To prevent SSL certificate verification, the \u0027insecure\u0027 option was not supported"},{"line_number":10,"context_line":"to be configurable in the ironic section of nova.conf. The underlying driver does"},{"line_number":11,"context_line":"support the \u0027insecure\u0027 option, it was just ignored, when configured in nova.conf."},{"line_number":12,"context_line":"This change allows and reads the \u0027insecure\u0027 parameter from the ironic section, which"},{"line_number":13,"context_line":"then will be passed to the underlying driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Closes-Bug: #1504033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"da85f559_0db52ecc","line":12,"in_reply_to":"fa80f949_46945d8a","updated":"2015-11-09 05:08:04.000000000","message":"yeah, nice point.\nbut we have removed a hacking check for this kind of thing.\nSo it is fine for me at this time.","commit_id":"5ef56ab77623856309d8f88e3ecc2b6dfdfd961f"}],"nova/virt/ironic/driver.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"3439cf098070920edd8e8ec0f17f414d14cd73a7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"               default\u003d2,"},{"line_number":98,"context_line":"               help\u003d\u0027How often to retry in seconds when a request \u0027"},{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"               default\u003dFalse,"},{"line_number":102,"context_line":"               help\u003d\u0027Verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_5c7e9aaf","line":100,"updated":"2015-11-16 14:17:52.000000000","message":"indentations","commit_id":"ed55aede9e73bcbcbb92513628a04bf5041a24d1"},{"author":{"_account_id":8119,"name":"Eric Brown","email":"eric_wade_brown@yahoo.com","username":"ericwb"},"change_message_id":"21dd7440af6ebaba6e10f428f9f07cdb25d20cc1","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"               default\u003dFalse,"},{"line_number":102,"context_line":"               help\u003d\u0027Verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_afbe59fd","line":102,"updated":"2015-11-16 19:29:56.000000000","message":"This help message is sorta the opposite of what the expected values are.  I would expect to set to True to \"Verify\" connections.  But in reality I must set False to be \"not insecure\" (or secure).","commit_id":"ed55aede9e73bcbcbb92513628a04bf5041a24d1"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"76ce36cfdcf9f87a6b56ef970f44d9ce51c8c0a9","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"                default\u003dFalse,"},{"line_number":102,"context_line":"                help\u003d\u0027Do not verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_7949028b","line":102,"updated":"2015-11-17 08:38:56.000000000","message":"The help should also explain what the impact is when I set this to \"True\". What will explode then? Please check if you could provide more information here. You can use [1] for some guidance.\n\n[1] http://docs.openstack.org/developer/nova/code-review.html#config-options","commit_id":"3d368bedcf73af725917462c883b91d325a9c2a4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"cc136b656f9760d9f22d1990e4df4d5f647031dd","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"                default\u003dFalse,"},{"line_number":102,"context_line":"                help\u003d\u0027Do not verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_8b97a98f","line":102,"in_reply_to":"ba8a016a_6a5fe272","updated":"2015-11-17 10:11:52.000000000","message":"I have configured OpenStack services and don\u0027t know what it means. Since it is an interface to the cloud admins it would have been great to have it documented in a way which makes it understandable *without* having the experience from previous configurations. Nova can be configured with 800 (and growing) config options and it shouldn\u0027t be the burden of the user to figure out what each config option means in detail. I\u0027m not picky here to be a mean reviewer. Unfortunately I haven\u0027t used the other \"unsecure\" options before, that\u0027s why I couldn\u0027t give you a better proposal for the help text. The questions I provided were the best directions I could give to conclude a helpful description.","commit_id":"3d368bedcf73af725917462c883b91d325a9c2a4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"bcee374c2a42d25a92ff81c3966310a40fcf5b38","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"                default\u003dFalse,"},{"line_number":102,"context_line":"                help\u003d\u0027Do not verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_cf586059","line":102,"in_reply_to":"ba8a016a_7487c70f","updated":"2015-11-17 09:32:20.000000000","message":"@Tom: Which impact does insecure HTTPS requests to ironic have to the whole OpenStack system? Right now, I would never switch this option to \"True\". Why should I want that? I sounds like I\u0027m opening a gate for attacks?","commit_id":"3d368bedcf73af725917462c883b91d325a9c2a4"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"e0280b7209c45a01932b37fb625d222f43878b99","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"                default\u003dFalse,"},{"line_number":102,"context_line":"                help\u003d\u0027Do not verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_7487c70f","line":102,"in_reply_to":"ba8a016a_7949028b","updated":"2015-11-17 08:52:04.000000000","message":"Understood; I just copied this help from the various other occurences of \u0027insecure\u0027.\nWhat do you think about:\n\"Allow to perform insecure SSL (https) requests to ironic\"","commit_id":"3d368bedcf73af725917462c883b91d325a9c2a4"},{"author":{"_account_id":15371,"name":"Tom Patzig","email":"tom.patzig@sap.com","username":"tpatzig"},"change_message_id":"8c4f3e6af68b3625c14cce9ba49c367c2dc821ca","unresolved":false,"context_lines":[{"line_number":99,"context_line":"                    \u0027does conflict\u0027),"},{"line_number":100,"context_line":"    cfg.BoolOpt(\u0027insecure\u0027,"},{"line_number":101,"context_line":"                default\u003dFalse,"},{"line_number":102,"context_line":"                help\u003d\u0027Do not verify HTTPS connections.\u0027),"},{"line_number":103,"context_line":"    ]"},{"line_number":104,"context_line":""},{"line_number":105,"context_line":"ironic_group \u003d cfg.OptGroup(name\u003d\u0027ironic\u0027,"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_6a5fe272","line":102,"in_reply_to":"ba8a016a_cf586059","updated":"2015-11-17 09:48:51.000000000","message":"@Markus: it just means the same like all the other insecure options. Everyone who has ever configured any openstack service will know what that means. Don\u0027t be too fussy with that...\n\n\"Disable SSL cert verification for ironic api service requests.\"","commit_id":"3d368bedcf73af725917462c883b91d325a9c2a4"}]}