)]}'
{"doc/source/code-review.rst":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"ec4587b8549a23eda7fb11f23efb0fafade088be","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"A config option should be checked for:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* a short description which explains what it does. If it is a unit"},{"line_number":92,"context_line":"  (e.g. timeouts or so) describe the unit which is used (seconds, megabyte,"},{"line_number":93,"context_line":"  mebibyte, ...)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a2fa921_d823b1bb","line":91,"updated":"2015-10-09 17:00:21.000000000","message":"Can you capitalize the start of these bullets?","commit_id":"0c86268c8d7833d425b680467d75f64dd16468a4"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"d647c55c83747623ded44b5954d544e6ac70890b","unresolved":false,"context_lines":[{"line_number":88,"context_line":""},{"line_number":89,"context_line":"A config option should be checked for:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* a short description which explains what it does. If it is a unit"},{"line_number":92,"context_line":"  (e.g. timeouts or so) describe the unit which is used (seconds, megabyte,"},{"line_number":93,"context_line":"  mebibyte, ...)"},{"line_number":94,"context_line":""}],"source_content_type":"text/x-rst","patch_set":1,"id":"7a2fa921_bb6b4fb6","line":91,"in_reply_to":"7a2fa921_d823b1bb","updated":"2015-10-09 17:03:15.000000000","message":"As hard has I can and I throw some periods to the end of the sentences too.","commit_id":"0c86268c8d7833d425b680467d75f64dd16468a4"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ba87a64983c3293205fdc402b3ba0ea839790f78","unresolved":false,"context_lines":[{"line_number":89,"context_line":"A config option should be checked for:"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"* A short description which explains what it does. If it is a unit"},{"line_number":92,"context_line":"  (e.g. timeouts or so) describe the unit which is used (seconds, megabyte,"},{"line_number":93,"context_line":"  mebibyte, ...)."},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"* A long description which shows the impact and scope. The operators should"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_474d7898","line":92,"updated":"2015-10-09 19:08:05.000000000","message":"s/If it is a/If it has a/\n\ns/timeouts or so/timeouts, etc./","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"ba87a64983c3293205fdc402b3ba0ea839790f78","unresolved":false,"context_lines":[{"line_number":95,"context_line":"* A long description which shows the impact and scope. The operators should"},{"line_number":96,"context_line":"  know the expected change in the behavior of Nova if they tweak this."},{"line_number":97,"context_line":""},{"line_number":98,"context_line":"* Hints which services will consume this config option. Operators/Deployers"},{"line_number":99,"context_line":"  should not be forced to read the code to know which one of the services will"},{"line_number":100,"context_line":"  change its behavior nor should they set this in every ``nova.conf`` file to"},{"line_number":101,"context_line":"  be sure."}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_473498fa","line":98,"updated":"2015-10-09 19:08:05.000000000","message":"s/Hints which/Hints as to which/\n\nI presume these hints should be mentioned in the long description?","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"9b01a3ab3153cbb5933cf60cc9890969134a0e22","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    * If this is an option with numeric values (int, float), describe the"},{"line_number":106,"context_line":"      edge cases (like the min value, max value, 0, -1)."},{"line_number":107,"context_line":"    * If this is a DictOpt, describe the allowed keys."},{"line_number":108,"context_line":"    * If this is a StrOpt, lookout for regex validations."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Interdependencies to other options. If other config options have to be"},{"line_number":111,"context_line":"  considered when this config option gets changed, is this described?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_db1e4b0b","line":108,"range":{"start_line":108,"start_character":27,"end_line":108,"end_character":34},"updated":"2015-10-09 17:11:35.000000000","message":"s/lookout/look out\n\nAlso, I\u0027m not sure what this means. Maybe something like \"list valid values, or include a regex expression for validation\".","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"43d74e6504bfb778fec320d8e4ebaa03542dd64d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    * If this is an option with numeric values (int, float), describe the"},{"line_number":106,"context_line":"      edge cases (like the min value, max value, 0, -1)."},{"line_number":107,"context_line":"    * If this is a DictOpt, describe the allowed keys."},{"line_number":108,"context_line":"    * If this is a StrOpt, lookout for regex validations."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Interdependencies to other options. If other config options have to be"},{"line_number":111,"context_line":"  considered when this config option gets changed, is this described?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_5c8f8e74","line":108,"in_reply_to":"7a2fa921_861cf66a","updated":"2015-10-09 19:37:07.000000000","message":"And it has the choices kwarg for, well, valid choices.","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"b7e40f08e6431873c4505c5b6673d3497d73fde1","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    * If this is an option with numeric values (int, float), describe the"},{"line_number":106,"context_line":"      edge cases (like the min value, max value, 0, -1)."},{"line_number":107,"context_line":"    * If this is a DictOpt, describe the allowed keys."},{"line_number":108,"context_line":"    * If this is a StrOpt, lookout for regex validations."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Interdependencies to other options. If other config options have to be"},{"line_number":111,"context_line":"  considered when this config option gets changed, is this described?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_861cf66a","line":108,"range":{"start_line":108,"start_character":27,"end_line":108,"end_character":34},"in_reply_to":"7a2fa921_db1e4b0b","updated":"2015-10-09 17:25:17.000000000","message":"Yes, that\u0027s what I tried to say. The oslo.config string option allows a regex for validation: https://github.com/openstack/oslo.config/blob/master/oslo_config/types.py#L48","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"9b01a3ab3153cbb5933cf60cc9890969134a0e22","unresolved":false,"context_lines":[{"line_number":107,"context_line":"    * If this is a DictOpt, describe the allowed keys."},{"line_number":108,"context_line":"    * If this is a StrOpt, lookout for regex validations."},{"line_number":109,"context_line":""},{"line_number":110,"context_line":"* Interdependencies to other options. If other config options have to be"},{"line_number":111,"context_line":"  considered when this config option gets changed, is this described?"}],"source_content_type":"text/x-rst","patch_set":2,"id":"7a2fa921_bbea6fd9","line":110,"range":{"start_line":110,"start_character":20,"end_line":110,"end_character":22},"updated":"2015-10-09 17:11:35.000000000","message":"s/to/with","commit_id":"437e342895ebb48b8db1a153fb96e345e048023e"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"bf5189579cbd063348361986c101aa1f2d0dceeb","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    * If this is a StrOpt, lookout for regex validations."},{"line_number":111,"context_line":""},{"line_number":112,"context_line":"* Interdependencies to other options. If other config options have to be"},{"line_number":113,"context_line":"  considered when this config option gets changed, is this described?"}],"source_content_type":"text/x-rst","patch_set":3,"id":"7a2fa921_e3b10ee1","line":113,"updated":"2015-10-10 01:22:42.000000000","message":"Maybe add one more rule about how to remove an option. Something like we have to deprecated option first, then in next release we can remove it....","commit_id":"71fb6389a64e09509c86acf5969d6c7e42bb7f5c"}]}