)]}'
{"id":"openstack%2Fnova~23352","triplet_id":"openstack%2Fnova~master~If2710822cdf6e4ae108a6d1e7977735ac8104a2e","project":"openstack/nova","branch":"master","topic":"bug/1140778","hashtags":[],"change_id":"If2710822cdf6e4ae108a6d1e7977735ac8104a2e","subject":"Moves Hyper-V options to the hyperv section","status":"MERGED","created":"2013-03-02 22:18:35.000000000","updated":"2013-03-06 01:04:10.000000000","submitted":"2013-03-06 01:04:08.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"a4ed6fa1e7170a5ab3e25521c97805f99da3348b","_number":23352,"virtual_id_number":23352,"owner":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":2,"date":"2013-03-06 01:04:08.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":1,"date":"2013-03-05 15:23:19.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"recommended":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"all":[{"value":0,"date":"2013-03-05 15:58:58.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-05 15:02:46.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":2,"date":"2013-03-05 16:53:46.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2013-03-05 15:48:59.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":1,"date":"2013-03-05 16:53:46.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2013-03-05 15:48:59.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"description":"","default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-04 18:44:37.000000000","updated_by":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"reviewer":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"state":"REVIEWER"},{"updated":"2013-03-05 15:02:46.000000000","updated_by":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"reviewer":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"state":"REVIEWER"},{"updated":"2013-03-05 15:23:19.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-03-05 15:48:59.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-03-05 16:53:46.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-03-06 01:04:08.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"e8fbdd6e6c791c3ec9f3039dc63be19ad7e1d7dd","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-02 22:25:11.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23352/1/check/gate-nova-pep8/22107 : FAILURE\n- gate-nova-docs : SKIPPED\n- gate-nova-python26 : SKIPPED\n- gate-nova-python27 : SKIPPED\n- gate-tempest-devstack-vm-full : SKIPPED\n- gate-tempest-devstack-vm-postgres-full : SKIPPED\n- gate-tempest-devstack-vm-quantum : SKIPPED\n- gate-nova-pylint : SKIPPED (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"6d0e796992e08c547a0751d659a4214ed1f60694","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-02 22:38:05.000000000","message":"Patch Set 1: Work In Progress\n\nThis patch requires the latest https://github.com/openstack/oslo-config\n\nSee: https://bugs.launchpad.net/nova/+bug/1140310","accounts_in_message":[],"_revision_number":1},{"id":"adce2f4ac1ebcb83c927e60d820f385fd42a69e2","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-02 22:42:03.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/75935\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/75936\n","accounts_in_message":[],"_revision_number":1},{"id":"79be8b240ea7ecc9e9c30b50676f95e374c248be","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-04 10:12:13.000000000","message":"Patch Set 1: I would prefer that you didn\u0027t merge this\n\nThis commit does not appear to be merely renaming options. In addition to the rename, you have split one option into two - hyperv_wait_between_attach_retry now appears to be replaced by volume_attach_retry_interval and volume_attach_wait_time. Please make such a functional change separately from any renames.\n\nI also question whether this is really justified to break the feature freeze. This is really just style cleanup so I find it hard to think why it couldn\u0027t just wait until Havana, when we could do a mass conversion of all virt drivers to use groups for their config.","accounts_in_message":[],"_revision_number":1},{"id":"6e5ad71eeae4d6d06063ee648233999226ce44ad","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-04 10:15:43.000000000","message":"Patch Set 1:\n\nWe discussed already about this on IRC and on the ML and there was consensus on pushing it for Grizzly","accounts_in_message":[],"_revision_number":1},{"id":"013e2b41483f57a7be7537722ac3529833a8a561","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-04 11:03:11.000000000","message":"Patch Set 1:\n\nCan you post a link to the mailing list discussion, so reviewers can see this conclusion, as many won\u0027t be reading every mail on the list and so won\u0027t have noticed this decision.","accounts_in_message":[],"_revision_number":1},{"id":"fa641937542a2de1b954b8a1734d00faf9146c11","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-04 11:09:33.000000000","message":"Patch Set 1:\n\nSure: here\u0027s the related ML thread. Further conversations went on on IRC.","accounts_in_message":[],"_revision_number":1},{"id":"f9f5ab2c384da0d291928da93ed5d10dcda329f8","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-04 11:09:53.000000000","message":"Patch Set 1:\n\nOps, missing link :-) \n\nhttp://markmail.org/message/qkjbpqbtfwjf4sjy","accounts_in_message":[],"_revision_number":1},{"id":"6aff8a88e54dcfd1cb16dfc9da262a339a2c0a84","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-04 13:18:40.000000000","message":"Patch Set 1:\n\nI just pushed the oslo-config 2013.1b5 tag which has support for deprecated group - http://tarballs.openstack.org/oslo-config/oslo-config-2013.1b5.tar.gz","accounts_in_message":[],"_revision_number":1},{"id":"e8d99c50342451ee92f93808aa647e83df14ac96","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-04 13:58:14.000000000","message":"Patch Set 1:\n\nSince this patch is why 2013.1b5 is required, it makes sense to bump to 2013.1b5 in pip-requires in this patch","accounts_in_message":[],"_revision_number":1},{"id":"889f32f6433a52557865044ba5767a479604e3e3","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 11:57:45.000000000","message":"Patch Set 1: Rebased","accounts_in_message":[],"_revision_number":1},{"id":"8e73f0f236e8dbb62787c0ee01c201a886ec2a91","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-05 11:58:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nAutomatically re-added by Gerrit trivial rebase detection script.","accounts_in_message":[],"_revision_number":2},{"id":"0f9981b059a1932ba16cae784dde760eb6597b85","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-05 12:01:58.000000000","message":"Patch Set 2:\n\nI accept that people seem to think this is fine to break the freeze. My remaining point still stands though - as well as doing a rename, this patch is splitting one option into 2 new options. Such a functional change should be done as a separate patch from the non-functional renaming.","accounts_in_message":[],"_revision_number":2},{"id":"d32ecda288749dd2f8656b941adb7f7cef9d6a53","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 12:05:45.000000000","message":"Patch Set 2:\n\nHi Daniel,\n\nok np, I\u0027m splitting them. The additional option is due to the fact that a dev used a an option in a place where it doesn\u0027t make sense at all instead of creating an ad hoc one.","accounts_in_message":[],"_revision_number":2},{"id":"b76bd467b4552f5a1c30e97e5a00929717451004","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-05 12:17:05.000000000","message":"Patch Set 2: Works for me\n\nSmokeStack Results (patch set 2):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/76421\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/76422\n","accounts_in_message":[],"_revision_number":2},{"id":"6d1195f6060b8ff37bdbbb70d865b2537057d048","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-05 12:36:00.000000000","message":"Patch Set 2: I would prefer that you didn\u0027t merge this\n\nIf you\u0027re going to split out the hyperv_wait_between_attach_retry change, you should probably do it soon since the closer we get to RCs, the less likely this moving of options will be accepted\n\nAlso, the hyperv_wait_between_attach_retry change should come after the change to add the hyperv section - that way we can delay that change until Havana if needed\n\nAlso, can we please call this \u0027hyperv\u0027 instead of \u0027HYPERV\u0027. I don\u0027t think we need to shout :)","accounts_in_message":[],"_revision_number":2},{"id":"b1e9193e1c4e52de5d38ca4f942e25ecfcf94e2c","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 12:57:17.000000000","message":"Patch Set 2: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23352/2/check/gate-nova-pep8/22220 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-nova-docs/16676 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-nova-python26/18091 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-nova-python27/18173 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-tempest-devstack-vm-full/6986 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-tempest-devstack-vm-postgres-full/6705 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-tempest-devstack-vm-quantum/11957 : SUCCESS\n- http://logs.openstack.org/23352/2/check/gate-nova-pylint/9104 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":2},{"id":"a59504ab065ec53c1cc0d3fa277169bac826e822","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 13:17:47.000000000","message":"Patch Set 2:\n\nMark,\n\nBy convention the sections are upper case in ini files, see for example [DEFAULT]. If you look at Quantum.conf file, all sections are upper case. In Nova we already have at least one option in [HYPERV].\n\nIMO we should be as consistent as possible with the rest of OpenStack.","accounts_in_message":[],"_revision_number":2},{"id":"2e48f93c28e6a0dfeb5e3f7d1b8a4cd959acaa21","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-05 13:22:48.000000000","message":"Patch Set 2:\n\nI tend to agree with both of you. I would prefer lowercase, but given that we seem to already have a defacto standard of using uppercase.\n\nUnless of course we want to rename all existing sections which are uppercase, to be lowercase too ?\n\nWhichever we decide on, we must enforce consistency of capitalization across all sections we have.","accounts_in_message":[],"_revision_number":2},{"id":"1f5d0ca6c62f58733caffdf77c72838fb67e65fa","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 13:26:57.000000000","message":"Patch Set 2:\n\nI\u0027d add that we should enforce it as an OpenStack wide default practice. \n\nFrom a user\u0027s perspective it\u0027s quite awful to name sections in uppercase in Quantum and lowercase in Nova, as an example.\n\nBeside that, since [DEFAULT] is uppercase, IMHO that should be the default for the other sections as well. Sorry, the DEFAULT. :-)","accounts_in_message":[],"_revision_number":2},{"id":"43dc6a712bb10cb906fe58f02fc5ebe8d70626e7","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-05 13:35:15.000000000","message":"Patch Set 2:\n\nQuantum is the outlier here - IMHO they should be using lowercase too\n\nHere\u0027s the groups we have in nova now:\n\n [HYPERV]\n [conductor]\n [cells]\n [zookeeper]\n [baremetal]\n [rpc_notifier2]\n [trusted_computing]\n [vmware]\n [spice]","accounts_in_message":[],"_revision_number":2},{"id":"5b7dc2d0943319c8bc72e62ec30c9a1533c2da46","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-05 13:37:50.000000000","message":"Patch Set 2:\n\nOk, clearly I should have done better research on Nova usage :-) Given that balance of upper/lower case in Nova, I agree we should be using \u0027hyperv\u0027 not \"HYPERV\".","accounts_in_message":[],"_revision_number":2},{"id":"c8f555e8c43f6eed80b8ba6cd5b1e9548235723e","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 14:58:43.000000000","message":"Uploaded patch set 3.","accounts_in_message":[],"_revision_number":3},{"id":"b147a8a693693ae64bc794068e8b314061c03e27","author":{"_account_id":1779,"name":"Daniel Berrange","email":"berrange@redhat.com","username":"berrange"},"date":"2013-03-05 15:02:46.000000000","message":"Patch Set 3: Looks good to me, but someone else must approve\n\n","accounts_in_message":[],"_revision_number":3},{"id":"67fe49fdc77f05e382418796c1e877e0286cabe1","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-05 15:23:19.000000000","message":"Patch Set 3: Works for me\n\nSmokeStack Results (patch set 3):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/76449\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/76450\n","accounts_in_message":[],"_revision_number":3},{"id":"5dafe238b07ce65aaab9eecb1387670e17671fb8","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-05 15:48:59.000000000","message":"Patch Set 3: Looks good to me (core reviewer)\n\n","accounts_in_message":[],"_revision_number":3},{"id":"7fdefc4fe23529fe28e72dfc37e1d0378633ab0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 15:54:34.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23352/3/check/gate-nova-pep8/22228 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-docs/16684 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python26/18099 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python27/18181 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-full/7014 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-postgres-full/6733 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-quantum/11992 : FAILURE\n- http://logs.openstack.org/23352/3/check/gate-nova-pylint/9107 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"d1824c56982cad3a426d7bd8429b934357580688","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 15:58:58.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"8329fa58aca2f1a996ec9beb45a1597c929849d6","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-05 16:53:46.000000000","message":"Patch Set 3: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":3},{"id":"fe62a650500621cbfd0310ddf4eb4c7563b25320","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 16:53:57.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"bacbbae3d78639fdb7d78f0944ebf33ccf64b02e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 17:04:45.000000000","message":"Patch Set 3: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23352/3/check/gate-nova-pep8/22241 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-docs/16698 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python26/18113 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python27/18195 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-full/7040 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-postgres-full/6759 : FAILURE\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-quantum/12019 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-pylint/9119 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"31122c90047a1da28d7f1bb188c5c33aa5d41355","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 17:11:37.000000000","message":"Patch Set 3:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":3},{"id":"3fa7b922a7f1fe2a4feabce883b2a4485a4eb02f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 18:26:28.000000000","message":"Patch Set 3: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23352/3/check/gate-nova-pep8/22253 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-docs/16709 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python26/18123 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-python27/18206 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-full/7079 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-postgres-full/6796 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-tempest-devstack-vm-quantum/12062 : SUCCESS\n- http://logs.openstack.org/23352/3/check/gate-nova-pylint/9121 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":3},{"id":"587981627fe2cc58de82bbeec7fe7994aac19bef","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 21:05:50.000000000","message":"Patch Set 3: Fails\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23352/3/gate/gate-nova-docs/16740 : FAILURE\n- http://logs.openstack.org/23352/3/gate/gate-nova-pep8/22284 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-nova-python26/18154 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-nova-python27/18237 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-full/7166 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-postgres-full/6883 : FAILURE\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-quantum/12167 : FAILURE\n","accounts_in_message":[],"_revision_number":3},{"id":"bbc04854ff5fb1ec0f3fa63635d292188952cffb","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-05 21:32:41.000000000","message":"Patch Set 3:\n\nreverify no bug","accounts_in_message":[],"_revision_number":3},{"id":"4e3036b84c162dffb1d58dce475c5b05a54fa02f","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 21:44:57.000000000","message":"Patch Set 3: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":3},{"id":"6f94d97526741187d63e83413549e364fd3f67ea","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 01:04:08.000000000","message":"Patch Set 3: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23352/3/gate/gate-nova-docs/16772 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-nova-pep8/22319 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-nova-python26/18186 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-nova-python27/18269 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-full/7268 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-postgres-full/6985 : SUCCESS\n- http://logs.openstack.org/23352/3/gate/gate-tempest-devstack-vm-quantum/12294 : SUCCESS\n","accounts_in_message":[],"_revision_number":3},{"id":"cee4e81eaed1e785f59cb72eea319dcdd3d825c6","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-06 01:04:10.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":3}],"current_revision_number":3,"current_revision":"eed3bce42531b10ec94c518de29fee7092f48f15","revisions":{"3c731c82614cd714367116efe84188ad3809600f":{"kind":"REWORK","_number":1,"created":"2013-03-02 22:18:35.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/52/23352/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/52/23352/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/52/23352/1"}}},"commit":{"parents":[{"commit":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","subject":"Merge \"Implement rules_exist method for quantum security group driver\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5e728ca08e250ee537f5bbf0f7c2df4c899c76b"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 22:12:21.000000000","tz":120},"committer":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 22:12:21.000000000","tz":120},"subject":"Moves Hyper-V options to the HYPERV section","message":"Moves Hyper-V options to the HYPERV section\n\nFixes Bug: 1140778\n\nDue to the large number of options available in Nova, in order to\nachieve better option organization and naming (e.g. avoid the hyperv_*\nprefix) and to avoid option name clashes, options specific to the\nHyper-V driver are moved to a section named \"HYPERV\".\n\nBackwards compatibility is mantained by providing the \"deprecated_group\"\nargument in option definitions.\n\nChange-Id: If2710822cdf6e4ae108a6d1e7977735ac8104a2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c731c82614cd714367116efe84188ad3809600f"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3c731c82614cd714367116efe84188ad3809600f"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"3349491b5246d865669d34a146bc6e8d376b33d5":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2013-03-02 22:18:35.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/52/23352/2","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/52/23352/2","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/52/23352/2"}}},"commit":{"parents":[{"commit":"899d518aec818bc7609f523baa6bc1dfd45d2ece","subject":"Merge \"Fix an error in compute api snapshot_volume_backed bdm code\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/899d518aec818bc7609f523baa6bc1dfd45d2ece"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 22:12:21.000000000","tz":120},"committer":{"name":"Gerrit Code Review","email":"review@openstack.org","date":"2013-03-05 11:57:44.000000000","tz":0},"subject":"Moves Hyper-V options to the HYPERV section","message":"Moves Hyper-V options to the HYPERV section\n\nFixes Bug: 1140778\n\nDue to the large number of options available in Nova, in order to\nachieve better option organization and naming (e.g. avoid the hyperv_*\nprefix) and to avoid option name clashes, options specific to the\nHyper-V driver are moved to a section named \"HYPERV\".\n\nBackwards compatibility is mantained by providing the \"deprecated_group\"\nargument in option definitions.\n\nChange-Id: If2710822cdf6e4ae108a6d1e7977735ac8104a2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3349491b5246d865669d34a146bc6e8d376b33d5"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/3349491b5246d865669d34a146bc6e8d376b33d5"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"899d518aec818bc7609f523baa6bc1dfd45d2ece","is_merged_in_target_branch":true}],"branch":"refs/heads/master"},"eed3bce42531b10ec94c518de29fee7092f48f15":{"kind":"REWORK","_number":3,"created":"2013-03-05 14:58:43.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/52/23352/3","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/52/23352/3","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/3 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/3 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/52/23352/3 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/52/23352/3"}}},"commit":{"parents":[{"commit":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","subject":"Merge \"Implement rules_exist method for quantum security group driver\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5e728ca08e250ee537f5bbf0f7c2df4c899c76b"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 22:12:21.000000000","tz":120},"committer":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-05 14:57:50.000000000","tz":120},"subject":"Moves Hyper-V options to the hyperv section","message":"Moves Hyper-V options to the hyperv section\n\nFixes Bug: 1140778\n\nDue to the large number of options available in Nova, in order to\nachieve better option organization and naming (e.g. avoid the hyperv_*\nprefix) and to avoid option name clashes, options specific to the\nHyper-V driver are moved to a section named \"hyperv\".\n\nBackwards compatibility is mantained by providing the \"deprecated_group\"\nargument in option definitions.\n\nFor case consistency the group name as been changed to \"hyperv\" for options\nintroduced in Grizzly belonging to the group \"HYPERV\"\n\nChange-Id: If2710822cdf6e4ae108a6d1e7977735ac8104a2e\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eed3bce42531b10ec94c518de29fee7092f48f15"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/eed3bce42531b10ec94c518de29fee7092f48f15"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}