)]}'
{"id":"openstack%2Fnova~23354","triplet_id":"openstack%2Fnova~master~I27b39ac41e97840d2a60006b1c74f6d256bc53b7","project":"openstack/nova","branch":"master","topic":"bug/1140917","hashtags":[],"change_id":"I27b39ac41e97840d2a60006b1c74f6d256bc53b7","subject":"Fixes live migration with attached volumes issue","status":"MERGED","created":"2013-03-02 23:43:01.000000000","updated":"2013-03-05 03:14:14.000000000","submitted":"2013-03-05 03:14:12.000000000","submitter":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"meta_rev_id":"56d3c773aa985377d4dff7260a9ac9ca8fb53071","_number":23354,"virtual_id_number":23354,"owner":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"actions":{},"labels":{"Verified":{"approved":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},{"value":2,"date":"2013-03-05 03:14:12.000000000","_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":1,"date":"2013-03-03 00:06:43.000000000","_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Fails","-1":"Doesn\u0027t seem to work"," 0":"No score","+1":"Works for me","+2":"Verified"},"description":"","default_value":0,"optional":true},"Code-Review":{"approved":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"recommended":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"all":[{"value":0,"date":"2013-03-03 00:38:54.000000000","permitted_voting_range":{"min":0,"max":1},"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":1,"date":"2013-03-04 14:18:42.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":1,"date":"2013-03-03 03:30:39.000000000","permitted_voting_range":{"min":1,"max":1},"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":2,"date":"2013-03-04 19:57:56.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":2,"date":"2013-03-05 02:12:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":2,"date":"2013-03-04 08:57:27.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-2":"Do not merge","-1":"This patch needs further work before it can be merged"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me (core reviewer)"},"description":"","value":1,"default_value":0,"optional":true},"Workflow":{"approved":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"date":"2013-03-04 19:57:56.000000000","_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":1,"date":"2013-03-05 02:12:19.000000000","_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"date":"2013-03-04 08:57:27.000000000","_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{"-1":"Work in progress"," 0":"Ready for reviews","+1":"Approved"},"description":"","default_value":0,"optional":true},"Review-Priority":{"all":[{"value":0,"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"value":0,"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},{"value":0,"_account_id":3,"name":"Jenkins","username":"jenkins"},{"value":0,"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"value":0,"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"value":0,"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"value":0,"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"value":0,"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"}],"values":{" 0":"Default Priority","+1":"Contributor Review Promise","+2":"Core Review Promise"},"default_value":0,"optional":true}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":3,"name":"Jenkins","username":"jenkins"},{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2013-03-03 00:06:43.000000000","updated_by":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"reviewer":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"state":"REVIEWER"},{"updated":"2013-03-03 03:30:39.000000000","updated_by":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"reviewer":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"state":"REVIEWER"},{"updated":"2013-03-04 08:57:27.000000000","updated_by":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"reviewer":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"state":"REVIEWER"},{"updated":"2013-03-04 14:18:42.000000000","updated_by":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"reviewer":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"state":"REVIEWER"},{"updated":"2013-03-04 19:57:56.000000000","updated_by":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"reviewer":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"state":"REVIEWER"},{"updated":"2013-03-05 02:12:19.000000000","updated_by":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"reviewer":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"state":"REVIEWER"},{"updated":"2013-03-05 03:14:12.000000000","updated_by":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"reviewer":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"state":"REVIEWER"}],"messages":[{"id":"72301effdd71dcfd9962ce7d4e82acce8972d63d","author":{"_account_id":2166,"name":"SmokeStack CI","username":"smokestack","tags":["SERVICE_USER"]},"date":"2013-03-03 00:06:43.000000000","message":"Patch Set 1: Works for me\n\nSmokeStack Results (patch set 1):\n\tLibvirt (Fedora 17) Success: http://smokestack.openstack.org/?go\u003d/jobs/75939\n\tXenServer 5.6 (F17 domU) Success: http://smokestack.openstack.org/?go\u003d/jobs/75940\n","accounts_in_message":[],"_revision_number":1},{"id":"b32bda2161badbc8c5e6dd31ff674f9f2d5f465e","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-03 00:28:30.000000000","message":"Patch Set 1: Doesn\u0027t seem to work\n\nBuild failed.  For information on how to proceed, see https://wiki.openstack.org/wiki/GerritJenkinsGithub#Test_Failures\n\n- http://logs.openstack.org/23354/1/check/gate-nova-pep8/22108 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-docs/16575 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-python26/17990 : FAILURE\n- http://logs.openstack.org/23354/1/check/gate-nova-python27/18072 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-full/6720 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-postgres-full/6439 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-quantum/11594 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-pylint/9045 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"84b21c0a8173f79eb1550cb98ea4d84cdde49ce0","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-03 00:38:54.000000000","message":"Patch Set 1:\n\nrecheck","accounts_in_message":[],"_revision_number":1},{"id":"cc10837908c45ca6c21f959ce546ef1cce994198","author":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"date":"2013-03-03 00:41:49.000000000","message":"Patch Set 1:\n\nrecheck no bug","accounts_in_message":[],"_revision_number":1},{"id":"210a8fcef9cc118eb57d304ceecb6d5ad3cea28d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-03 01:20:06.000000000","message":"Patch Set 1: Works for me\n\nBuild succeeded.\n\n- http://logs.openstack.org/23354/1/check/gate-nova-pep8/22111 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-docs/16577 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-python26/17992 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-python27/18074 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-full/6724 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-postgres-full/6443 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-tempest-devstack-vm-quantum/11599 : SUCCESS\n- http://logs.openstack.org/23354/1/check/gate-nova-pylint/9047 : SUCCESS (non-voting)\n","accounts_in_message":[],"_revision_number":1},{"id":"23c831fb7d459b902cd42566dbb3c1f6fc8deb80","author":{"_account_id":1525,"name":"Rafi Khardalian","email":"rafi@metacloud.com","username":"rkhardalian"},"date":"2013-03-03 03:30:39.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nWell then, that\u0027s a nice simple fix.","accounts_in_message":[],"_revision_number":1},{"id":"99ab50ec57068d71d8fefbab6b919e2eef84cb04","author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"date":"2013-03-04 08:57:27.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nSeems nice and straightforward\n\nWould been good to add a failing unit test that would have caught this","accounts_in_message":[],"_revision_number":1},{"id":"6506e547e0cf3c75baf1d3c7bc5ac9fa73759c5b","author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"date":"2013-03-04 14:18:42.000000000","message":"Patch Set 1: Looks good to me, but someone else must approve\n\nI added some test coverage for this in a dependent patch.","accounts_in_message":[],"_revision_number":1},{"id":"6d590ba490de0d9b98e7c4d2760762d942f15c74","author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"date":"2013-03-04 19:57:56.000000000","message":"Patch Set 1: Looks good to me (core reviewer)\n\nLooks good. Where is the dependent patch with the test code though?","accounts_in_message":[],"_revision_number":1},{"id":"a423a75e1c7ca7b12ad40b5b1f4fc87d59a7783c","author":{"_account_id":6450,"name":"Hans Lindgren","email":"hanlind@kth.se","username":"hanlind"},"date":"2013-03-04 20:25:39.000000000","message":"Patch Set 1:\n\nhttps://review.openstack.org/#/c/23376/\n\nThe modified tests in that review are able to detect this error, but as I have noted, someone with deeper knowledge of the volume backed code should add complete test coverage of the compute api methods that lacks tests today.","accounts_in_message":[],"_revision_number":1},{"id":"a265a9469fc1b4b8b8b0b1edd1cb01ee2bc8cea4","author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"date":"2013-03-05 02:12:19.000000000","message":"Patch Set 1: Looks good to me (core reviewer); Approved\n\n","accounts_in_message":[],"_revision_number":1},{"id":"fd3b400d77059f1ad4cfe3e64747ec73668cd8dc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 02:12:25.000000000","message":"Patch Set 1: No score\n\nStarting gate jobs.\nhttp://status.openstack.org/zuul/","accounts_in_message":[],"_revision_number":1},{"id":"8ab9ee6c065e6a9e4930b6b44f6e0a9732925f0d","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 03:14:12.000000000","message":"Patch Set 1: Verified\n\nBuild succeeded.\n\n- http://logs.openstack.org/23354/1/gate/gate-nova-docs/16653 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-nova-pep8/22192 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-nova-python26/18068 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-nova-python27/18150 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-tempest-devstack-vm-full/6930 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-tempest-devstack-vm-postgres-full/6649 : SUCCESS\n- http://logs.openstack.org/23354/1/gate/gate-tempest-devstack-vm-quantum/11872 : SUCCESS\n","accounts_in_message":[],"_revision_number":1},{"id":"19e40d3d13c5dab75f93e666dfe6da2f20b240cc","author":{"_account_id":3,"name":"Jenkins","username":"jenkins"},"date":"2013-03-05 03:14:14.000000000","message":"Change has been successfully merged into the git repository.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"690d8f3d4061443b149b13f96116ad72e5dcb06c","revisions":{"690d8f3d4061443b149b13f96116ad72e5dcb06c":{"kind":"REWORK","_number":1,"created":"2013-03-02 23:43:01.000000000","uploader":{"_account_id":3185,"name":"Alessandro Pilotti","email":"apilotti@cloudbasesolutions.com","username":"alexpilotti"},"ref":"refs/changes/54/23354/1","fetch":{"anonymous http":{"url":"https://review.opendev.org/openstack/nova","ref":"refs/changes/54/23354/1","commands":{"Checkout":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/23354/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/23354/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://review.opendev.org/openstack/nova refs/changes/54/23354/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://review.opendev.org/openstack/nova refs/changes/54/23354/1"}}},"commit":{"parents":[{"commit":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","subject":"Merge \"Implement rules_exist method for quantum security group driver\"","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/d5e728ca08e250ee537f5bbf0f7c2df4c899c76b"}]}],"author":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 23:40:11.000000000","tz":120},"committer":{"name":"Alessandro Pilotti","email":"ap@pilotti.it","date":"2013-03-02 23:40:11.000000000","tz":120},"subject":"Fixes live migration with attached volumes issue","message":"Fixes live migration with attached volumes issue\n\nFixes Bug: 1140917\n\nLive migration fails when there are volumes attached to the instance\n\nChange-Id: I27b39ac41e97840d2a60006b1c74f6d256bc53b7\n","web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/690d8f3d4061443b149b13f96116ad72e5dcb06c"}],"resolve_conflicts_web_links":[{"name":"gitea","tooltip":"Open in GitWeb","url":"https://opendev.org/openstack/nova/commit/690d8f3d4061443b149b13f96116ad72e5dcb06c"}]},"parents_data":[{"branch_name":"refs/heads/master","commit_id":"d5e728ca08e250ee537f5bbf0f7c2df4c899c76b","is_merged_in_target_branch":true}],"branch":"refs/heads/master"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
