)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"42ffabeae37b6f033b9cd708f6c835ff120ef5de","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Nimish \u003cjnimish77@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 15:01:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"*Nova can incorrectly think an instance is volume backed"},{"line_number":8,"context_line":"if instance is booted with \"nova boot...\",it confuses api.py \u0026"},{"line_number":9,"context_line":"assume if image_ref isn\u0027t set then theinstance is volume backed."},{"line_number":10,"context_line":"closes Bug: #1501851"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a2ca52d_0aaf0b82","line":7,"updated":"2015-10-15 05:09:04.000000000","message":"please see https://wiki.openstack.org/wiki/GitCommitMessages on how to write the commit messages","commit_id":"7d6372e6290b6b2e48613c069a73b1707f90942a"}],"nova/compute/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"42ffabeae37b6f033b9cd708f6c835ff120ef5de","unresolved":false,"context_lines":[{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    def is_volume_backed_instance(self, context, instance, bdms\u003dNone):"},{"line_number":3263,"context_line":"        if not instance.image_ref:"},{"line_number":3264,"context_line":"            return False"},{"line_number":3265,"context_line":""},{"line_number":3266,"context_line":"        root_bdm \u003d self._get_root_bdm(context, instance, bdms)"},{"line_number":3267,"context_line":"        if not root_bdm:"}],"source_content_type":"text/x-python","patch_set":4,"id":"5a2ca52d_aab4d7d0","line":3264,"updated":"2015-10-15 05:09:04.000000000","message":"this does not seem right. if you are to return False you should also check that no BDMS are defined.\n\nThe unit tests break due to this change","commit_id":"7d6372e6290b6b2e48613c069a73b1707f90942a"},{"author":{"_account_id":9555,"name":"Matthew Booth","email":"mbooth@redhat.com","username":"MatthewBooth"},"change_message_id":"0e17e7dfd226fb7bbc21ab6e4a5c4919865a9975","unresolved":false,"context_lines":[{"line_number":3261,"context_line":""},{"line_number":3262,"context_line":"    def is_volume_backed_instance(self, context, instance, bdms\u003dNone):"},{"line_number":3263,"context_line":"        if not instance.image_ref:"},{"line_number":3264,"context_line":"            return False"},{"line_number":3265,"context_line":""},{"line_number":3266,"context_line":"        root_bdm \u003d self._get_root_bdm(context, instance, bdms)"},{"line_number":3267,"context_line":"        if not root_bdm:"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_850c8295","line":3264,"in_reply_to":"5a2ca52d_aab4d7d0","updated":"2015-11-04 10:48:52.000000000","message":"You are saying that any instance which does not have an image_ref is not volume backed. This is most certainly wrong.","commit_id":"7d6372e6290b6b2e48613c069a73b1707f90942a"}]}
