)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d23093089fe84973a4ee0d01d674c5d7f84e37a1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nova.virt.driver.ComputeDriver.estimate_instance_overhead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Updates ResourceTracker to create Claims using the new overhead."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idd55d8c8cb19fe1eb9662021a483cee4051f1d1f"},{"line_number":19,"context_line":"Partial-Bug: #1505681"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_651b891c","line":17,"updated":"2015-11-17 13:03:23.000000000","message":"I think that this require DocImpact as we are changing a driver API","commit_id":"5e021e3673626ac9075e2dd08e5a082572969256"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"09f88ef8c9ec10069c2145f5fb053b7cce19228a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"nova.virt.driver.ComputeDriver.estimate_instance_overhead."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Updates ResourceTracker to create Claims using the new overhead."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Idd55d8c8cb19fe1eb9662021a483cee4051f1d1f"},{"line_number":19,"context_line":"Partial-Bug: #1505681"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"ba8a016a_48be9cd5","line":17,"in_reply_to":"ba8a016a_651b891c","updated":"2015-11-17 13:49:35.000000000","message":"Done","commit_id":"5e021e3673626ac9075e2dd08e5a082572969256"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"3490b9b7da4e9d6b55dbacbae36fc0f7d8950a79","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Updates ResourceTracker to create Claims using the new overhead."},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"DocImpact"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: Idd55d8c8cb19fe1eb9662021a483cee4051f1d1f"},{"line_number":21,"context_line":"Partial-Bug: #1505681"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"7a740942_7320e148","line":18,"updated":"2015-12-07 18:35:20.000000000","message":"maybe detail on what\u0027s the impact?","commit_id":"22a689c0b02850605397e797953b74438668d7d5"}],"nova/compute/resource_tracker.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"d23093089fe84973a4ee0d01d674c5d7f84e37a1","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                          \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":248,"context_line":"        LOG.debug(\"Disk overhead for %(flavor)d GB instance; %(overhead)d \""},{"line_number":249,"context_line":"                  \"GB\", {\u0027flavor\u0027: instance.root_gb,"},{"line_number":250,"context_line":"                         \u0027overhead\u0027: overhead[\u0027disk_gb\u0027]})"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        claim \u003d claims.MoveClaim(context, instance, new_instance_type,"},{"line_number":253,"context_line":"                                 image_meta, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_4593e54f","line":250,"updated":"2015-11-17 13:03:23.000000000","message":"this should be:  overhead.get(\u0027disk_gb\u0027, 0) it could blow up for drivers out of tree","commit_id":"5e021e3673626ac9075e2dd08e5a082572969256"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"09f88ef8c9ec10069c2145f5fb053b7cce19228a","unresolved":false,"context_lines":[{"line_number":247,"context_line":"                          \u0027overhead\u0027: overhead[\u0027memory_mb\u0027]})"},{"line_number":248,"context_line":"        LOG.debug(\"Disk overhead for %(flavor)d GB instance; %(overhead)d \""},{"line_number":249,"context_line":"                  \"GB\", {\u0027flavor\u0027: instance.root_gb,"},{"line_number":250,"context_line":"                         \u0027overhead\u0027: overhead[\u0027disk_gb\u0027]})"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"        claim \u003d claims.MoveClaim(context, instance, new_instance_type,"},{"line_number":253,"context_line":"                                 image_meta, self, self.compute_node,"}],"source_content_type":"text/x-python","patch_set":5,"id":"ba8a016a_e8267067","line":250,"in_reply_to":"ba8a016a_4593e54f","updated":"2015-11-17 13:49:35.000000000","message":"sure, makes sense.","commit_id":"5e021e3673626ac9075e2dd08e5a082572969256"}],"nova/tests/unit/compute/test_claims.py":[{"author":{"_account_id":15524,"name":"dane-fichter","email":"dane.fichter@jhuapl.edu","username":"dane-fichter"},"change_message_id":"db28205fd709558de71fd3cf8edbfeff128ed655","unresolved":false,"context_lines":[{"line_number":172,"context_line":"                    \u0027disk_gb\u0027: 1}"},{"line_number":173,"context_line":"        limits \u003d {\u0027disk_gb\u0027: 100}"},{"line_number":174,"context_line":"        self._claim(root_gb\u003d99, ephemeral_gb\u003d0, limits\u003dlimits,"},{"line_number":175,"context_line":"                    overhead\u003doverhead)"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"    def test_disk_with_overhead_insufficient(self, mock_get):"},{"line_number":178,"context_line":"        overhead \u003d {\u0027memory_mb\u0027: 0,"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_d47301e6","line":175,"updated":"2015-11-17 14:31:18.000000000","message":"Since you\u0027ve changed the way that the disk_gb method of the Claim class works in this change, I think you should check that the Claim object you get back from calling self._claim has the correct disk_gb at the end of this test.","commit_id":"75bb7f1e4bb3272125a93e5de573fe6a4ef666aa"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            db_numa_topology \u003d None"},{"line_number":85,"context_line":"        if overhead is None:"},{"line_number":86,"context_line":"            overhead \u003d {\u0027memory_mb\u0027: 0,"},{"line_number":87,"context_line":"                        \u0027disk_gb\u0027: 0}"},{"line_number":88,"context_line":"        with mock.patch.object("},{"line_number":89,"context_line":"                db, \u0027instance_extra_get_by_instance_uuid\u0027,"},{"line_number":90,"context_line":"                return_value\u003ddb_numa_topology):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_078b65c4","line":87,"updated":"2015-11-24 10:51:22.000000000","message":"I think this is not needed with the cleanup to use get(\u0027disk_gb\u0027, 0)","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":84,"context_line":"            db_numa_topology \u003d None"},{"line_number":85,"context_line":"        if overhead is None:"},{"line_number":86,"context_line":"            overhead \u003d {\u0027memory_mb\u0027: 0,"},{"line_number":87,"context_line":"                        \u0027disk_gb\u0027: 0}"},{"line_number":88,"context_line":"        with mock.patch.object("},{"line_number":89,"context_line":"                db, \u0027instance_extra_get_by_instance_uuid\u0027,"},{"line_number":90,"context_line":"                return_value\u003ddb_numa_topology):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_8044141b","line":87,"in_reply_to":"ba8a016a_078b65c4","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_memory_with_overhead(self, mock_get):"},{"line_number":155,"context_line":"        overhead \u003d {\u0027memory_mb\u0027: 8,"},{"line_number":156,"context_line":"                    \u0027disk_gb\u0027: 0}"},{"line_number":157,"context_line":"        limits \u003d {\u0027memory_mb\u0027: 2048}"},{"line_number":158,"context_line":"        self._claim(memory_mb\u003d2040, limits\u003dlimits,"},{"line_number":159,"context_line":"                    overhead\u003doverhead)"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_e78d01d4","line":156,"updated":"2015-11-24 10:51:22.000000000","message":"Not needed?","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":153,"context_line":""},{"line_number":154,"context_line":"    def test_memory_with_overhead(self, mock_get):"},{"line_number":155,"context_line":"        overhead \u003d {\u0027memory_mb\u0027: 8,"},{"line_number":156,"context_line":"                    \u0027disk_gb\u0027: 0}"},{"line_number":157,"context_line":"        limits \u003d {\u0027memory_mb\u0027: 2048}"},{"line_number":158,"context_line":"        self._claim(memory_mb\u003d2040, limits\u003dlimits,"},{"line_number":159,"context_line":"                    overhead\u003doverhead)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_204e803b","line":156,"in_reply_to":"ba8a016a_e78d01d4","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_memory_with_overhead_insufficient(self, mock_get):"},{"line_number":162,"context_line":"        overhead \u003d {\u0027memory_mb\u0027: 9,"},{"line_number":163,"context_line":"                    \u0027disk_gb\u0027: 0}"},{"line_number":164,"context_line":"        limits \u003d {\u0027memory_mb\u0027: 2048}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.assertRaises(exception.ComputeResourcesUnavailable,"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_a7c299e7","line":163,"updated":"2015-11-24 10:51:22.000000000","message":"Not needed?","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":160,"context_line":""},{"line_number":161,"context_line":"    def test_memory_with_overhead_insufficient(self, mock_get):"},{"line_number":162,"context_line":"        overhead \u003d {\u0027memory_mb\u0027: 9,"},{"line_number":163,"context_line":"                    \u0027disk_gb\u0027: 0}"},{"line_number":164,"context_line":"        limits \u003d {\u0027memory_mb\u0027: 2048}"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"        self.assertRaises(exception.ComputeResourcesUnavailable,"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_e05398e0","line":163,"in_reply_to":"ba8a016a_a7c299e7","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":7461,"name":"Paul Murray","email":"pmurray@hpe.com","username":"ptm"},"change_message_id":"2ddad0bd3e35fd9c8cd0c0e5ae6c98e89bf4355d","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.assertRaises(exception.ComputeResourcesUnavailable,"},{"line_number":185,"context_line":"                          self._claim, limits\u003dlimits, overhead\u003doverhead,"},{"line_number":186,"context_line":"                          root_gb\u003d99, ephemeral_gb\u003d0)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_memory_oversubscription(self, mock_get):"},{"line_number":189,"context_line":"        self._claim(memory_mb\u003d4096)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_75ba5a0c","line":186,"updated":"2015-12-04 16:25:29.000000000","message":"Could do with an overhead that does not have a disk_gb item - to test what happens if its not given.","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":183,"context_line":""},{"line_number":184,"context_line":"        self.assertRaises(exception.ComputeResourcesUnavailable,"},{"line_number":185,"context_line":"                          self._claim, limits\u003dlimits, overhead\u003doverhead,"},{"line_number":186,"context_line":"                          root_gb\u003d99, ephemeral_gb\u003d0)"},{"line_number":187,"context_line":""},{"line_number":188,"context_line":"    def test_memory_oversubscription(self, mock_get):"},{"line_number":189,"context_line":"        self._claim(memory_mb\u003d4096)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_2023e057","line":186,"in_reply_to":"7a740942_75ba5a0c","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        instance_type \u003d self._fake_instance_type(**kwargs)"},{"line_number":411,"context_line":"        if overhead is None:"},{"line_number":412,"context_line":"            overhead \u003d {\u0027memory_mb\u0027: 0,"},{"line_number":413,"context_line":"                        \u0027disk_gb\u0027: 0}"},{"line_number":414,"context_line":"        with mock.patch("},{"line_number":415,"context_line":"                \u0027nova.virt.hardware.numa_get_constraints\u0027,"},{"line_number":416,"context_line":"                return_value\u003dnuma_constraint):"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_67b83176","line":413,"updated":"2015-11-24 10:51:22.000000000","message":"Not needed?","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":410,"context_line":"        instance_type \u003d self._fake_instance_type(**kwargs)"},{"line_number":411,"context_line":"        if overhead is None:"},{"line_number":412,"context_line":"            overhead \u003d {\u0027memory_mb\u0027: 0,"},{"line_number":413,"context_line":"                        \u0027disk_gb\u0027: 0}"},{"line_number":414,"context_line":"        with mock.patch("},{"line_number":415,"context_line":"                \u0027nova.virt.hardware.numa_get_constraints\u0027,"},{"line_number":416,"context_line":"                return_value\u003dnuma_constraint):"}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_c03e9c8b","line":413,"in_reply_to":"ba8a016a_67b83176","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"}],"nova/virt/driver.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        :returns: Dict of estimated overhead values."},{"line_number":243,"context_line":"        \"\"\""},{"line_number":244,"context_line":"        return {\u0027memory_mb\u0027: 0,"},{"line_number":245,"context_line":"                \u0027disk_gb\u0027: 0}"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"    def list_instances(self):"},{"line_number":248,"context_line":"        \"\"\"Return the names of all the instances known to the virtualization"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_4a06541d","line":245,"updated":"2015-11-24 10:51:22.000000000","message":"If the other instances of \u0027disk_gb\u0027: 0 are removed, I think this one should be kept to make it clear what the expectations of the function are.","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"a6971498d973bddce2f68b61990ac3dbd57b0ef1","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                        + OVERHEAD_BASE)"},{"line_number":177,"context_line":"        overhead \u003d math.ceil(overhead)"},{"line_number":178,"context_line":"        return {\u0027memory_mb\u0027: overhead,"},{"line_number":179,"context_line":"                \u0027disk_gb\u0027: 0}"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def list_instances(self):"},{"line_number":182,"context_line":"        \"\"\"List VM instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_ca5fa40d","line":179,"updated":"2015-11-24 10:51:22.000000000","message":"Not needed?","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"fb4d5abb823931cbd3950df98433849d5c6e0a80","unresolved":false,"context_lines":[{"line_number":176,"context_line":"                        + OVERHEAD_BASE)"},{"line_number":177,"context_line":"        overhead \u003d math.ceil(overhead)"},{"line_number":178,"context_line":"        return {\u0027memory_mb\u0027: overhead,"},{"line_number":179,"context_line":"                \u0027disk_gb\u0027: 0}"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"    def list_instances(self):"},{"line_number":182,"context_line":"        \"\"\"List VM instances.\"\"\""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_80b734f4","line":179,"in_reply_to":"ba8a016a_ca5fa40d","updated":"2015-12-08 08:13:20.000000000","message":"Done","commit_id":"b012f9dbe7406cf77c81e77272e7e3cb967d30a5"}]}