)]}'
{"nova/tests/unit/virt/test_images.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47f04d43b5689e21ed8d519e1d0ff3daf73c01c5","unresolved":false,"context_lines":[{"line_number":37,"context_line":"    @mock.patch.object(images, \u0027LOG\u0027)"},{"line_number":38,"context_line":"    @mock.patch.object(images, \u0027resource\u0027)"},{"line_number":39,"context_line":"    def test_qemu_resources_noop(self, mock_resource, mock_LOG):"},{"line_number":40,"context_line":"        mock_resource.__nonzero__.return_value \u003d False"},{"line_number":41,"context_line":"        images._qemu_resources()"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"        self.assertFalse(mock_resource.setrlimit.called)"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_2cdec311","line":40,"updated":"2015-10-14 13:55:35.000000000","message":"This is weird.  Can\u0027t we just do:\n\n@mock.patch.object(images, \u0027resource\u0027, None)?","commit_id":"c36dbc9e33e97940ca139ceea541a7cba41448c7"}],"nova/virt/images.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"aabbc84cf9a09ce6a3369edbe8490296ba53d023","unresolved":false,"context_lines":[{"line_number":22,"context_line":"import os"},{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"if sys.platform !\u003d \u0027win32\u0027:"},{"line_number":26,"context_line":"    import resource"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_2d3d812b","line":25,"updated":"2015-10-13 21:27:13.000000000","message":"I\u0027d rather handle the ImportError and set a sentinel, or import resource where it\u0027s used (since whatever is going to use that is going to require it and I\u0027m assuming hyper-v doesn\u0027t use qemu_img_info).","commit_id":"7f40552c8bc36894e4288dbf3b636be179ca4718"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"87b30ae5702292ab0aed279741736088ead79d81","unresolved":false,"context_lines":[{"line_number":23,"context_line":"import sys"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"resource \u003d None"},{"line_number":26,"context_line":"if resource in sys.modules:"},{"line_number":27,"context_line":"    import resource"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"from oslo_config import cfg"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_cd4e4dc1","line":26,"updated":"2015-10-13 21:33:20.000000000","message":"I\u0027d prefer:\n\ntry:\n    import resource\nexcept ImportError:\n    resource \u003d None","commit_id":"2f2e3216282d2094f41526ece4a2ea22b2d4069c"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"6d14ebfc10dbc22e5e85ff3a6f209c2bf7b10990","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"def _qemu_resources():"},{"line_number":49,"context_line":"    import resource"},{"line_number":50,"context_line":"    resource.setrlimit(resource.RLIMIT_CPU, (2, 2))"},{"line_number":51,"context_line":"    resource.setrlimit(resource.RLIMIT_AS, (1 * units.Gi, 1 * units.Gi))"},{"line_number":52,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5a2ca52d_cd064d20","line":49,"updated":"2015-10-13 21:41:40.000000000","message":"You should probably add a NOTE here on why this is imported in a method and not at the module level.\n\nI\u0027d also be OK with what you had as long as you did the suggested ImportError handling to set it to None.","commit_id":"7b1fd83a7f10796cebc89c6e2b67fc0d7ca112c8"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"47f04d43b5689e21ed8d519e1d0ff3daf73c01c5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"        resource.setrlimit(resource.RLIMIT_CPU, (2, 2))"},{"line_number":58,"context_line":"        resource.setrlimit(resource.RLIMIT_AS, (1 * units.Gi, 1 * units.Gi))"},{"line_number":59,"context_line":"    else:"},{"line_number":60,"context_line":"        LOG.warning(_LW(\"The \u0027resource\u0027 module could not be imported.\"))"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"def qemu_img_info(path):"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_ecdd2b43","line":60,"updated":"2015-10-14 13:55:35.000000000","message":"I might add to this:\n\n\"The \u0027resource\u0027 module could not be imported so we can not set limits for QEMU.\"","commit_id":"c36dbc9e33e97940ca139ceea541a7cba41448c7"}]}