)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"b4f6d9db64f98c9b6c5ccdd483e75847ba015c33","unresolved":false,"context_lines":[{"line_number":563,"context_line":"        block_device_info \u003d self._get_instance_volume_block_device_info("},{"line_number":564,"context_line":"            context, instance_id)"},{"line_number":565,"context_line":"        self.driver.destroy(instance, network_info, block_device_info, cleanup)"},{"line_number":566,"context_line":"        volume_api \u003d volume.API()"},{"line_number":567,"context_line":"        for bdm in bdms:"},{"line_number":568,"context_line":"            try:"},{"line_number":569,"context_line":"                # NOTE(vish): actual driver detach done in driver.destroy, so"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8vg%3D","line":566,"updated":"2011-12-15 00:51:38.000000000","message":"Since this is used in several of the methods, I wonder if we should follow the example of network_api and add\n\nself.volume_api \u003d volume.API()\n\nto the __init__.","commit_id":"bd23b63fdc129ad2caf31aefc04d97a88aa2950e"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b0fa9f83e4fd5213a43fade22f512f2425fc384f","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"        LOG.audit(_(\"Detach volume %(volume_id)s from mountpoint %(mp)s\""},{"line_number":1469,"context_line":"                \" on instance %(instance_name)s\") % locals(), context\u003dcontext)"},{"line_number":1470,"context_line":""},{"line_number":1471,"context_line":"        if instance_name not in self.driver.list_instances():"},{"line_number":1472,"context_line":"            LOG.warn(_(\"Detaching volume from unknown instance %s\"),"},{"line_number":1473,"context_line":"                     instance_name, context\u003dcontext)"},{"line_number":1474,"context_line":"        self.driver.detach_volume(utils.loads(bdm[\u0027connection_info\u0027]),"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F8ug%3D","line":1471,"updated":"2011-12-15 01:42:57.000000000","message":"I see this was just moved, but it is kind of silly and it\u0027s subject to a race condition anyway.  This won\u0027t hold up this patch, though.","commit_id":"31a7924ecfae0b9c9fea0edc344f0e3ca2fe78a5"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b0fa9f83e4fd5213a43fade22f512f2425fc384f","unresolved":false,"context_lines":[{"line_number":1473,"context_line":"                     instance_name, context\u003dcontext)"},{"line_number":1474,"context_line":"        self.driver.detach_volume(utils.loads(bdm[\u0027connection_info\u0027]),"},{"line_number":1475,"context_line":"                                  instance_name,"},{"line_number":1476,"context_line":"                                  mp)"},{"line_number":1477,"context_line":""},{"line_number":1478,"context_line":"    @exception.wrap_exception(notifier\u003dnotifier, publisher_id\u003dpublisher_id())"},{"line_number":1479,"context_line":"    @checks_instance_lock"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F8uY%3D","line":1476,"updated":"2011-12-15 01:42:57.000000000","message":"Again, I know this wasn\u0027t your change here, but yuck that virt driver wants instance[\u0027name\u0027]\u0027 for attach_volume() and detach_volume().  Screws up consistent logging in the virt layers where we would want to log by uuid at some point.  I\u0027ll ignore this for now, but this makes me want to do another re-factor of that part right afterwards. :)   (Longer term, we have a problem in that we use instance[\u0027name\u0027] for the association between nova instance \u003c-\u003e libvirt/xenserver and this breaks things when you change instance_name_template between restarts)","commit_id":"31a7924ecfae0b9c9fea0edc344f0e3ca2fe78a5"}]}