)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"88bd83d31e77759cccfab106284d624c56607f56","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"            instances \u003d self.db.instance_get_all_by_host(context, self.host)"},{"line_number":2025,"context_line":"            for instance in instances:"},{"line_number":2026,"context_line":"                present \u003d instance.name in present_name_labels"},{"line_number":2027,"context_line":"                erroneously_running \u003d instance.deleted and present"},{"line_number":2028,"context_line":"                old_enough \u003d (not instance.deleted_at or utils.is_older_than("},{"line_number":2029,"context_line":"                        instance.deleted_at,"},{"line_number":2030,"context_line":"                        FLAGS.running_deleted_instance_timeout))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8t0%3D","line":2027,"updated":"2011-12-15 02:34:10.000000000","message":"I\u0027ve seen a lot of use of the \u0027dot\u0027 method vs pretending instance is a dictionary lately.  Do you know of a specific reason for it?  In most cases I\u0027ve been correcting this to be instance[\u0027deleted\u0027] to prepare for the future when the DB layer returns dictionaries vs the sqlalchemy models.... but I want to figure out if I\u0027m missing something or am out of line. ;)","commit_id":"ef904355c44355a050814f3b293b908958c16a45"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"30586d8d61dc346f38fa35b614cbc5490fde209b","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"            instances \u003d self.db.instance_get_all_by_host(context, self.host)"},{"line_number":2025,"context_line":"            for instance in instances:"},{"line_number":2026,"context_line":"                present \u003d instance.name in present_name_labels"},{"line_number":2027,"context_line":"                erroneously_running \u003d instance.deleted and present"},{"line_number":2028,"context_line":"                old_enough \u003d (not instance.deleted_at or utils.is_older_than("},{"line_number":2029,"context_line":"                        instance.deleted_at,"},{"line_number":2030,"context_line":"                        FLAGS.running_deleted_instance_timeout))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8pw%3D","line":2027,"in_reply_to":"AAAAC3%2F%2F8qw%3D","updated":"2011-12-15 07:02:04.000000000","message":"I\u0027ll throw something out to the list.","commit_id":"ef904355c44355a050814f3b293b908958c16a45"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"044a95533a951ea8d6885395451f7f326b950941","unresolved":false,"context_lines":[{"line_number":2024,"context_line":"            instances \u003d self.db.instance_get_all_by_host(context, self.host)"},{"line_number":2025,"context_line":"            for instance in instances:"},{"line_number":2026,"context_line":"                present \u003d instance.name in present_name_labels"},{"line_number":2027,"context_line":"                erroneously_running \u003d instance.deleted and present"},{"line_number":2028,"context_line":"                old_enough \u003d (not instance.deleted_at or utils.is_older_than("},{"line_number":2029,"context_line":"                        instance.deleted_at,"},{"line_number":2030,"context_line":"                        FLAGS.running_deleted_instance_timeout))"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8qw%3D","line":2027,"in_reply_to":"AAAAC3%2F%2F8t0%3D","updated":"2011-12-15 05:16:07.000000000","message":"Good point on making progress towards just returning dictionaries.\n\nThis might be a good topic for the mailing list (if it hasn\u0027t been discussed already?), for example, should we, as a concerted effort, be rejecting any patches which perpetuate the dot-notation.\n\nI, myself, have just been using whatever the code around it is using, or failing that, just whatever I feel like :-). A rule-to-follow here would be a nice addition.","commit_id":"ef904355c44355a050814f3b293b908958c16a45"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"d5888ecaeaa0e95b112e32e63ac43b6d750bd761","unresolved":false,"context_lines":[{"line_number":88,"context_line":"flags.DEFINE_integer(\"running_deleted_instance_timeout\", 0,"},{"line_number":89,"context_line":"                     \"Number of seconds after being deleted when a\""},{"line_number":90,"context_line":"                     \" still-running instance should be considered\""},{"line_number":91,"context_line":"                     \" eligble for cleanup.\")"},{"line_number":92,"context_line":"flags.DEFINE_integer(\"running_deleted_instance_poll_interval\", 30,"},{"line_number":93,"context_line":"                     \"Number of periodic scheduler ticks to wait between\""},{"line_number":94,"context_line":"                     \" runs of the cleanup task.\")"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAC3%2F%2F7NQ%3D","line":91,"updated":"2011-12-21 23:03:10.000000000","message":"Typo, eligible","commit_id":"019940f1aecbfbba27943871dd6bb091e6b2a82b"}]}