)]}'
{"nova/objects/service.py":[{"author":{"_account_id":1865,"name":"Andrea Rosa","email":"andrea.rosa@gmail.com","username":"andrea-rosa-m"},"change_message_id":"253a716576dd44272b958c53fd27083bdfb962b4","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    def get_minimum_version(cls, context, binary, use_slave\u003dFalse):"},{"line_number":286,"context_line":"        if not binary.startswith(\u0027nova-\u0027):"},{"line_number":287,"context_line":"            LOG.warning(_LW(\u0027get_minimum_version called with likely-incorrect \u0027"},{"line_number":288,"context_line":"                            \u0027binary `%s\\\u0027\u0027), binary)"},{"line_number":289,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027get_minimum_version\u0027,"},{"line_number":290,"context_line":"                                              reason\u003d\u0027Invalid binary prefix\u0027)"},{"line_number":291,"context_line":"        version \u003d db.service_get_minimum_version(context, binary,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_09e894b3","line":288,"updated":"2015-10-14 15:13:54.000000000","message":"if we raise an exception is it correct to have a LOG.warning?","commit_id":"a337a5f1d3c138b4e70d3b273838100f73623eae"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"8d4c13cb125bb6adaf07c2b2a80f41476ab43653","unresolved":false,"context_lines":[{"line_number":285,"context_line":"    def get_minimum_version(cls, context, binary, use_slave\u003dFalse):"},{"line_number":286,"context_line":"        if not binary.startswith(\u0027nova-\u0027):"},{"line_number":287,"context_line":"            LOG.warning(_LW(\u0027get_minimum_version called with likely-incorrect \u0027"},{"line_number":288,"context_line":"                            \u0027binary `%s\\\u0027\u0027), binary)"},{"line_number":289,"context_line":"            raise exception.ObjectActionError(action\u003d\u0027get_minimum_version\u0027,"},{"line_number":290,"context_line":"                                              reason\u003d\u0027Invalid binary prefix\u0027)"},{"line_number":291,"context_line":"        version \u003d db.service_get_minimum_version(context, binary,"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a2ca52d_50962df1","line":288,"in_reply_to":"5a2ca52d_09e894b3","updated":"2015-10-14 16:56:13.000000000","message":"Yeah, the exception won\u0027t show  up in the conductor logs, but the log will. It\u0027s warning because it doesn\u0027t necessarily mean that something is wrong, but we\u0027re signaling to the other side that we\u0027re not going to do the lookup. So, we could log error here, but I think warning is appropriate.","commit_id":"a337a5f1d3c138b4e70d3b273838100f73623eae"}]}