)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"80a56d0631d5f9675a86a56998546640480007e1","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-15 12:21:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: add vnc section into nova configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ida31953a7df2b473b7651fa9491391d21a862588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a2ca52d_1d45fc6e","line":8,"updated":"2015-10-15 15:01:16.000000000","message":"There is bug 1506356 about this issue, would you please add it to the commit messsage?","commit_id":"46ea1f7c866671594b000bdb6345242226b8cc77"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3d38a75b16bbfdcb9a0a9f1d843e1c76153d7f12","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-15 12:21:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: add vnc section into nova configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ida31953a7df2b473b7651fa9491391d21a862588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5a2ca52d_5df7cf58","line":8,"in_reply_to":"5a2ca52d_1d45fc6e","updated":"2015-10-16 08:42:37.000000000","message":"IIUC, this commit intents to remove the deprecation, please leave a note here.","commit_id":"46ea1f7c866671594b000bdb6345242226b8cc77"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fc355bdcf068796ad176d3f610e26004950de851","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2015-10-15 12:21:41 +0800"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"WIP: add vnc section into nova configuration"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: Ida31953a7df2b473b7651fa9491391d21a862588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_23ebc679","line":8,"in_reply_to":"5a2ca52d_5df7cf58","updated":"2015-10-21 19:08:55.000000000","message":"yes, I will update commit message accordingly","commit_id":"46ea1f7c866671594b000bdb6345242226b8cc77"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"66ecd173c8c2bd0ddc5353d8470715a2d09e853b","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Put deprecated vnc items into its own group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is depcrated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a29b11f_5496b63f","line":9,"updated":"2015-10-21 20:35:12.000000000","message":"nit: s/depcrated/deprecated/","commit_id":"f579ed27addb390a98ec74851439a2e72d7a6f59"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a2393bc0c5c02a9bd556921f19b967bfe8aed1fc","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Put deprecated vnc items into its own group"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is depcrated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3a29b11f_f848fecd","line":9,"in_reply_to":"3a29b11f_5496b63f","updated":"2015-10-22 12:00:16.000000000","message":"Done","commit_id":"f579ed27addb390a98ec74851439a2e72d7a6f59"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"cc130cc6591813bed6a47d7cc3000ab41d50e42c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is deprecated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"this depends on https://review.openstack.org/#/c/235396/"},{"line_number":14,"context_line":"because of bug 1506356."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a29b11f_3e0e54e5","line":11,"updated":"2015-10-22 15:43:26.000000000","message":"Commit 380c4d75 got merged in the Liberty cycle. It introduced the deprecation on the VNC config options and did put it already in the [vnc] section. Your change removes the deprecation notice. The commit message doesn\u0027t reflect this right now.\n\nIIUC, the \"standard deprecation policy\" [1] encourages us to keep this deprecation notice until the Nxxx release is open. At least the following statements makes me believe this:\n\n    \"At the very minimum the feature (or API, or \n    configuration option) should be marked deprecated \n    (and still be supported) in the next stable release\n    branch\"\n\n[1] http://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html#requirements","commit_id":"2576ea019fc7007f1f614ec8813c912bd18d0d69"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"59fd6a511e1c28345a482ad1b8a918fcbe03ecf5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is deprecated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"this depends on https://review.openstack.org/#/c/235396/"},{"line_number":14,"context_line":"because of bug 1506356."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a29b11f_93c2fa51","line":11,"in_reply_to":"3a29b11f_3e0e54e5","updated":"2015-10-22 18:01:36.000000000","message":"This change only will remove some comments \nthe code already use following \n\naccess_url \u003d \u0027%s?token\u003d%s\u0027 % (CONF.vnc.novncproxy_base_url, token)\n\nif we think it has problem , then we should vote -1 on\nhttps://review.openstack.org/#/c/235396/\nbecause it already break the rule?","commit_id":"2576ea019fc7007f1f614ec8813c912bd18d0d69"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"1d94fe034406aba70be14931be28dff080a144d8","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is deprecated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"this depends on https://review.openstack.org/#/c/235396/"},{"line_number":14,"context_line":"because of bug 1506356."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a29b11f_f7d69a26","line":11,"in_reply_to":"3a29b11f_93c2fa51","updated":"2015-10-23 13:52:05.000000000","message":"Review 235396 fixes the issue that the sample conf file shows the VNC config options in the wrong section. The breaking of existing config files was introduced with commit 3b38ae48421 . Not sure if this should be fixed afterwards. I still have to figure out if oslo.config provides a transition path for the cases where an existing config file shouldn\u0027t break after a config option got deprecated.","commit_id":"2576ea019fc7007f1f614ec8813c912bd18d0d69"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"c4396f85bb91ca3b3ccd1be2b9705d8a38f5d17c","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vnc related configurations in vnc/__init__.py is deprecated"},{"line_number":10,"context_line":"at commit 380c4d75 in L release. In M release, we are"},{"line_number":11,"context_line":"going to put into under [vnc]."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"this depends on https://review.openstack.org/#/c/235396/"},{"line_number":14,"context_line":"because of bug 1506356."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a29b11f_af220200","line":11,"in_reply_to":"3a29b11f_f7d69a26","updated":"2015-10-23 19:34:43.000000000","message":"maybe we can ask in the ML ?I think some oslo guru might have suggestions to us?","commit_id":"2576ea019fc7007f1f614ec8813c912bd18d0d69"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"cc130cc6591813bed6a47d7cc3000ab41d50e42c","unresolved":false,"context_lines":[{"line_number":13,"context_line":"this depends on https://review.openstack.org/#/c/235396/"},{"line_number":14,"context_line":"because of bug 1506356."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: Ida31953a7df2b473b7651fa9491391d21a862588"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"3a29b11f_9e1e886e","line":16,"updated":"2015-10-22 15:43:26.000000000","message":"Please leave a comment how the document impact looks like. Is there a specific guide which should be updated? Should it be mentioned in the release notes?","commit_id":"2576ea019fc7007f1f614ec8813c912bd18d0d69"}],"etc/nova/nova-config-generator.conf":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"66ecd173c8c2bd0ddc5353d8470715a2d09e853b","unresolved":false,"context_lines":[{"line_number":20,"context_line":"namespace \u003d oslo.db"},{"line_number":21,"context_line":"namespace \u003d oslo.middleware"},{"line_number":22,"context_line":"namespace \u003d oslo.concurrency"},{"line_number":23,"context_line":"namespace \u003d keystonemiddleware.auth_token"}],"source_content_type":"text/plain","patch_set":7,"id":"3a29b11f_d47ba626","line":23,"updated":"2015-10-21 20:35:12.000000000","message":"unrelated change","commit_id":"f579ed27addb390a98ec74851439a2e72d7a6f59"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"a2393bc0c5c02a9bd556921f19b967bfe8aed1fc","unresolved":false,"context_lines":[{"line_number":20,"context_line":"namespace \u003d oslo.db"},{"line_number":21,"context_line":"namespace \u003d oslo.middleware"},{"line_number":22,"context_line":"namespace \u003d oslo.concurrency"},{"line_number":23,"context_line":"namespace \u003d keystonemiddleware.auth_token"}],"source_content_type":"text/plain","patch_set":7,"id":"3a29b11f_387bd6c2","line":23,"in_reply_to":"3a29b11f_d47ba626","updated":"2015-10-22 12:00:16.000000000","message":"Done","commit_id":"f579ed27addb390a98ec74851439a2e72d7a6f59"}],"nova/opts.py":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"3d38a75b16bbfdcb9a0a9f1d843e1c76153d7f12","unresolved":false,"context_lines":[{"line_number":135,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":136,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":137,"context_line":"         )),"},{"line_number":138,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":139,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":140,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"},{"line_number":141,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"5a2ca52d_7d288be2","line":138,"updated":"2015-10-16 08:42:37.000000000","message":"This issue is done view review https://review.openstack.org/#/c/235396/ and doesn\u0027t correlate with your intention to remove the deprecation. IOW, please remove that change in your review.","commit_id":"46ea1f7c866671594b000bdb6345242226b8cc77"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"fc355bdcf068796ad176d3f610e26004950de851","unresolved":false,"context_lines":[{"line_number":135,"context_line":"             [nova.console.rpcapi.rpcapi_cap_opt],"},{"line_number":136,"context_line":"             [nova.consoleauth.rpcapi.rpcapi_cap_opt],"},{"line_number":137,"context_line":"         )),"},{"line_number":138,"context_line":"        (\u0027vnc\u0027, nova.vnc.vnc_opts),"},{"line_number":139,"context_line":"        (\u0027workarounds\u0027, nova.utils.workarounds_opts),"},{"line_number":140,"context_line":"        (\u0027zookeeper\u0027, nova.servicegroup.drivers.zk.zk_driver_opts)"},{"line_number":141,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_03cfaa29","line":138,"in_reply_to":"5a2ca52d_7d288be2","updated":"2015-10-21 19:08:55.000000000","message":"ok, I can do that","commit_id":"46ea1f7c866671594b000bdb6345242226b8cc77"}]}