)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4190,"name":"lifeless","email":"robertc@robertcollins.net","username":"lifeless"},"change_message_id":"c426417e40a8f72f57f52da536b597ff3f85c05e","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Dan Smith \u003cdanms@us.ibm.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2013-03-04 19:18:08 -0500"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix uses of instance[\u0027instance_type\u0027] in xenapi driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Note that this includes a fix to tests/db/fakes.py to make the fake"},{"line_number":10,"context_line":"instance_type structures look like the database models."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F%2BD8%3D","line":7,"updated":"2013-03-05 00:49:49.000000000","message":"Missing full stop. Also fix them how?","commit_id":"8236758350af226f8312a93faba109a1e1c3d605"}],"nova/tests/test_xenapi.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"34deae17212e6776f12a855e8483d6a75a66a547","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    return decorated_function"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"def create_instance_with_system_metadata(context, instance_values):"},{"line_number":180,"context_line":"    instance_type \u003d db.instance_type_get(context,"},{"line_number":181,"context_line":"                                         instance_values[\u0027instance_type_id\u0027])"},{"line_number":182,"context_line":"    sys_meta \u003d instance_types.save_instance_type_info({},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F6OI%3D","line":179,"updated":"2013-03-06 21:11:20.000000000","message":"I think this should move out to a utility/fakes module since every driver does this same thing, with maybe minor differences.  But not worth holding up a bug fix at this point.","commit_id":"efb47395a03260393ea3873d9d753847faa59e81"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"6714a284b39e462b5e18ffeab16923103412dd3a","unresolved":false,"context_lines":[{"line_number":176,"context_line":"    return decorated_function"},{"line_number":177,"context_line":""},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"def create_instance_with_system_metadata(context, instance_values):"},{"line_number":180,"context_line":"    instance_type \u003d db.instance_type_get(context,"},{"line_number":181,"context_line":"                                         instance_values[\u0027instance_type_id\u0027])"},{"line_number":182,"context_line":"    sys_meta \u003d instance_types.save_instance_type_info({},"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F6NY%3D","line":179,"in_reply_to":"AAAAN3%2F%2F6OI%3D","updated":"2013-03-06 21:24:11.000000000","message":"Yeah, although it varies on whether the system_metadata is expected to be in list or dict format (i.e. if it\u0027s going to go through the db layer or not). But regardless, even if there are two utility functions, that\u0027s a valid point :)","commit_id":"efb47395a03260393ea3873d9d753847faa59e81"}]}