)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"18a074ed57ef7b652cd4083b9c666ba42e67f319","unresolved":false,"context_lines":[{"line_number":13,"context_line":"after this patch, user should use"},{"line_number":14,"context_line":"nova flavor-key m1.tiny set quota:cpu_shares\u003d1000 to set params."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"DocImpact"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I30e550d21f00eb949ee2f3f8fb4d952c10bf8000"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAN3%2F%2F2i8%3D","line":16,"updated":"2013-03-08 20:12:48.000000000","message":"Mention the bug fixed in the commit message somewhere, please…","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"}],"nova/virt/libvirt/designer.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"18a074ed57ef7b652cd4083b9c666ba42e67f319","unresolved":false,"context_lines":[{"line_number":102,"context_line":""},{"line_number":103,"context_line":"def set_vif_bandwidth_config(conf, extra_specs):"},{"line_number":104,"context_line":"    \"\"\"Config vif inbound/outbound bandwidth limit. params should be"},{"line_number":105,"context_line":"       set in the format quota:vif_inbound_average\u003d10240000.\"\"\""},{"line_number":106,"context_line":""},{"line_number":107,"context_line":"    bandwidth_items \u003d [\u0027vif_inbound_average\u0027, \u0027vif_inbound_peak\u0027,"},{"line_number":108,"context_line":"        \u0027vif_inbound_burst\u0027, \u0027vif_outbound_average\u0027, \u0027vif_outbound_peak\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F2ic%3D","line":105,"updated":"2013-03-08 20:12:48.000000000","message":"1) I\u0027m not sure what you\u0027re referring to by \"params\" here; do you mean parameters set in extra_specs?\n\n2) The second line should be indented 4 spaces, not 7, so that it lines up with the left side of the triple-quote.\n\n3) The closing triple-quote should be on a line by itself…","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"18a074ed57ef7b652cd4083b9c666ba42e67f319","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \u0027vif_inbound_burst\u0027, \u0027vif_outbound_average\u0027, \u0027vif_outbound_peak\u0027,"},{"line_number":109,"context_line":"        \u0027vif_outbound_burst\u0027]"},{"line_number":110,"context_line":"    for key, value in extra_specs.iteritems():"},{"line_number":111,"context_line":"        scope \u003d key.split(\u0027:\u0027)"},{"line_number":112,"context_line":"        if len(scope) \u003e 1 and scope[0] \u003d\u003d \u0027quota\u0027:"},{"line_number":113,"context_line":"            if scope[1] in bandwidth_items:"},{"line_number":114,"context_line":"                setattr(conf, scope[1], value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F2iM%3D","line":111,"updated":"2013-03-08 20:12:48.000000000","message":"As a suggestion, you could investigate the use of partition() for this, e.g.:\n\n    scope, _sep, item \u003d key.split(\u0027:\u0027)\n    if scope \u003d\u003d \u0027quota\u0027 and item in bandwidth_items:\n        setattr(conf, item, value)","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"},{"author":{"_account_id":1313,"name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"a4a462fc0f8cf0aec7a84b555584ef28cd231e99","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \u0027vif_inbound_burst\u0027, \u0027vif_outbound_average\u0027, \u0027vif_outbound_peak\u0027,"},{"line_number":109,"context_line":"        \u0027vif_outbound_burst\u0027]"},{"line_number":110,"context_line":"    for key, value in extra_specs.iteritems():"},{"line_number":111,"context_line":"        scope \u003d key.split(\u0027:\u0027)"},{"line_number":112,"context_line":"        if len(scope) \u003e 1 and scope[0] \u003d\u003d \u0027quota\u0027:"},{"line_number":113,"context_line":"            if scope[1] in bandwidth_items:"},{"line_number":114,"context_line":"                setattr(conf, scope[1], value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FzKc%3D","line":111,"in_reply_to":"AAAAN3%2F%2F2iM%3D","updated":"2013-03-12 05:11:55.000000000","message":"we can\u0027t assume the all  keys in extra_specs contains a \":\"\nfor example  \"arch\" that used by compute_capabilities_filter.","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3e96fd33ec95d468fac40b611ec70f39ed0da598","unresolved":false,"context_lines":[{"line_number":108,"context_line":"        \u0027vif_inbound_burst\u0027, \u0027vif_outbound_average\u0027, \u0027vif_outbound_peak\u0027,"},{"line_number":109,"context_line":"        \u0027vif_outbound_burst\u0027]"},{"line_number":110,"context_line":"    for key, value in extra_specs.iteritems():"},{"line_number":111,"context_line":"        scope \u003d key.split(\u0027:\u0027)"},{"line_number":112,"context_line":"        if len(scope) \u003e 1 and scope[0] \u003d\u003d \u0027quota\u0027:"},{"line_number":113,"context_line":"            if scope[1] in bandwidth_items:"},{"line_number":114,"context_line":"                setattr(conf, scope[1], value)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyfQ%3D","line":111,"in_reply_to":"AAAAN3%2F%2FzKc%3D","updated":"2013-03-12 15:38:59.000000000","message":"Doesn\u0027t matter for partition(); if the specified delimiter doesn\u0027t exist in the string, the return value of string.partition(\u0027:\u0027) will be the tuple (string, \u0027\u0027, \u0027\u0027).\n\n(And how did I typo to \"key.split(\u0027:\u0027)\"?)\n\nAnyway, it was just a suggestion, and a way to save you from having to do the length check below.","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"18a074ed57ef7b652cd4083b9c666ba42e67f319","unresolved":false,"context_lines":[{"line_number":113,"context_line":"            if scope[1] in bandwidth_items:"},{"line_number":114,"context_line":"                setattr(conf, scope[1], value)"},{"line_number":115,"context_line":"        else:"},{"line_number":116,"context_line":"            continue"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2F2iE%3D","line":116,"updated":"2013-03-08 20:12:48.000000000","message":"This else clause is unnecessary…","commit_id":"8e4e15dd284853709756819604ba8ff13b1de295"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"014c53e780085940946248616a000279d3039a45","unresolved":false,"context_lines":[{"line_number":103,"context_line":"def set_vif_bandwidth_config(conf, extra_specs):"},{"line_number":104,"context_line":"    \"\"\"Config vif inbound/outbound bandwidth limit. parameters are"},{"line_number":105,"context_line":"    set in instance_type_extra_specs table, key is in  the format"},{"line_number":106,"context_line":"    quota:vif_inbound_average.\"\"\""},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"    bandwidth_items \u003d [\u0027vif_inbound_average\u0027, \u0027vif_inbound_peak\u0027,"},{"line_number":109,"context_line":"        \u0027vif_inbound_burst\u0027, \u0027vif_outbound_average\u0027, \u0027vif_outbound_peak\u0027,"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2Fyes%3D","line":106,"updated":"2013-03-12 15:43:07.000000000","message":"The closing triple-quote should go on a line by itself, and I would prefer you capitalize the first word of the second sentence, i.e., this should look like:\n\n    \"\"\"Config vif inbound/outbound bandwidth limit.  Parameters are\n    set in instance_type_extra_specs table, key is in the format\n    quota:vif_inbound_average.\n    \"\"\"","commit_id":"3d3e40aca173ba8885e26c68ad32a0e15f99f934"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"1e46d1ffae3991e78ce62c776135ab99ee88acea","unresolved":false,"context_lines":[{"line_number":103,"context_line":"def set_vif_bandwidth_config(conf, extra_specs):"},{"line_number":104,"context_line":"    \"\"\"Config vif inbound/outbound bandwidth limit. parameters are"},{"line_number":105,"context_line":"    set in instance_type_extra_specs table, key is in  the format"},{"line_number":106,"context_line":"    quota:vif_inbound_average."},{"line_number":107,"context_line":"    \"\"\""},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    bandwidth_items \u003d [\u0027vif_inbound_average\u0027, \u0027vif_inbound_peak\u0027,"}],"source_content_type":"text/x-python","patch_set":8,"id":"AAAAN3%2F%2Fwk4%3D","line":106,"updated":"2013-03-13 15:57:43.000000000","message":"And we now reduce this to a femtonit: Please capitalize the second sentence.","commit_id":"cbd3c7aeb4b44d2fe15bc1ed376243cf0a3752b7"}],"nova/virt/libvirt/driver.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"014c53e780085940946248616a000279d3039a45","unresolved":false,"context_lines":[{"line_number":2141,"context_line":"                if scope[1] in quota_items:"},{"line_number":2142,"context_line":"                    setattr(guest, scope[1], value)"},{"line_number":2143,"context_line":"            else:"},{"line_number":2144,"context_line":"                continue"},{"line_number":2145,"context_line":""},{"line_number":2146,"context_line":"        guest.cpu \u003d self.get_guest_cpu_config()"},{"line_number":2147,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2Fyeo%3D","line":2144,"updated":"2013-03-12 15:43:07.000000000","message":"This whole \u0027else\u0027 clause is unnecessary.","commit_id":"3d3e40aca173ba8885e26c68ad32a0e15f99f934"}],"nova/virt/libvirt/imagebackend.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"014c53e780085940946248616a000279d3039a45","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                    if scope[1] in tune_items:"},{"line_number":126,"context_line":"                        setattr(info, scope[1], value)"},{"line_number":127,"context_line":"                else:"},{"line_number":128,"context_line":"                    continue"},{"line_number":129,"context_line":"        return info"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":"    def cache(self, fetch_func, filename, size\u003dNone, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAN3%2F%2Fyeg%3D","line":128,"updated":"2013-03-12 15:43:07.000000000","message":"This whole \u0027else\u0027 clause is unnecessary.","commit_id":"3d3e40aca173ba8885e26c68ad32a0e15f99f934"}]}