)]}'
{"nova/log.py":[{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"8ae4cddeec496f2c4d91a645a0028272cc308b67","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"FLAGS \u003d flags.FLAGS"},{"line_number":48,"context_line":"flags.DEFINE_string(\u0027logging_context_format_string\u0027,"},{"line_number":49,"context_line":"                    \u0027%(asctime)s %(server_name)s %(levelname)s %(name)s \u0027"},{"line_number":50,"context_line":"                    \u0027[%(request_id)s %(user_id)s \u0027"},{"line_number":51,"context_line":"                    \u0027%(project_id)s] %(message)s\u0027,"},{"line_number":52,"context_line":"                    \u0027format string to use for log messages with context\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F6WE%3D","line":49,"updated":"2011-12-27 20:14:48.000000000","message":"I\u0027d suggest \"service_name\" instead of server_name.","commit_id":"81d937ec525bbc2e1e6f61af644b80ff343ab344"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"8ae4cddeec496f2c4d91a645a0028272cc308b67","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"def _get_binary_name():"},{"line_number":129,"context_line":"    return os.path.basename(inspect.stack()[-1][1])"},{"line_number":130,"context_line":""},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"def _get_log_file_path(binary\u003dNone):"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F6WA%3D","line":129,"updated":"2011-12-27 20:14:48.000000000","message":"I know this isn\u0027t your code but since this isn\u0027t going to change can you modify this method to be something like:\n\n    _BINARY_NAME \u003d os.path.basename(inspect.stack()[-1][1])\n\nThat way explicit globals don\u0027t have to get involved at all.","commit_id":"81d937ec525bbc2e1e6f61af644b80ff343ab344"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"8ae4cddeec496f2c4d91a645a0028272cc308b67","unresolved":false,"context_lines":[{"line_number":168,"context_line":"        if context:"},{"line_number":169,"context_line":"            extra.update(_dictify_context(context))"},{"line_number":170,"context_line":"        global _binary_name"},{"line_number":171,"context_line":"        extra[\u0027server_name\u0027] \u003d _binary_name"},{"line_number":172,"context_line":"        extra.update({\"nova_version\": version.version_string_with_vcs()})"},{"line_number":173,"context_line":"        return logging.Logger._log(self, level, msg, args, exc_info, extra)"},{"line_number":174,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F6V8%3D","line":171,"updated":"2011-12-27 20:14:48.000000000","message":"To avoid the use of globals here can you make the modifications I suggested above for the \"_get_binary_name\" method?","commit_id":"81d937ec525bbc2e1e6f61af644b80ff343ab344"},{"author":{"_account_id":706,"name":"Brian Lamar","email":"brian.lamar@rackspace.com","username":"blamar"},"change_message_id":"8ae4cddeec496f2c4d91a645a0028272cc308b67","unresolved":false,"context_lines":[{"line_number":331,"context_line":"    \"\"\"Setup nova logging.\"\"\""},{"line_number":332,"context_line":"    if not isinstance(logging.root, NovaRootLogger):"},{"line_number":333,"context_line":"        global _binary_name"},{"line_number":334,"context_line":"        _binary_name \u003d _get_binary_name()"},{"line_number":335,"context_line":"        logging._acquireLock()"},{"line_number":336,"context_line":"        for handler in logging.root.handlers:"},{"line_number":337,"context_line":"            logging.root.removeHandler(handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F6V4%3D","line":334,"updated":"2011-12-27 20:14:48.000000000","message":"Also should be able to replace this with _BINARY_NAME.","commit_id":"81d937ec525bbc2e1e6f61af644b80ff343ab344"}]}