)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"67ac6b12a390ad056161c676321f46efd121d11a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"make all vnc configuration into [vnc] group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"UpgradeImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e34a0f98de125c8b8b145377835d95035e2b472"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_5911ea02","line":11,"updated":"2015-10-22 15:57:36.000000000","message":"Please leave more information which documentation has to be updated and how.","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4e91135b9253b6505dc7fe1a84c71adb54a729b5","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"make all vnc configuration into [vnc] group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"UpgradeImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e34a0f98de125c8b8b145377835d95035e2b472"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_7005d411","line":11,"in_reply_to":"3a29b11f_5911ea02","updated":"2015-10-22 17:51:39.000000000","message":"ok, will do it","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"67ac6b12a390ad056161c676321f46efd121d11a","unresolved":false,"context_lines":[{"line_number":9,"context_line":"make all vnc configuration into [vnc] group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"UpgradeImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e34a0f98de125c8b8b145377835d95035e2b472"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_790866da","line":12,"updated":"2015-10-22 15:57:36.000000000","message":"Please leave more information about how the impact will look like.","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4e91135b9253b6505dc7fe1a84c71adb54a729b5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"make all vnc configuration into [vnc] group."},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"DocImpact"},{"line_number":12,"context_line":"UpgradeImpact"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1e34a0f98de125c8b8b145377835d95035e2b472"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3a29b11f_5305420e","line":12,"in_reply_to":"3a29b11f_790866da","updated":"2015-10-22 17:51:39.000000000","message":"will do it","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"bd5fb4f27d12d7fe933e2abe66bdfd1fb8439e23","unresolved":false,"context_lines":[{"line_number":11,"context_line":"Change-Id: I1e34a0f98de125c8b8b145377835d95035e2b472"},{"line_number":12,"context_line":"Co-Authored-By: Stephen Finucane \u003cstephen.finucane@intel.com\u003e"},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":"UpgradeImpact"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"fa69d971_4772414b","line":14,"updated":"2016-01-07 14:04:15.000000000","message":"We are using \"reno\" [1] now for upgrade impact. This means a reno-file is necessary here [2]. That\u0027s new since you started with the first patch set.\n\n[1] http://docs.openstack.org/developer/reno/sphinxext.html#directive-release-notes\n[2] http://docs.openstack.org/developer/nova/code-review.html#what-is-reno","commit_id":"9e76f122516f7d759366012bfd9cad3a6ef6f4ff"}],"nova/vnc/xvp_proxy.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e97f79a12e6451596a4dc1d9876e0b919d824f51","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               default\u003d6081,"},{"line_number":42,"context_line":"               min\u003d1,"},{"line_number":43,"context_line":"               max\u003d65535,"},{"line_number":44,"context_line":"               help\u003d\u0027Port that the XCP VNC proxy should bind to\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027xvpvncproxy_host\u0027,"},{"line_number":46,"context_line":"               default\u003d\u00270.0.0.0\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Address that the XCP VNC proxy should bind to\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_026c6b9a","line":44,"updated":"2015-10-22 10:54:45.000000000","message":"missing deprecated_group\u003d\u0027DEFAULT\u0027","commit_id":"fbdabac4bb74253c58bbd4d6b08c2bc491b56e48"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4f4774b221fa5b289b1c8213fa34476c97d4643c","unresolved":false,"context_lines":[{"line_number":41,"context_line":"               default\u003d6081,"},{"line_number":42,"context_line":"               min\u003d1,"},{"line_number":43,"context_line":"               max\u003d65535,"},{"line_number":44,"context_line":"               help\u003d\u0027Port that the XCP VNC proxy should bind to\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027xvpvncproxy_host\u0027,"},{"line_number":46,"context_line":"               default\u003d\u00270.0.0.0\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Address that the XCP VNC proxy should bind to\u0027),"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_7e537717","line":44,"in_reply_to":"3a29b11f_026c6b9a","updated":"2015-10-22 12:05:14.000000000","message":"Done","commit_id":"fbdabac4bb74253c58bbd4d6b08c2bc491b56e48"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e97f79a12e6451596a4dc1d9876e0b919d824f51","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               min\u003d1,"},{"line_number":43,"context_line":"               max\u003d65535,"},{"line_number":44,"context_line":"               help\u003d\u0027Port that the XCP VNC proxy should bind to\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027xvpvncproxy_host\u0027,"},{"line_number":46,"context_line":"               default\u003d\u00270.0.0.0\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Address that the XCP VNC proxy should bind to\u0027),"},{"line_number":48,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_c208b3dc","line":45,"updated":"2015-10-22 10:54:45.000000000","message":"missing deprecated_group\u003d\u0027DEFAULT\u0027","commit_id":"fbdabac4bb74253c58bbd4d6b08c2bc491b56e48"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4f4774b221fa5b289b1c8213fa34476c97d4643c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"               min\u003d1,"},{"line_number":43,"context_line":"               max\u003d65535,"},{"line_number":44,"context_line":"               help\u003d\u0027Port that the XCP VNC proxy should bind to\u0027),"},{"line_number":45,"context_line":"    cfg.StrOpt(\u0027xvpvncproxy_host\u0027,"},{"line_number":46,"context_line":"               default\u003d\u00270.0.0.0\u0027,"},{"line_number":47,"context_line":"               help\u003d\u0027Address that the XCP VNC proxy should bind to\u0027),"},{"line_number":48,"context_line":"    ]"}],"source_content_type":"text/x-python","patch_set":4,"id":"3a29b11f_3e597f35","line":45,"in_reply_to":"3a29b11f_c208b3dc","updated":"2015-10-22 12:05:14.000000000","message":"Done","commit_id":"fbdabac4bb74253c58bbd4d6b08c2bc491b56e48"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"67ac6b12a390ad056161c676321f46efd121d11a","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_f9ea36da","line":53,"updated":"2015-10-22 15:57:36.000000000","message":"The module \"nova/opts.py\" has to be updated too. Otherwise the nova.conf.sample file will still have these config options in the [default] section:\n\n    def list_opts():\n        return [\n            (\u0027DEFAULT\u0027,\n             itertools.chain(\n                 nova.vnc.xvp_proxy.xvp_proxy_opts,","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4e91135b9253b6505dc7fe1a84c71adb54a729b5","unresolved":false,"context_lines":[{"line_number":50,"context_line":"    ]"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_b00fec35","line":53,"in_reply_to":"3a29b11f_f9ea36da","updated":"2015-10-22 17:51:39.000000000","message":"make sense to me , thanks","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"67ac6b12a390ad056161c676321f46efd121d11a","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"},{"line_number":57,"context_line":"    \"\"\"Class to use the xvp auth protocol to proxy instance vnc consoles.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_39e74ead","line":54,"updated":"2015-10-22 15:57:36.000000000","message":"That would break existing config files, right? The \"standard deprecation policy\" says:\n\n    \"No existing config options will have their meaning\n    changed in such a way that it would alter the software\n    behavior or otherwise render an existing config file\n    broken.\"\n\nThis makes me think that we should then have \"DEFAULT.xvpvncproxy_port\" and \"vnc.xvpvncproxy_port\" at the same time with the same value, right?\n\n[1] http://governance.openstack.org/reference/tags/assert_follows-standard-deprecation.html","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"4e91135b9253b6505dc7fe1a84c71adb54a729b5","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"},{"line_number":57,"context_line":"    \"\"\"Class to use the xvp auth protocol to proxy instance vnc consoles.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_f010045b","line":54,"in_reply_to":"3a29b11f_39e74ead","updated":"2015-10-22 17:51:39.000000000","message":"if you take a look at \n\nhttp://docs-draft.openstack.org/96/235396/2/check/gate-nova-docs/ea3d70f//doc/build/html/sample_config.html\n\nit\u0027s just move them to the [vnc] and not have DEFAULT.xxx\nso I think this rule at least don\u0027t work for now or the UpgradeImpact tells user to update their conf...","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6062,"name":"jichenjc","email":"jichenjc@cn.ibm.com","username":"jichenjc"},"change_message_id":"e247747f643db874b1e226ecfb5ed56364b90f3f","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"},{"line_number":57,"context_line":"    \"\"\"Class to use the xvp auth protocol to proxy instance vnc consoles.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_ef01da6b","line":54,"in_reply_to":"3a29b11f_773b6a39","updated":"2015-10-23 19:31:26.000000000","message":"I don\u0027t think we have it now .... though I prefer to agree with you that have both might helpful to user but\nthis also can bring some code and configuration confusion?\n\nbecause otherwise UpgradeImpact make no sense \nhttps://wiki.openstack.org/wiki/GitCommitMessages\n\n\nThe UpgradeImpact line contains the string UpgradeImpact and a comment about why the change impacts upgrades. It is used to indicate that a change has upgrade implications for those doing continuous deployment or N to N+1 upgrades. Also consider updating the \u0027Upgrade Notes\u0027 section in the release notes for the affected project.","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":6928,"name":"Ben Nemec","email":"openstack@nemebean.com","username":"bnemec"},"change_message_id":"a23a077863dbd71240f90bd8e6f08e54af5d7131","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"},{"line_number":57,"context_line":"    \"\"\"Class to use the xvp auth protocol to proxy instance vnc consoles.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_bc21a9fe","line":54,"in_reply_to":"3a29b11f_ef01da6b","updated":"2015-10-27 05:23:54.000000000","message":"Setting deprecated_group on an opt doesn\u0027t break existing configs that use the opt from the old group.  It simply means you can set it either through the DEFAULT group or the vnc group, and if you use the DEFAULT group you\u0027ll get a deprecation log message.\n\nTo see what\u0027s going on, take a look at the generated sample config for these options.  You\u0027ll see the opts in the DEFAULT group, with a note in their help string that they are deprecated, AND they\u0027ll be in the new \u0027vnc\u0027 group.","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"82c69a744fecf9363b75f1662a3ecd0891da68cc","unresolved":false,"context_lines":[{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.register_opts(xvp_proxy_opts, group\u003d\u0027vnc\u0027)"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"class XCPVNCProxy(object):"},{"line_number":57,"context_line":"    \"\"\"Class to use the xvp auth protocol to proxy instance vnc consoles.\"\"\""}],"source_content_type":"text/x-python","patch_set":5,"id":"3a29b11f_773b6a39","line":54,"in_reply_to":"3a29b11f_f010045b","updated":"2015-10-23 13:56:00.000000000","message":"Not having \"DEFAULT.xvpvncproxy_host\" anymore is the break we want to avoid with the standard deprecation policy, or do I get it the wrong way?","commit_id":"2eb208732d816a8de1ea20a8539171214691849e"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"da2af2f4696fc0d8ffa1f5705d909ab6f552b856","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                       XCPVNCProxy(),"},{"line_number":185,"context_line":"                       protocol\u003dSafeHttpProtocol,"},{"line_number":186,"context_line":"                       host\u003dCONF.xvpvncproxy_host,"},{"line_number":187,"context_line":"                       port\u003dCONF.xvpvncproxy_port)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a5de9d1_bc66d5b8","line":187,"updated":"2016-02-01 20:27:06.000000000","message":"Does the above two lines need to be changed to \n\nhost\u003dCONF.vnc.xvpvncproxy_host\nport\u003dCONF.vnc.xvpvncproxy_port  ?","commit_id":"e17be81ed87a90dfb28f23f75133d225df3f1acc"},{"author":{"_account_id":17734,"name":"Shih-Hao Li","email":"shihli@vmware.com","username":"shli"},"change_message_id":"932fea1751ef09f285cba9ba4fd85acce8dec04e","unresolved":false,"context_lines":[{"line_number":184,"context_line":"                       XCPVNCProxy(),"},{"line_number":185,"context_line":"                       protocol\u003dSafeHttpProtocol,"},{"line_number":186,"context_line":"                       host\u003dCONF.xvpvncproxy_host,"},{"line_number":187,"context_line":"                       port\u003dCONF.xvpvncproxy_port)"}],"source_content_type":"text/x-python","patch_set":12,"id":"7a5de9d1_b8057a46","line":187,"in_reply_to":"7a5de9d1_bc66d5b8","updated":"2016-02-01 22:55:11.000000000","message":"A patch for this is at https://review.openstack.org/#/c/274889/","commit_id":"e17be81ed87a90dfb28f23f75133d225df3f1acc"}]}