)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"e564eb1f3d8dcc84f93139204c3065c7136b7d75","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pawel Koniszewski \u003cpawel.koniszewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-16 11:25:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Finish post live migration even when exception occurs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when, e.g., port binding fails on destination host nova"},{"line_number":10,"context_line":"loses track of running VM. Operator needs to change record in DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dae33548_5069acbd","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"updated":"2016-02-16 11:08:26.000000000","message":"We probably need update the commit message. The migration didn\u0027t finish, we set the instance to error now.","commit_id":"31e60efcc41345f2c0d8fc73e5b90638f2968c2f"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"e054a0243af0780b2125210ecbef9dd848ad94a3","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pawel Koniszewski \u003cpawel.koniszewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-16 11:25:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Finish post live migration even when exception occurs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when, e.g., port binding fails on destination host nova"},{"line_number":10,"context_line":"loses track of running VM. Operator needs to change record in DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dae33548_568fe4cb","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"dae33548_5069acbd","updated":"2016-02-16 11:45:43.000000000","message":"Technically at this point migration is all done and instance is on destination host.","commit_id":"31e60efcc41345f2c0d8fc73e5b90638f2968c2f"},{"author":{"_account_id":5754,"name":"Alex Xu","email":"hejie.xu@intel.com","username":"xuhj"},"change_message_id":"008bc9fc3a8aaca44159393e79afaf3ba3ad5f11","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Pawel Koniszewski \u003cpawel.koniszewski@intel.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-02-16 11:25:42 +0100"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Finish post live migration even when exception occurs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently when, e.g., port binding fails on destination host nova"},{"line_number":10,"context_line":"loses track of running VM. Operator needs to change record in DB"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"dae33548_9319797c","line":7,"range":{"start_line":7,"start_character":0,"end_line":7,"end_character":6},"in_reply_to":"dae33548_568fe4cb","updated":"2016-02-16 12:41:28.000000000","message":"yea, but still left some network configuration. But nevermind, actually I mean how about we add some text about we set instance to error, and leave operator to do some manual thing to restore the instance...some text match the final decision.","commit_id":"31e60efcc41345f2c0d8fc73e5b90638f2968c2f"}],"nova/compute/manager.py":[{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"75a9791b57b905f1b9ee2ce503f364fc92fade90","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except exception.NovaException:"},{"line_number":5390,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5391,"context_line":"                instance.vm_state \u003d vm_states.ERROR"},{"line_number":5392,"context_line":"                LOG.error(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5393,"context_line":"        finally:"},{"line_number":5394,"context_line":"            # NOTE(pkoniszewski): Finish post live migration at destination"},{"line_number":5395,"context_line":"            # regardless of a result, because instance is already on"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_6c0e76e6","line":5392,"updated":"2015-10-16 22:40:29.000000000","message":"it will be better to use LOG.exception here","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"a5e2accd1bdec4a116e57f8322b462a806df3f9a","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except exception.NovaException:"},{"line_number":5390,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5391,"context_line":"                instance.vm_state \u003d vm_states.ERROR"},{"line_number":5392,"context_line":"                LOG.error(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5393,"context_line":"        finally:"},{"line_number":5394,"context_line":"            # NOTE(pkoniszewski): Finish post live migration at destination"},{"line_number":5395,"context_line":"            # regardless of a result, because instance is already on"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_db43756b","line":5392,"in_reply_to":"5a2ca52d_6c0e76e6","updated":"2015-10-19 05:58:40.000000000","message":"Done","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"75a9791b57b905f1b9ee2ce503f364fc92fade90","unresolved":false,"context_lines":[{"line_number":5390,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5391,"context_line":"                instance.vm_state \u003d vm_states.ERROR"},{"line_number":5392,"context_line":"                LOG.error(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5393,"context_line":"        finally:"},{"line_number":5394,"context_line":"            # NOTE(pkoniszewski): Finish post live migration at destination"},{"line_number":5395,"context_line":"            # regardless of a result, because instance is already on"},{"line_number":5396,"context_line":"            # destination host"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_8c84320b","line":5393,"updated":"2015-10-16 22:40:29.000000000","message":"why this finally section is moved to drivers.post_live_migration_on_destination?","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"81e68a3b4b8e15b5760e2c9ef26fe8a05fea4ded","unresolved":false,"context_lines":[{"line_number":5390,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":5391,"context_line":"                instance.vm_state \u003d vm_states.ERROR"},{"line_number":5392,"context_line":"                LOG.error(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5393,"context_line":"        finally:"},{"line_number":5394,"context_line":"            # NOTE(pkoniszewski): Finish post live migration at destination"},{"line_number":5395,"context_line":"            # regardless of a result, because instance is already on"},{"line_number":5396,"context_line":"            # destination host"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_d1ecc391","line":5393,"in_reply_to":"5a2ca52d_8c84320b","updated":"2015-10-18 07:11:14.000000000","message":"Because at this point we know that VM is already \"up and running\" on destination host.","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":14819,"name":"Timofey Durakov","email":"timofei.nd@gmail.com","username":"tdurakov"},"change_message_id":"75a9791b57b905f1b9ee2ce503f364fc92fade90","unresolved":false,"context_lines":[{"line_number":5405,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5406,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5407,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5408,"context_line":"                                                self.host)"},{"line_number":5409,"context_line":"        self._notify_about_instance_usage("},{"line_number":5410,"context_line":"                     context, instance, \"live_migration.post.dest.end\","},{"line_number":5411,"context_line":"                     network_info\u003dnetwork_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"5a2ca52d_0c182274","line":5408,"updated":"2015-10-16 22:40:29.000000000","message":"this change seems to be undesired.","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"a5e2accd1bdec4a116e57f8322b462a806df3f9a","unresolved":false,"context_lines":[{"line_number":5405,"context_line":"                                                prev_host, teardown\u003dTrue)"},{"line_number":5406,"context_line":"        # NOTE(vish): this is necessary to update dhcp"},{"line_number":5407,"context_line":"        self.network_api.setup_networks_on_host(context, instance,"},{"line_number":5408,"context_line":"                                                self.host)"},{"line_number":5409,"context_line":"        self._notify_about_instance_usage("},{"line_number":5410,"context_line":"                     context, instance, \"live_migration.post.dest.end\","},{"line_number":5411,"context_line":"                     network_info\u003dnetwork_info)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_1b4a4d84","line":5408,"in_reply_to":"5a2ca52d_0c182274","updated":"2015-10-19 05:58:40.000000000","message":"Done","commit_id":"b789efa37df069df1af5a3ad68783e5432816655"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e87cc33bc63803f1268a55d20759e1d03d5e8eb7","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"                block_device_info)"},{"line_number":5381,"context_line":"        except exception.NovaException:"},{"line_number":5382,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5383,"context_line":"            LOG.exception(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"        # Restore instance state"},{"line_number":5386,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_e573e3b2","line":5383,"range":{"start_line":5383,"start_character":16,"end_line":5383,"end_character":25},"updated":"2015-11-16 04:01:57.000000000","message":"Is a VIF plug failure really the only place an exception might be raised in the post_live_migration_at_destination code? I see guest config XML etc being generated there, so I think perhaps we need to catch a more specific exception here.","commit_id":"fd9f8b68534e9aa81cb6c43cfdf2526fbdc6ceff"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"5a844fbf27efd2bbb9a4950849367ec9f146e667","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"                block_device_info)"},{"line_number":5381,"context_line":"        except exception.NovaException:"},{"line_number":5382,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5383,"context_line":"            LOG.exception(_LE(\u0027Failed to bind port on destination host\u0027))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"        # Restore instance state"},{"line_number":5386,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"ba8a016a_56c44491","line":5383,"in_reply_to":"da85f559_e573e3b2","updated":"2015-11-16 09:51:34.000000000","message":"There are a lot of exception that can be raised. I just didn\u0027t want to use \"except Exception\", but...","commit_id":"fd9f8b68534e9aa81cb6c43cfdf2526fbdc6ceff"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"454a3dc390fb6bca558d701e93dc184d51c16bd4","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"        except Exception:"},{"line_number":5381,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5382,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5383,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"        # Restore instance state"},{"line_number":5386,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_1e145c42","line":5383,"updated":"2015-11-17 07:43:38.000000000","message":"This log is too generic. \n since, there maybe more  unknown issues to  raise this exception. \n Why not gives more information for debug. \n\n  \u0027Unexpected error during post live migration at destination host. detail %s\u0027","commit_id":"4fa7f2c4c2b75421ae47b58e0e66542c16a5cfde"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"d8fde89cc69e59163466228773cbd50076e7452e","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"        except Exception:"},{"line_number":5381,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5382,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5383,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"        # Restore instance state"},{"line_number":5386,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_1e421c3f","line":5383,"in_reply_to":"ba8a016a_1e145c42","updated":"2015-11-17 07:45:46.000000000","message":"log.exception is already used for that","commit_id":"4fa7f2c4c2b75421ae47b58e0e66542c16a5cfde"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"978245af65b89099ce87e2faa5eecd2bcf70ba31","unresolved":false,"context_lines":[{"line_number":5380,"context_line":"        except Exception:"},{"line_number":5381,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5382,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5383,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5384,"context_line":""},{"line_number":5385,"context_line":"        # Restore instance state"},{"line_number":5386,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":6,"id":"ba8a016a_34705f72","line":5383,"in_reply_to":"ba8a016a_1e421c3f","updated":"2015-11-17 08:47:04.000000000","message":"yes, you are right. \n\nJust find some code in nova still log it.  Such as: \nhttps://github.com/openstack/nova/blob/master/nova/compute/manager.py#L6638","commit_id":"4fa7f2c4c2b75421ae47b58e0e66542c16a5cfde"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"faacbb197fc855d45c2e10d9651339a182d09037","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except Exception:"},{"line_number":5390,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5391,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5392,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5393,"context_line":""},{"line_number":5394,"context_line":"        # Restore instance state"},{"line_number":5395,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_bc1772ec","line":5392,"updated":"2015-12-31 01:11:03.000000000","message":"At here, we just LOG a exception , I wonder if we should just raise it instead of keep it going?","commit_id":"a8ac15250451540ab7afe1ded4f8ba28d2885465"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"c598c9d6af56c710e626531b003e651f359d64e0","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except Exception:"},{"line_number":5390,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5391,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5392,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5393,"context_line":""},{"line_number":5394,"context_line":"        # Restore instance state"},{"line_number":5395,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_b0864bd9","line":5392,"in_reply_to":"da6ed579_0a2b6995","updated":"2016-01-14 08:52:04.000000000","message":"Makes sense, done.","commit_id":"a8ac15250451540ab7afe1ded4f8ba28d2885465"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"db04f47a37ab203cce65f542effa0ef62a0af43e","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except Exception:"},{"line_number":5390,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5391,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5392,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5393,"context_line":""},{"line_number":5394,"context_line":"        # Restore instance state"},{"line_number":5395,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"da6ed579_0a2b6995","line":5392,"in_reply_to":"fa69d971_653a28e9","updated":"2016-01-14 06:01:54.000000000","message":"In that case I think you need a block comment here explaining why you\u0027re not re-raising the exception. Otherwise it looks like an error and someone will \"fix\" it.","commit_id":"a8ac15250451540ab7afe1ded4f8ba28d2885465"},{"author":{"_account_id":12299,"name":"Paweł Koniszewski","email":"pawel.koniszewski@gmail.com","username":"pawel.koniszewski"},"change_message_id":"67a6be24d65404b851cf4a61b6fd370d36f1ab9f","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except Exception:"},{"line_number":5390,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5391,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5392,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5393,"context_line":""},{"line_number":5394,"context_line":"        # Restore instance state"},{"line_number":5395,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_fadba719","line":5392,"in_reply_to":"fa69d971_bc1772ec","updated":"2015-12-31 07:41:06.000000000","message":"Currently if exception is raised during post_live_migration_at_destination we do not update instance\u0027s host to the new one (so nova loses track of a VM). This is because logic that changes instance\u0027s host to the new one starts in line 5395 and it can\u0027t be reached in case of an exception.\n\nThis fix tries to solve it by catching exception and putting VM in error state. If we reraise this exception we will end up with the same issue - nova will think that VM is still running on source host.","commit_id":"a8ac15250451540ab7afe1ded4f8ba28d2885465"},{"author":{"_account_id":12175,"name":"Eli Qiao","email":"qiaoliyong@gmail.com","username":"Eli"},"change_message_id":"420a6f4742c3794baa4b03638af5fa42e02afb58","unresolved":false,"context_lines":[{"line_number":5389,"context_line":"        except Exception:"},{"line_number":5390,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5391,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5392,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5393,"context_line":""},{"line_number":5394,"context_line":"        # Restore instance state"},{"line_number":5395,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":7,"id":"fa69d971_653a28e9","line":5392,"in_reply_to":"fa69d971_fadba719","updated":"2016-01-06 05:38:38.000000000","message":"make sense, +1 ,thanks Pawel.","commit_id":"a8ac15250451540ab7afe1ded4f8ba28d2885465"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"864dde8f016008d5b6ecd06d9a3e960ec1dd7ec6","unresolved":false,"context_lines":[{"line_number":5369,"context_line":""},{"line_number":5370,"context_line":"    @wrap_exception()"},{"line_number":5371,"context_line":"    @wrap_instance_event"},{"line_number":5372,"context_line":"    @wrap_instance_fault"},{"line_number":5373,"context_line":"    def post_live_migration_at_destination(self, context, instance,"},{"line_number":5374,"context_line":"                                           block_migration):"},{"line_number":5375,"context_line":"        \"\"\"Post operations for live migration ."}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_274222af","line":5372,"updated":"2016-01-29 16:35:16.000000000","message":"This now skips adding an instance fault and an error for the event, which feels bad to me.\n\nSee the usages of compute_utils.add_instance_fault_from_exc","commit_id":"c181c793440d642dde569a1850f8aadf6531375f"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"19dc99c8d543f0d5b8ee3392681dd229e1f9e936","unresolved":false,"context_lines":[{"line_number":5411,"context_line":"            # lose track of a VM and will require manual update in database."},{"line_number":5412,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5413,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5414,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5415,"context_line":""},{"line_number":5416,"context_line":"        # Restore instance state"},{"line_number":5417,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba63e191_5803e973","line":5414,"range":{"start_line":5414,"start_character":47,"end_line":5414,"end_character":51},"updated":"2016-01-19 08:59:10.000000000","message":"more details about the exception messaging?\n\n\nnot sure should capture the Exception messaging to help for debug. \n\nmaybe the destination host or instance is better to be specified","commit_id":"c181c793440d642dde569a1850f8aadf6531375f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e68d9e3cd166a53ebde60f66ef3485412bb0cc99","unresolved":false,"context_lines":[{"line_number":5411,"context_line":"            # lose track of a VM and will require manual update in database."},{"line_number":5412,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5413,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5414,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5415,"context_line":""},{"line_number":5416,"context_line":"        # Restore instance state"},{"line_number":5417,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"ba63e191_dc657f45","line":5414,"range":{"start_line":5414,"start_character":47,"end_line":5414,"end_character":51},"in_reply_to":"ba63e191_5803e973","updated":"2016-01-19 14:56:25.000000000","message":"This at the least needs an instance\u003dinstance kwarg arg like the log lines above it.","commit_id":"c181c793440d642dde569a1850f8aadf6531375f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"864dde8f016008d5b6ecd06d9a3e960ec1dd7ec6","unresolved":false,"context_lines":[{"line_number":5411,"context_line":"            # lose track of a VM and will require manual update in database."},{"line_number":5412,"context_line":"            instance.vm_state \u003d vm_states.ERROR"},{"line_number":5413,"context_line":"            LOG.exception(_LE(\u0027Unexpected error during post live migration at \u0027"},{"line_number":5414,"context_line":"                              \u0027destination host.\u0027))"},{"line_number":5415,"context_line":""},{"line_number":5416,"context_line":"        # Restore instance state"},{"line_number":5417,"context_line":"        current_power_state \u003d self._get_power_state(context, instance)"}],"source_content_type":"text/x-python","patch_set":8,"id":"7a5de9d1_c751ce37","line":5414,"range":{"start_line":5414,"start_character":47,"end_line":5414,"end_character":51},"in_reply_to":"ba63e191_dc657f45","updated":"2016-01-29 16:35:16.000000000","message":"I don\u0027t think this is a safe thing to do, just ignoring the errors from this call.\n\nit also doesn\u0027t fix anything if the network_api calls above fail.\n\nWhat about wrapping all of the above code with a finally clause that executes the lines below up to 5430?","commit_id":"c181c793440d642dde569a1850f8aadf6531375f"}]}