)]}'
{"nova/tests/test_migrations.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5d5af2ef3df6f50c1a0d5458307687c70d49b13b","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        got_one \u003d False"},{"line_number":996,"context_line":"        for value in values:"},{"line_number":997,"context_line":"            got_one \u003d True"},{"line_number":998,"context_line":"            self.assertTrue(value[\u0027deleted\u0027] is None)"},{"line_number":999,"context_line":"        self.assertTrue(got_one)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def _check_160(self, engine, data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7q8%3D","line":998,"updated":"2013-03-05 23:32:14.000000000","message":"assertTrue\u0027s are best avoided if we can. Can we do an Equal or if there are None assertions?","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"402a8cd8cb382a059be3779a3fa42bfda11a7c2d","unresolved":false,"context_lines":[{"line_number":995,"context_line":"        got_one \u003d False"},{"line_number":996,"context_line":"        for value in values:"},{"line_number":997,"context_line":"            got_one \u003d True"},{"line_number":998,"context_line":"            self.assertTrue(value[\u0027deleted\u0027] is None)"},{"line_number":999,"context_line":"        self.assertTrue(got_one)"},{"line_number":1000,"context_line":""},{"line_number":1001,"context_line":"    def _check_160(self, engine, data):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7qY%3D","line":998,"in_reply_to":"AAAAN3%2F%2F7q8%3D","updated":"2013-03-05 23:40:08.000000000","message":"Ok.  Generally you don\u0027t \u0027Equal\u0027 None... but for assertions it\u0027s probably ok!","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"f57f96aec4bbdcfd8b584a823cecdcaab9b3d312","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    def _check_160(self, engine, data):"},{"line_number":1002,"context_line":"        sys_meta \u003d get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":1003,"context_line":"        values \u003d sys_meta.select().execute()"},{"line_number":1004,"context_line":"        got_one \u003d False"},{"line_number":1005,"context_line":"        for value in values:"},{"line_number":1006,"context_line":"            got_one \u003d True"},{"line_number":1007,"context_line":"            self.assertEqual(value[\u0027deleted\u0027], 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7sw%3D","line":1004,"updated":"2013-03-05 23:08:24.000000000","message":"Why not assert that values is not 0-length?","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"cf6abb2b4ce3d9ba5f5df8ee3d8ed44cf070b0f2","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    def _check_160(self, engine, data):"},{"line_number":1002,"context_line":"        sys_meta \u003d get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":1003,"context_line":"        values \u003d sys_meta.select().execute()"},{"line_number":1004,"context_line":"        got_one \u003d False"},{"line_number":1005,"context_line":"        for value in values:"},{"line_number":1006,"context_line":"            got_one \u003d True"},{"line_number":1007,"context_line":"            self.assertEqual(value[\u0027deleted\u0027], 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7mM%3D","line":1004,"in_reply_to":"AAAAN3%2F%2F7rs%3D","updated":"2013-03-06 00:33:01.000000000","message":"I hate to point out the obvious,  but just use this instead:\n\n  values \u003d list(sys_meta.select().execute())\n\nNow you have a list that is reusable :)","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"9cac0475de8b76d58fcd11cad85dc0434a700e6a","unresolved":false,"context_lines":[{"line_number":1001,"context_line":"    def _check_160(self, engine, data):"},{"line_number":1002,"context_line":"        sys_meta \u003d get_table(engine, \u0027instance_system_metadata\u0027)"},{"line_number":1003,"context_line":"        values \u003d sys_meta.select().execute()"},{"line_number":1004,"context_line":"        got_one \u003d False"},{"line_number":1005,"context_line":"        for value in values:"},{"line_number":1006,"context_line":"            got_one \u003d True"},{"line_number":1007,"context_line":"            self.assertEqual(value[\u0027deleted\u0027], 0)"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7rs%3D","line":1004,"in_reply_to":"AAAAN3%2F%2F7sw%3D","updated":"2013-03-05 23:26:41.000000000","message":"It seems you can only iterate once.  It\u0027s a ResultProxy object that\u0027s returned... so I tried checking len(list(values)) but then I could no longer use \u0027values\u0027 after that.\n\nThat said, I have another modification to this test coming based on IRC feedback.","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"5d5af2ef3df6f50c1a0d5458307687c70d49b13b","unresolved":false,"context_lines":[{"line_number":1005,"context_line":"        for value in values:"},{"line_number":1006,"context_line":"            got_one \u003d True"},{"line_number":1007,"context_line":"            self.assertEqual(value[\u0027deleted\u0027], 0)"},{"line_number":1008,"context_line":"        self.assertTrue(got_one)"},{"line_number":1009,"context_line":""},{"line_number":1010,"context_line":""},{"line_number":1011,"context_line":"class TestBaremetalMigrations(BaseMigrationTestCase, CommonTestsMixIn):"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F7rE%3D","line":1008,"updated":"2013-03-05 23:32:14.000000000","message":"instead of the got_one can we do a counter, then assertEqual the expected lengths at the end?","commit_id":"96ae8120297518fc2bd1e0bd31e7917f38fe7bdd"}]}