)]}'
{"nova/tests/network/test_api.py":[{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2813e1c97f3518cb035438ce2cb230cae361c60b","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        inst_type[\u0027rxtx_factor\u0027] \u003d 0"},{"line_number":86,"context_line":"        sys_meta \u003d instance_types.save_instance_type_info({}, inst_type)"},{"line_number":87,"context_line":"        instance \u003d dict(id\u003d\u0027id\u0027, uuid\u003d\u0027uuid\u0027, project_id\u003d\u0027project_id\u0027,"},{"line_number":88,"context_line":"            host\u003d\u0027host\u0027, system_metadata\u003dutils.dict_to_metadata(sys_meta))"},{"line_number":89,"context_line":"        self.network_api.allocate_for_instance("},{"line_number":90,"context_line":"            self.context, instance, \u0027vpn\u0027, \u0027requested_networks\u0027, macs\u003dmacs)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F5J4%3D","line":88,"updated":"2013-03-07 11:25:26.000000000","message":"I\u0027m not clear why you are converting sys_meta here, but you didn\u0027t on previous patches, eg here:\nhttps://review.openstack.org/#/c/23500/3/nova/tests/test_libvirt.py","commit_id":"351655aec34edff1e52d07d2b48e5a08a53d71a9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"68b26993a3a4d649976b9608f8e635c9bcbcd4b2","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        inst_type[\u0027rxtx_factor\u0027] \u003d 0"},{"line_number":86,"context_line":"        sys_meta \u003d instance_types.save_instance_type_info({}, inst_type)"},{"line_number":87,"context_line":"        instance \u003d dict(id\u003d\u0027id\u0027, uuid\u003d\u0027uuid\u0027, project_id\u003d\u0027project_id\u0027,"},{"line_number":88,"context_line":"            host\u003d\u0027host\u0027, system_metadata\u003dutils.dict_to_metadata(sys_meta))"},{"line_number":89,"context_line":"        self.network_api.allocate_for_instance("},{"line_number":90,"context_line":"            self.context, instance, \u0027vpn\u0027, \u0027requested_networks\u0027, macs\u003dmacs)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4l0%3D","line":88,"in_reply_to":"AAAAN3%2F%2F4%2BM%3D","updated":"2013-03-07 17:34:08.000000000","message":"Confusing, indeed! I\u0027ve been trying to keep track of when it\u0027s a dict and when it\u0027s not, and clearly I haven\u0027t done that very well! \n\nPerhaps at some point we can make this a bit more consistent, eg. make all the code outside of the db/api use dict?","commit_id":"351655aec34edff1e52d07d2b48e5a08a53d71a9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"c2bcdde404a44ed0f8088c6e1422d1e234cdce4d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        inst_type[\u0027rxtx_factor\u0027] \u003d 0"},{"line_number":86,"context_line":"        sys_meta \u003d instance_types.save_instance_type_info({}, inst_type)"},{"line_number":87,"context_line":"        instance \u003d dict(id\u003d\u0027id\u0027, uuid\u003d\u0027uuid\u0027, project_id\u003d\u0027project_id\u0027,"},{"line_number":88,"context_line":"            host\u003d\u0027host\u0027, system_metadata\u003dutils.dict_to_metadata(sys_meta))"},{"line_number":89,"context_line":"        self.network_api.allocate_for_instance("},{"line_number":90,"context_line":"            self.context, instance, \u0027vpn\u0027, \u0027requested_networks\u0027, macs\u003dmacs)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4kw%3D","line":88,"in_reply_to":"AAAAN3%2F%2F4l0%3D","updated":"2013-03-07 17:39:14.000000000","message":"Yeah, I\u0027d love to. Right now, SQL-A is getting in our way, because instance[\u0027system_metadata\u0027] is a managed list, so I can\u0027t replace that property without it trying to update the database. Presumably when we get the db-primitives work done, we could tuck this in with that. Believe me, I\u0027d be much happer :D","commit_id":"351655aec34edff1e52d07d2b48e5a08a53d71a9"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"b164295436e696cccde34b0b9cdce6cf5ae25aba","unresolved":false,"context_lines":[{"line_number":85,"context_line":"        inst_type[\u0027rxtx_factor\u0027] \u003d 0"},{"line_number":86,"context_line":"        sys_meta \u003d instance_types.save_instance_type_info({}, inst_type)"},{"line_number":87,"context_line":"        instance \u003d dict(id\u003d\u0027id\u0027, uuid\u003d\u0027uuid\u0027, project_id\u003d\u0027project_id\u0027,"},{"line_number":88,"context_line":"            host\u003d\u0027host\u0027, system_metadata\u003dutils.dict_to_metadata(sys_meta))"},{"line_number":89,"context_line":"        self.network_api.allocate_for_instance("},{"line_number":90,"context_line":"            self.context, instance, \u0027vpn\u0027, \u0027requested_networks\u0027, macs\u003dmacs)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4%2BM%3D","line":88,"in_reply_to":"AAAAN3%2F%2F5J4%3D","updated":"2013-03-07 14:38:22.000000000","message":"The problem is that instance_update() takes a dict, but it (and instance_get) returns system_metadata as this awkward array of dicts. Some of the tests pass these to the database first and then fetch out the instance. Others use this instance dict as the fake instance itself. If they do the former, we don\u0027t need to convert it, because the trip through the database will. If they do the latter, we do, because the \"real\" code that is being tested will expect the instance in the database\u0027s format.\n\nConfusing, eh?","commit_id":"351655aec34edff1e52d07d2b48e5a08a53d71a9"},{"author":{"_account_id":2889,"name":"Aeva Black","email":"aeva.online@gmail.com","username":"tenbrae"},"change_message_id":"2813e1c97f3518cb035438ce2cb230cae361c60b","unresolved":false,"context_lines":[{"line_number":142,"context_line":"    def _stub_migrate_instance_calls(self, method, multi_host, info):"},{"line_number":143,"context_line":"        fake_instance_type \u003d instance_types.get_default_instance_type()"},{"line_number":144,"context_line":"        fake_instance_type[\u0027rxtx_factor\u0027] \u003d 1.21"},{"line_number":145,"context_line":"        sys_meta \u003d utils.dict_to_metadata("},{"line_number":146,"context_line":"            instance_types.save_instance_type_info({}, fake_instance_type))"},{"line_number":147,"context_line":"        fake_instance \u003d {\u0027uuid\u0027: \u0027fake_uuid\u0027,"},{"line_number":148,"context_line":"                         \u0027instance_type_id\u0027: fake_instance_type[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F5J0%3D","line":145,"updated":"2013-03-07 11:25:26.000000000","message":"Same question here","commit_id":"351655aec34edff1e52d07d2b48e5a08a53d71a9"}]}