)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"5317a55e94985e16d65682cfa4bd81e12c5ba0e6","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently hypervisor_type of xen shown in nova api is \u0027xen\u0027, while"},{"line_number":10,"context_line":"\u0027XenServer\u0027 could be more accurate."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"Change-Id: Ia406e6762312367c0a12db491623766951d49dc6"},{"line_number":13,"context_line":"Closes-Bug: #1507424"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a29b11f_a945c917","line":11,"updated":"2015-10-20 12:28:21.000000000","message":"I think that you need UpgradeImpact here\n\nThis may break existing API\u0027s if someone is parsing this data.","commit_id":"c80911cbf183dd84148afff2f78794f323cb188c"}],"nova/tests/unit/virt/libvirt/test_driver.py":[{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"e627e2e20a67e7006c803ad23048c80f42b3654c","unresolved":false,"context_lines":[{"line_number":3980,"context_line":"            \u0027local_gb_used\u0027: 0,"},{"line_number":3981,"context_line":"            \u0027free_ram_mb\u0027: 1024,"},{"line_number":3982,"context_line":"            \u0027free_disk_gb\u0027: 2048,"},{"line_number":3983,"context_line":"            \u0027hypervisor_type\u0027: \u0027XenServer\u0027,"},{"line_number":3984,"context_line":"            \u0027hypervisor_version\u0027: 1,"},{"line_number":3985,"context_line":"            \u0027running_vms\u0027: 0,"},{"line_number":3986,"context_line":"            \u0027cpu_info\u0027: \u0027\u0027,"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_7142fd69","line":3983,"updated":"2015-10-21 12:22:20.000000000","message":"This should only be changed for XenServer; the hypervisor type here must stay as \u0027xen\u0027.","commit_id":"777dfe1ef553defe68ba85504e52e89b141edae3"}],"nova/virt/xenapi/driver.py":[{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"35dc68412663a5ce129292c8802981dfb291c938","unresolved":false,"context_lines":[{"line_number":453,"context_line":"               \u0027vcpus_used\u0027: host_stats[\u0027vcpus_used\u0027],"},{"line_number":454,"context_line":"               \u0027memory_mb_used\u0027: total_ram_mb - free_ram_mb,"},{"line_number":455,"context_line":"               \u0027local_gb_used\u0027: used_disk_gb,"},{"line_number":456,"context_line":"               \u0027hypervisor_type\u0027: \u0027XenServer\u0027,"},{"line_number":457,"context_line":"               \u0027hypervisor_version\u0027: hyper_ver,"},{"line_number":458,"context_line":"               \u0027hypervisor_hostname\u0027: host_stats[\u0027host_hostname\u0027],"},{"line_number":459,"context_line":"               \u0027cpu_info\u0027: jsonutils.dumps(host_stats[\u0027cpu_model\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_994fcd6a","line":456,"updated":"2015-10-21 08:44:40.000000000","message":"Naming is hard.  This has been named this way since at least 2011.  So it\u0027d not like this is a \"new\" bug.\n\nMy take is that Xen is the hypervisor project and XenServer is one distro that exploits it.  If that\u0027s correct then returning this as the hypervisor_type is incorrect.","commit_id":"777dfe1ef553defe68ba85504e52e89b141edae3"},{"author":{"_account_id":6735,"name":"Bob Ball","email":"bob.ball@citrix.com","username":"bob-ball"},"change_message_id":"dd0f0f18737fc097aba9424181b66d57fee2541b","unresolved":false,"context_lines":[{"line_number":453,"context_line":"               \u0027vcpus_used\u0027: host_stats[\u0027vcpus_used\u0027],"},{"line_number":454,"context_line":"               \u0027memory_mb_used\u0027: total_ram_mb - free_ram_mb,"},{"line_number":455,"context_line":"               \u0027local_gb_used\u0027: used_disk_gb,"},{"line_number":456,"context_line":"               \u0027hypervisor_type\u0027: \u0027XenServer\u0027,"},{"line_number":457,"context_line":"               \u0027hypervisor_version\u0027: hyper_ver,"},{"line_number":458,"context_line":"               \u0027hypervisor_hostname\u0027: host_stats[\u0027host_hostname\u0027],"},{"line_number":459,"context_line":"               \u0027cpu_info\u0027: jsonutils.dumps(host_stats[\u0027cpu_model\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_aa3349aa","line":456,"in_reply_to":"3a29b11f_994fcd6a","updated":"2015-10-21 09:47:47.000000000","message":"Unfortuately it\u0027s not that simple.\nXen is the hypervisor, which is supported by two drivers in Nova - libvirt+xen and XenAPI.\nThe XenAPI driver depends on the XAPI toolstack which is only available as part of XenServer\n\nThe correct name here is \u0027XenServer\u0027 as it disambiguate from \u0027Xen\u0027 as in running libvirt+xen.","commit_id":"777dfe1ef553defe68ba85504e52e89b141edae3"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"1bf18504055c8f93b25062e52800466fbeea8fcc","unresolved":false,"context_lines":[{"line_number":453,"context_line":"               \u0027vcpus_used\u0027: host_stats[\u0027vcpus_used\u0027],"},{"line_number":454,"context_line":"               \u0027memory_mb_used\u0027: total_ram_mb - free_ram_mb,"},{"line_number":455,"context_line":"               \u0027local_gb_used\u0027: used_disk_gb,"},{"line_number":456,"context_line":"               \u0027hypervisor_type\u0027: \u0027XenServer\u0027,"},{"line_number":457,"context_line":"               \u0027hypervisor_version\u0027: hyper_ver,"},{"line_number":458,"context_line":"               \u0027hypervisor_hostname\u0027: host_stats[\u0027host_hostname\u0027],"},{"line_number":459,"context_line":"               \u0027cpu_info\u0027: jsonutils.dumps(host_stats[\u0027cpu_model\u0027]),"}],"source_content_type":"text/x-python","patch_set":3,"id":"3a29b11f_f05a67f1","line":456,"in_reply_to":"3a29b11f_aa3349aa","updated":"2015-10-22 01:29:43.000000000","message":"\"The XenAPI driver depends on the XAPI toolstack which is only available as part of XenServer\"  Ahh that was the key part I was missing.\n\nThanks Bob.","commit_id":"777dfe1ef553defe68ba85504e52e89b141edae3"}]}
