)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff3401bb6d37608c6d0a01f31c8f59d3bdefdb11","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chung Chih, Hung \u003clyan.h@inwinstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-21 06:10:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Notify users if libguestfs can\u0027t read host kernel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Host\u0027s kernel only allow root user had read/write permission in"},{"line_number":10,"context_line":"ubuntu. If compute-service didn\u0027t had read permission then libguestfs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a29b11f_505a692b","line":7,"updated":"2015-10-21 07:58:42.000000000","message":"This was a little confusing. Please do the following:\n1. prefix this with libvirt\n2. Consider having: libvirt: add log if libguestfs can\u0027t read host kernel","commit_id":"bde43677a690af3ef0a2339acfda3b74fb9267d0"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"f98a5639f2acf3a3e0da31320736a84b8b57c2d9","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Chung Chih, Hung \u003clyan.h@inwinstack.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-21 06:10:23 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Notify users if libguestfs can\u0027t read host kernel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Host\u0027s kernel only allow root user had read/write permission in"},{"line_number":10,"context_line":"ubuntu. If compute-service didn\u0027t had read permission then libguestfs"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a26ad4f_d1ad8889","line":7,"in_reply_to":"3a29b11f_505a692b","updated":"2015-10-28 09:09:05.000000000","message":"Done","commit_id":"bde43677a690af3ef0a2339acfda3b74fb9267d0"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"ff3401bb6d37608c6d0a01f31c8f59d3bdefdb11","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In libguestfs offical FAQ site had point out this issue, following is"},{"line_number":14,"context_line":"the link"},{"line_number":15,"context_line":"http://libguestfs.org/guestfs-faq.1.html#binaries"},{"line_number":16,"context_line":"It had suggested users to change host\u0027s kernel permission. But this"},{"line_number":17,"context_line":"action should been handle by other patch. Here only give a hint what\u0027s"},{"line_number":18,"context_line":"going wrong."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a29b11f_d046794e","line":16,"updated":"2015-10-21 07:58:42.000000000","message":"this is only alg for the admin so i am not sure how the end use ris going to be aware of this","commit_id":"bde43677a690af3ef0a2339acfda3b74fb9267d0"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"f98a5639f2acf3a3e0da31320736a84b8b57c2d9","unresolved":false,"context_lines":[{"line_number":13,"context_line":"In libguestfs offical FAQ site had point out this issue, following is"},{"line_number":14,"context_line":"the link"},{"line_number":15,"context_line":"http://libguestfs.org/guestfs-faq.1.html#binaries"},{"line_number":16,"context_line":"It had suggested users to change host\u0027s kernel permission. But this"},{"line_number":17,"context_line":"action should been handle by other patch. Here only give a hint what\u0027s"},{"line_number":18,"context_line":"going wrong."},{"line_number":19,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"1a26ad4f_11d22001","line":16,"in_reply_to":"3a29b11f_d046794e","updated":"2015-10-28 09:09:05.000000000","message":"I though end user can\u0027t fix this issue. They need to contact with admin for help. Lucky, this issue will only happen in ubuntu/debian.","commit_id":"bde43677a690af3ef0a2339acfda3b74fb9267d0"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"89db36a12ae1efd0d0b39ea6f11a4bd7fe91ff01","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"libvirt - Add log if libguestfs can\u0027t read host kernel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Host\u0027s kernel only allow root user had read/write permission in"},{"line_number":10,"context_line":"ubuntu. If compute-service didn\u0027t had read permission then libguestfs"},{"line_number":11,"context_line":"will launch image fail."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a7e1126_1211085d","line":9,"updated":"2015-12-22 00:15:12.000000000","message":"\u0027allows a root user to have\u0027 would be better.","commit_id":"e8964d12d42abe645f8c56eb436eb28542720563"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"89db36a12ae1efd0d0b39ea6f11a4bd7fe91ff01","unresolved":false,"context_lines":[{"line_number":7,"context_line":"libvirt - Add log if libguestfs can\u0027t read host kernel"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Host\u0027s kernel only allow root user had read/write permission in"},{"line_number":10,"context_line":"ubuntu. If compute-service didn\u0027t had read permission then libguestfs"},{"line_number":11,"context_line":"will launch image fail."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"In libguestfs offical FAQ site had point out this issue, following is"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a7e1126_0d080d27","line":10,"updated":"2015-12-22 00:15:12.000000000","message":"\"didn\u0027t have\" would be better.","commit_id":"e8964d12d42abe645f8c56eb436eb28542720563"},{"author":{"_account_id":7634,"name":"Takashi Natsume","email":"takanattie@gmail.com","username":"natsumet"},"change_message_id":"89db36a12ae1efd0d0b39ea6f11a4bd7fe91ff01","unresolved":false,"context_lines":[{"line_number":14,"context_line":"the link"},{"line_number":15,"context_line":"http://libguestfs.org/guestfs-faq.1.html#binaries"},{"line_number":16,"context_line":"It had suggested users to change host\u0027s kernel permission. But this"},{"line_number":17,"context_line":"action should been handle by other patch. Here only give a hint what\u0027s"},{"line_number":18,"context_line":"going wrong."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I36c93610831e2935d46f7ee37f95619fe6dc1481"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"3a7e1126_ed3821d5","line":17,"updated":"2015-12-22 00:15:12.000000000","message":"\u0027should be handled\u0027?","commit_id":"e8964d12d42abe645f8c56eb436eb28542720563"}],"nova/tests/unit/virt/disk/vfs/test_guestfs.py":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"86dc1790bae4e19d3abf336554f045e9b5ca7ffc","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        vfs \u003d vfsimpl.VFSGuestFS(self.qcowfile)"},{"line_number":322,"context_line":"        with mock.patch(\u0027eventlet.tpool.Proxy\u0027, return_value\u003dm):"},{"line_number":323,"context_line":"            self.assertRaises(exception.NovaException,"},{"line_number":324,"context_line":"                              vfs.inspect_capabilities)"},{"line_number":325,"context_line":"            m.add_drive.assert_called_once_with(\u0027/dev/null\u0027)"},{"line_number":326,"context_line":"            m.launch.assert_called_once_with()"},{"line_number":327,"context_line":"            mock_access.assert_called_once_with(\u0027/boot/vmlinuz-kernel_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_d64e9595","line":324,"updated":"2015-10-20 15:15:23.000000000","message":"you had better check the  NovaExceptiion message.","commit_id":"6cb6cfc7854f5ccb0e0948242169f03a2fad99fc"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"4bd96e7c229e3b51a809406b1caa45b01c9e5453","unresolved":false,"context_lines":[{"line_number":321,"context_line":"        vfs \u003d vfsimpl.VFSGuestFS(self.qcowfile)"},{"line_number":322,"context_line":"        with mock.patch(\u0027eventlet.tpool.Proxy\u0027, return_value\u003dm):"},{"line_number":323,"context_line":"            self.assertRaises(exception.NovaException,"},{"line_number":324,"context_line":"                              vfs.inspect_capabilities)"},{"line_number":325,"context_line":"            m.add_drive.assert_called_once_with(\u0027/dev/null\u0027)"},{"line_number":326,"context_line":"            m.launch.assert_called_once_with()"},{"line_number":327,"context_line":"            mock_access.assert_called_once_with(\u0027/boot/vmlinuz-kernel_name\u0027,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_2bf18a01","line":324,"in_reply_to":"3a29b11f_d64e9595","updated":"2015-10-21 06:10:43.000000000","message":"done","commit_id":"6cb6cfc7854f5ccb0e0948242169f03a2fad99fc"}],"nova/virt/disk/vfs/guestfs.py":[{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"86dc1790bae4e19d3abf336554f045e9b5ca7ffc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.warning(_LW(\"libguestfs needs read permission for \""},{"line_number":91,"context_line":"                                \"host kernel.\"))"},{"line_number":92,"context_line":"            raise exception.NovaException("},{"line_number":93,"context_line":"                _(\"libguestfs installed but not usable (%s)\") % e)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return self"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_d6c0d5e2","line":93,"updated":"2015-10-20 15:15:23.000000000","message":"you had better improve the exception message when need read permission. \n\nFor I have check the message, it does not give enough info for it need read permission.\nIn [1]: from eventlet import tpool\n\nIn [2]: import guestfs\n\nIn [3]: g \u003d tpool.Proxy(guestfs.GuestFS())\n\nIn [4]: g.add_drive(\"/dev/null\")  \n\nIn [5]: try:                      \n    g.launch()\nexcept Exception as e:\n    print e\n   ...:     \n/usr/bin/supermin exited with error status 1.\nTo see full error messages you may need to enable debugging.\nDo:\n  export LIBGUESTFS_DEBUG\u003d1 LIBGUESTFS_TRACE\u003d1\nand run the command again.  For further information, read:\n  http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs\nYou can also run \u0027libguestfs-test-tool\u0027 and post the *complete* output\ninto a bug report or message to the libguestfs mailing list.\n\nIn [6]:","commit_id":"6cb6cfc7854f5ccb0e0948242169f03a2fad99fc"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"4bd96e7c229e3b51a809406b1caa45b01c9e5453","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.warning(_LW(\"libguestfs needs read permission for \""},{"line_number":91,"context_line":"                                \"host kernel.\"))"},{"line_number":92,"context_line":"            raise exception.NovaException("},{"line_number":93,"context_line":"                _(\"libguestfs installed but not usable (%s)\") % e)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return self"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_e4b2df93","line":93,"in_reply_to":"3a29b11f_1148975a","updated":"2015-10-21 06:10:43.000000000","message":"The exception, which is raised by guestfs, only contain following sentence:\n\"RuntimeError: /usr/bin/supermin-helper exited with error status 1.\nTo see full error messages you may need to enable debugging.\nSee http://libguestfs.org/guestfs-faq.1.html#debugging-libguestfs\"\nBut guestfs had offer some function to enable trace and verbose. However real error message still not contained in exception message. Unless we handle each sentence which return by guestfs. But it will display too many unnecessary information. Therefore I though this patch only check whether libguestfs is failed because of kernel is unreadable.","commit_id":"6cb6cfc7854f5ccb0e0948242169f03a2fad99fc"},{"author":{"_account_id":14131,"name":"shaohef","email":"shaohe.feng@intel.com","username":"shaohefeng"},"change_message_id":"c1e8772a052079edbad3a98f7a1f125fa971e153","unresolved":false,"context_lines":[{"line_number":90,"context_line":"                LOG.warning(_LW(\"libguestfs needs read permission for \""},{"line_number":91,"context_line":"                                \"host kernel.\"))"},{"line_number":92,"context_line":"            raise exception.NovaException("},{"line_number":93,"context_line":"                _(\"libguestfs installed but not usable (%s)\") % e)"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"        return self"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_1148975a","line":93,"in_reply_to":"3a29b11f_d6c0d5e2","updated":"2015-10-20 15:17:36.000000000","message":"after:\n  export LIBGUESTFS_DEBUG\u003d1 LIBGUESTFS_TRACE\u003d1\n\nI have check the further information\nsupermin: kernel: picked kernel vmlinuz-3.19.0-21-generic\ncp: cannot open \u0027/boot/vmlinuz-3.19.0-21-generic\u0027 for reading: Permission denied\nsupermin: cp -p \u0027/boot/vmlinuz-3.19.0-21-generic\u0027 \u0027/var/tmp/.guestfs-1000/appliance.d.olhcqbb9/kernel\u0027: command failed, see earlier errors\nlibguestfs: trace: launch \u003d -1 (error)","commit_id":"6cb6cfc7854f5ccb0e0948242169f03a2fad99fc"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"09068a7f5d80cecd7555b0b091cdfae2f879c278","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            g.add_drive(\"/dev/null\")  # sic"},{"line_number":87,"context_line":"            g.launch()"},{"line_number":88,"context_line":"        except Exception as e:"},{"line_number":89,"context_line":"            if os.access(\"/boot/vmlinuz-%s\" % os.uname()[2], os.R_OK):"},{"line_number":90,"context_line":"                LOG.warning(_LW(\"libguestfs needs read permission for \""},{"line_number":91,"context_line":"                                \"host kernel.\"))"},{"line_number":92,"context_line":"            raise exception.NovaException("}],"source_content_type":"text/x-python","patch_set":4,"id":"9a8ffd7b_89228d00","line":89,"updated":"2015-11-30 14:35:29.000000000","message":"can we do this with a more specific exception?","commit_id":"7a6c289a271bfaff0412c65efdcba266c1a13bcc"},{"author":{"_account_id":14447,"name":"lyanchih","email":"lyan.h@inwinstack.com","username":"lyanchih"},"change_message_id":"fc17f4687c4bcb2eed49f5d562d7041c0fe6c986","unresolved":false,"context_lines":[{"line_number":86,"context_line":"            g.add_drive(\"/dev/null\")  # sic"},{"line_number":87,"context_line":"            g.launch()"},{"line_number":88,"context_line":"        except Exception as e:"},{"line_number":89,"context_line":"            if os.access(\"/boot/vmlinuz-%s\" % os.uname()[2], os.R_OK):"},{"line_number":90,"context_line":"                LOG.warning(_LW(\"libguestfs needs read permission for \""},{"line_number":91,"context_line":"                                \"host kernel.\"))"},{"line_number":92,"context_line":"            raise exception.NovaException("}],"source_content_type":"text/x-python","patch_set":4,"id":"7a740942_9d17fa53","line":89,"in_reply_to":"9a8ffd7b_89228d00","updated":"2015-12-10 09:31:50.000000000","message":"Done","commit_id":"7a6c289a271bfaff0412c65efdcba266c1a13bcc"}]}