)]}'
{"nova/virt/hyperv/driver.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"880ef03be847f7dff1d093282cddea4d9796bc5d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            # the version is Windows Server 2008 R2. Log a warning, letting"},{"line_number":62,"context_line":"            # users know that this version is deprecated in Liberty."},{"line_number":63,"context_line":"            LOG.warning("},{"line_number":64,"context_line":"                _LW(\u0027You are running nova-compute on Windows / Hyper-V Server \u0027"},{"line_number":65,"context_line":"                    \u00272008 R2. This version of Windows is deprecated in the \u0027"},{"line_number":66,"context_line":"                    \u0027current version of OpenStack and the support for it will \u0027"},{"line_number":67,"context_line":"                    \u0027be removed in the next cycle.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_7ae8e9b4","side":"PARENT","line":64,"updated":"2015-11-10 10:57:42.000000000","message":"Should we not now Log an Error if the version is too old?","commit_id":"2f2dc90219c8489059637c6329f2ae76ab22d271"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ba9925a4fe28f221f5a88cf6d06c2f06d84e035f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            # the version is Windows Server 2008 R2. Log a warning, letting"},{"line_number":62,"context_line":"            # users know that this version is deprecated in Liberty."},{"line_number":63,"context_line":"            LOG.warning("},{"line_number":64,"context_line":"                _LW(\u0027You are running nova-compute on Windows / Hyper-V Server \u0027"},{"line_number":65,"context_line":"                    \u00272008 R2. This version of Windows is deprecated in the \u0027"},{"line_number":66,"context_line":"                    \u0027current version of OpenStack and the support for it will \u0027"},{"line_number":67,"context_line":"                    \u0027be removed in the next cycle.\u0027))"}],"source_content_type":"text/x-python","patch_set":2,"id":"da85f559_ceaef684","side":"PARENT","line":64,"in_reply_to":"da85f559_7ae8e9b4","updated":"2015-11-10 11:17:35.000000000","message":"Hm, yeah, that might be a good idea.","commit_id":"2f2dc90219c8489059637c6329f2ae76ab22d271"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"2768ac899cdd4f1787bda48e29ed5cc97814473c","unresolved":false,"context_lines":[{"line_number":50,"context_line":"        if not hostutils.HostUtils().check_min_windows_version(6, 2):"},{"line_number":51,"context_line":"            # the version is Windows Server 2008 R2. Log a warning, letting"},{"line_number":52,"context_line":"            # users know that this version is deprecated in Liberty."},{"line_number":53,"context_line":"            LOG.error(_LE(\u0027You are running nova-compute on Windows / Hyper-V \u0027"},{"line_number":54,"context_line":"                          \u0027Server 2008 R2. The support for this version of \u0027"},{"line_number":55,"context_line":"                          \u0027Windows has been deprecated in Liberty and is no \u0027"},{"line_number":56,"context_line":"                          \u0027longer supported in Mitaka.\u0027))"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_e4519bd9","line":53,"updated":"2015-11-10 11:51:54.000000000","message":"You should raise an exception here instead of simply logging the error, in which case the driver should remain uninitialized.","commit_id":"dfbbe48b2cb1a664d837867f1767b8b74444b875"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"ed0d587333fc61c9ed776c2c576378a3eb121db3","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                          \u0027Server 2008 R2. The support for this version of \u0027"},{"line_number":73,"context_line":"                          \u0027Windows has been deprecated in Liberty and is no \u0027"},{"line_number":74,"context_line":"                          \u0027longer supported in Mitaka.\u0027))"},{"line_number":75,"context_line":"            raise exception.ServiceTooOld(thisver\u003dwin_version, minver\u003d6002)"},{"line_number":76,"context_line":""},{"line_number":77,"context_line":"    def init_host(self, host):"},{"line_number":78,"context_line":"        self._vmops.restart_vm_log_writers()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_d87ac523","line":75,"updated":"2015-11-12 11:32:30.000000000","message":"I\u0027m not sure if this is the right exception to throw. It might be misleading, as we actually care about the Hyper-V version here. I think it would be better to just throw an HyperVException.","commit_id":"250897f617450ec648a5ef1e0dd741abeadc4396"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"6760ef424e46edf5eaef9990dd9aa75ffe4296c6","unresolved":false,"context_lines":[{"line_number":62,"context_line":"        self._rdpconsoleops \u003d rdpconsoleops.RDPConsoleOps()"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    def _check_minimum_windows_version(self):"},{"line_number":65,"context_line":"          if not hostutils.HostUtils().check_min_windows_version(6, 2):"},{"line_number":66,"context_line":"              # the version is Windows Server 2008 R2. Log an error, letting"},{"line_number":67,"context_line":"              # users know that this version is not supported any longer."},{"line_number":68,"context_line":"              err_msg \u003d _(\u0027You are running nova-compute on Windows / Hyper-V \u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_d4cfe926","line":65,"updated":"2015-11-12 13:44:12.000000000","message":"Indentation is off here. Pep8 will complain about that.","commit_id":"bc37d1c2765fe6bb13c383d5f4d890632ff254ae"},{"author":{"_account_id":8543,"name":"Lucian Petrut","email":"lpetrut@cloudbasesolutions.com","username":"plucian"},"change_message_id":"55f5aac92b5aef88070c257df167b145ade329a0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"            # the version is Windows Server 2008 R2. Log an error, letting"},{"line_number":67,"context_line":"            # users know that this version is not supported any longer."},{"line_number":68,"context_line":"            err_msg \u003d _(\u0027You are running nova-compute on Windows / Hyper-V \u0027"},{"line_number":69,"context_line":"                        \u0027Server 2008 R2. The support for this version of \u0027"},{"line_number":70,"context_line":"                        \u0027Windows has been deprecated in Liberty and is no \u0027"},{"line_number":71,"context_line":"                        \u0027longer supported in Mitaka.\u0027)"},{"line_number":72,"context_line":"            LOG.error(err_msg)"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_297ff3e0","line":69,"updated":"2015-11-12 15:33:11.000000000","message":"Well, if the kernel version is older than 6.2, it doesn\u0027t mean that WS 2008 R2 is the actual OS version. If you end up sending another patch, please fix this.","commit_id":"a28ad4b3b5ce1d8f7859523f4fbfa7019a90c480"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"ec78961af6f0db91c8abb2eb879ab86c7c2ffe76","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # the version is of Windows is older than Windows Server 2012 R2."},{"line_number":66,"context_line":"            # Log an error, lettingusers know that this version is not"},{"line_number":67,"context_line":"            # supported any longer."},{"line_number":68,"context_line":"            err_msg \u003d _(\u0027You are running nova-compute on an unsupported \u0027"},{"line_number":69,"context_line":"                        \u0027version of Windows (older than Windows / Hyper-V \u0027"},{"line_number":70,"context_line":"                        \u0027Server 2012). The support for this version of \u0027"},{"line_number":71,"context_line":"                        \u0027Windows has been deprecated in Liberty and has been \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_bb8c4e80","line":68,"updated":"2015-11-13 15:26:34.000000000","message":"Nit: I think that should be _LE","commit_id":"846a07be4c5e214deb5a25c81aae5c336227108f"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae915062535586e32337f0719a32f17ee5685e9a","unresolved":false,"context_lines":[{"line_number":65,"context_line":"            # the version is of Windows is older than Windows Server 2012 R2."},{"line_number":66,"context_line":"            # Log an error, lettingusers know that this version is not"},{"line_number":67,"context_line":"            # supported any longer."},{"line_number":68,"context_line":"            err_msg \u003d _(\u0027You are running nova-compute on an unsupported \u0027"},{"line_number":69,"context_line":"                        \u0027version of Windows (older than Windows / Hyper-V \u0027"},{"line_number":70,"context_line":"                        \u0027Server 2012). The support for this version of \u0027"},{"line_number":71,"context_line":"                        \u0027Windows has been deprecated in Liberty and has been \u0027"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_3bb85ee5","line":68,"in_reply_to":"da85f559_bb8c4e80","updated":"2015-11-13 15:33:51.000000000","message":"Done","commit_id":"846a07be4c5e214deb5a25c81aae5c336227108f"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"a8f0f4a8128ce06fd6f878ee33d8432f09b8d3bb","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            err_msg \u003d _(\u0027You are running nova-compute on an unsupported \u0027"},{"line_number":69,"context_line":"                        \u0027version of Windows (older than Windows / Hyper-V \u0027"},{"line_number":70,"context_line":"                        \u0027Server 2012). The support for this version of \u0027"},{"line_number":71,"context_line":"                        \u0027Windows has been deprecated in Liberty and has been \u0027"},{"line_number":72,"context_line":"                        \u0027removed in Mitaka.\u0027)"},{"line_number":73,"context_line":"            LOG.error(err_msg)"},{"line_number":74,"context_line":"            raise vmutils.HyperVException(err_msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_1bc9daac","line":71,"updated":"2015-11-13 15:27:52.000000000","message":"Maybe we just say it was dropped in mitaka? no need to mention deprecated.","commit_id":"846a07be4c5e214deb5a25c81aae5c336227108f"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ae915062535586e32337f0719a32f17ee5685e9a","unresolved":false,"context_lines":[{"line_number":68,"context_line":"            err_msg \u003d _(\u0027You are running nova-compute on an unsupported \u0027"},{"line_number":69,"context_line":"                        \u0027version of Windows (older than Windows / Hyper-V \u0027"},{"line_number":70,"context_line":"                        \u0027Server 2012). The support for this version of \u0027"},{"line_number":71,"context_line":"                        \u0027Windows has been deprecated in Liberty and has been \u0027"},{"line_number":72,"context_line":"                        \u0027removed in Mitaka.\u0027)"},{"line_number":73,"context_line":"            LOG.error(err_msg)"},{"line_number":74,"context_line":"            raise vmutils.HyperVException(err_msg)"}],"source_content_type":"text/x-python","patch_set":10,"id":"da85f559_dbcd9287","line":71,"in_reply_to":"da85f559_1bc9daac","updated":"2015-11-13 15:33:51.000000000","message":"Done","commit_id":"846a07be4c5e214deb5a25c81aae5c336227108f"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"95ac38bcf9d93bc3300d776c9460c55d84cf68de","unresolved":false,"context_lines":[{"line_number":63,"context_line":"    def _check_minimum_windows_version(self):"},{"line_number":64,"context_line":"        if not hostutils.HostUtils().check_min_windows_version(6, 2):"},{"line_number":65,"context_line":"            # the version is of Windows is older than Windows Server 2012 R2."},{"line_number":66,"context_line":"            # Log an error, lettingusers know that this version is not"},{"line_number":67,"context_line":"            # supported any longer."},{"line_number":68,"context_line":"            err_msg \u003d _LE(\u0027You are running nova-compute on an unsupported \u0027"},{"line_number":69,"context_line":"                          \u0027version of Windows (older than Windows / Hyper-V \u0027"}],"source_content_type":"text/x-python","patch_set":11,"id":"ba8a016a_78358344","line":66,"updated":"2015-11-17 05:09:38.000000000","message":"OMG, you need a space between two words here! (nit)","commit_id":"b81e7a322d524424e0ad4b064e2532202de52f6f"}]}