)]}'
{"nova/tests/unit/virt/libvirt/test_host.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"152451dea8cae5abcf3405e253548bb40aec288d","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            mock_conn().getInfo.return_value \u003d ["},{"line_number":782,"context_line":"                arch.X86_64, 15814, 8, 1208, 1, 1, 4, 2]"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"            self.assertEqual(6865, self.host.get_memory_mb_used())"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    def test_get_memory_used_xen(self):"},{"line_number":787,"context_line":"        self.flags(virt_type\u003d\u0027xen\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_fe7faadd","line":784,"updated":"2015-10-21 16:49:11.000000000","message":"Why has this changed?","commit_id":"fecd9ff15653af8e65084c77b9e5efb9c6b3179a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"aab85d886c9c2afa32885671093052064222585b","unresolved":false,"context_lines":[{"line_number":781,"context_line":"            mock_conn().getInfo.return_value \u003d ["},{"line_number":782,"context_line":"                arch.X86_64, 15814, 8, 1208, 1, 1, 4, 2]"},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"            self.assertEqual(6865, self.host.get_memory_mb_used())"},{"line_number":785,"context_line":""},{"line_number":786,"context_line":"    def test_get_memory_used_xen(self):"},{"line_number":787,"context_line":"        self.flags(virt_type\u003d\u0027xen\u0027, group\u003d\u0027libvirt\u0027)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_a9fa5773","line":784,"in_reply_to":"3a29b11f_fe7faadd","updated":"2015-10-21 20:02:13.000000000","message":"my bad. sorry.","commit_id":"fecd9ff15653af8e65084c77b9e5efb9c6b3179a"}],"nova/virt/libvirt/host.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"06322d7db610f166754d706f16105304b50318b3","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            event \u003d args[0]"},{"line_number":391,"context_line":"            self._events_delayed.pop(event.uuid, None)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        # Cleanup possible delayed stop events."},{"line_number":394,"context_line":"        if event.uuid in self._events_delayed.keys():"},{"line_number":395,"context_line":"            self._events_delayed[event.uuid].cancel()"},{"line_number":396,"context_line":"            self._events_delayed.pop(event.uuid, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_79f894c3","line":393,"updated":"2015-10-21 17:02:37.000000000","message":"2to3 reports that this should be fixed like so (or using six libraries to maintain backwards compatibility). Does this need to be fixed?\n\n    -        if event.uuid in self._events_delayed.keys():\n    +        if event.uuid in list(self._events_delayed.keys()):","commit_id":"fecd9ff15653af8e65084c77b9e5efb9c6b3179a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"69ec822fdda6484b2a884d46851ffe55f1ba603e","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            event \u003d args[0]"},{"line_number":391,"context_line":"            self._events_delayed.pop(event.uuid, None)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        # Cleanup possible delayed stop events."},{"line_number":394,"context_line":"        if event.uuid in self._events_delayed.keys():"},{"line_number":395,"context_line":"            self._events_delayed[event.uuid].cancel()"},{"line_number":396,"context_line":"            self._events_delayed.pop(event.uuid, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_a96fb729","line":393,"in_reply_to":"3a29b11f_69475fbc","updated":"2015-10-21 20:04:20.000000000","message":"Ok.","commit_id":"fecd9ff15653af8e65084c77b9e5efb9c6b3179a"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"aab85d886c9c2afa32885671093052064222585b","unresolved":false,"context_lines":[{"line_number":390,"context_line":"            event \u003d args[0]"},{"line_number":391,"context_line":"            self._events_delayed.pop(event.uuid, None)"},{"line_number":392,"context_line":""},{"line_number":393,"context_line":"        # Cleanup possible delayed stop events."},{"line_number":394,"context_line":"        if event.uuid in self._events_delayed.keys():"},{"line_number":395,"context_line":"            self._events_delayed[event.uuid].cancel()"},{"line_number":396,"context_line":"            self._events_delayed.pop(event.uuid, None)"}],"source_content_type":"text/x-python","patch_set":1,"id":"3a29b11f_69475fbc","line":393,"in_reply_to":"3a29b11f_79f894c3","updated":"2015-10-21 20:02:13.000000000","message":"it is not useful in all cases. Doing this will cause the keys list be parsed at most twice, instead of at most once.\n\nas for transforming .keys() into lists is already done here: https://review.openstack.org/#/c/232585/","commit_id":"fecd9ff15653af8e65084c77b9e5efb9c6b3179a"}]}