)]}'
{"nova/objectstore/s3server.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"c8f748f3cdd144c23185f341ed3e98f32b420034","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a26ad4f_1155404f","line":204,"updated":"2015-10-28 09:14:01.000000000","message":"Why bool was also added?","commit_id":"da7d31c49c73fac59c3a464afc2300233a372bc7"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"09aa72a4a0bd128df6bef2276bc572bcc0c72516","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"da85f559_05d8661c","line":204,"updated":"2015-11-10 08:46:38.000000000","message":"why bool was added?","commit_id":"838509eb8eb9b6772b9091fe4e30dd91794d16ba"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"ec55616e154d840446b6833f886d5725a7024593","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":7,"id":"ba8a016a_d59ae66d","line":204,"in_reply_to":"da85f559_05d8661c","updated":"2015-11-18 12:21:50.000000000","message":"Yeah, the previous Jenkins runs failed because this branch did not exist. Apparenly, this works in python 2.7:\n\n    \u003e\u003e\u003e value \u003d True\n    \u003e\u003e\u003e isinstance(value, int)\n    True\n\nAnd the same code is False in python 3.4. Some values are boolean.","commit_id":"838509eb8eb9b6772b9091fe4e30dd91794d16ba"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"8ce6a9e31fc44976a8d053a60b56e50e12583ec8","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a8ffd7b_bb491c33","line":204,"updated":"2015-12-03 09:03:01.000000000","message":"I don\u0027t understand why this new elif is necessary. I\u0027m sure I\u0027m missing some basic python skills here, would be cool if you could explain it to me.","commit_id":"dd395a492c5d3e548097693a75c0551628d61736"},{"author":{"_account_id":11303,"name":"Markus Zoeller (markus_z)","email":"mzoeller@linux.vnet.ibm.com","username":"mzoeller"},"change_message_id":"04e96beb073dfdf7aff1840ef92fe31620e5b78b","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a740942_be307702","line":204,"in_reply_to":"7a740942_d6f20dd2","updated":"2015-12-07 06:56:54.000000000","message":"Woops, sorry, I forgot to read the history. Thanks for explaining it again.","commit_id":"dd395a492c5d3e548097693a75c0551628d61736"},{"author":{"_account_id":8213,"name":"Claudiu Belu","email":"cbelu@cloudbasesolutions.com","username":"claudiub"},"change_message_id":"8a2afd523758d205d268efc51133fb4196f6b83c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            parts.append(utils.xhtml_escape(value))"},{"line_number":202,"context_line":"        elif type(value) in six.integer_types:"},{"line_number":203,"context_line":"            parts.append(str(value))"},{"line_number":204,"context_line":"        elif isinstance(value, bool):"},{"line_number":205,"context_line":"            parts.append(str(value))"},{"line_number":206,"context_line":"        elif isinstance(value, datetime.datetime):"},{"line_number":207,"context_line":"            parts.append(value.strftime(\"%Y-%m-%dT%H:%M:%S.000Z\"))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a740942_d6f20dd2","line":204,"in_reply_to":"9a8ffd7b_bb491c33","updated":"2015-12-07 04:05:46.000000000","message":"Yeah, I\u0027ve already explained this is PS7. Copy-paste response:\n\nYeah, the previous Jenkins runs failed because this branch did not exist. Apparenly, this works in python 2.7:\n\n    \u003e\u003e\u003e value \u003d True\n    \u003e\u003e\u003e isinstance(value, int)\n    True\n\nAnd the same code is False in python 3.4. Some values (passed to this method) are boolean, which caused unit tests to fail.","commit_id":"dd395a492c5d3e548097693a75c0551628d61736"}]}