)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"5ba7d701d5a869364fafed695d6b8e200919eac9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix access_ip_* race"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The code currently sets access_ip_* in a 2nd DB call after an instance"},{"line_number":10,"context_line":"goes ACTIVE, which means there\u0027s a slight race when someone is querying the API for their instance.  It\u0027s possible to see the instance ACTIVE but"},{"line_number":11,"context_line":"access_ip_* will be blank."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"To fix this, we should set access_ip_* at the same time the instance goes"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F4Lc%3D","line":10,"updated":"2013-03-07 21:46:55.000000000","message":"Looks like you\u0027re missing a newline here :)","commit_id":"d85a23832e7535661147ec129455e34702fbc9a0"}],"nova/compute/manager.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"03dbc2b546e5a83ee0d6cc225af83930e6a80773","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                           task_state\u003dNone,"},{"line_number":1051,"context_line":"                           expected_task_state\u003dtask_states.SPAWNING,"},{"line_number":1052,"context_line":"                           launched_at\u003dtimeutils.utcnow())"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        def _set_access_ip_values():"},{"line_number":1055,"context_line":"            \"\"\"Add access ip values for a given instance."},{"line_number":1056,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4Kg%3D","line":1053,"updated":"2013-03-07 21:55:40.000000000","message":"style-wise I\u0027m more partial to:\n\nif set_access_ip:\n   access_ips \u003d self._get_access_ips(nw_info)\n   update_data.update(access_ips)\n\nbut really that\u0027s just nit picking. :)","commit_id":"6a080df6bd8817019d204e3142a236b7974f7656"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"2189dd7b80388f386854770619141c565a8fd64b","unresolved":false,"context_lines":[{"line_number":1050,"context_line":"                           task_state\u003dNone,"},{"line_number":1051,"context_line":"                           expected_task_state\u003dtask_states.SPAWNING,"},{"line_number":1052,"context_line":"                           launched_at\u003dtimeutils.utcnow())"},{"line_number":1053,"context_line":""},{"line_number":1054,"context_line":"        def _set_access_ip_values():"},{"line_number":1055,"context_line":"            \"\"\"Add access ip values for a given instance."},{"line_number":1056,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4B4%3D","line":1053,"in_reply_to":"AAAAN3%2F%2F4Kg%3D","updated":"2013-03-07 22:54:18.000000000","message":"I started down that road and decided I didn\u0027t like it as well.  I was having a hard time deciding if I should return a dict with both access_ip_* keys in it... even if one could be None.  I didn\u0027t want to update the DB if one was None... so that meant it would be easier to return a dict only with the things that should be changed... but that still seemed weird to me!  So I said screw it... I\u0027ll just do it this way :)","commit_id":"6a080df6bd8817019d204e3142a236b7974f7656"}]}