)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"624df9d7af39a83600de3a0a6ddf76b582b72db8","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            return function(self, context, instance_uuid, *args, **kwargs)"},{"line_number":132,"context_line":"        except Exception, e:"},{"line_number":133,"context_line":"            with utils.save_and_reraise_exception():"},{"line_number":134,"context_line":"                self.add_instance_fault_from_exc(context, instance_uuid, e)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    return decorated_function"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8dg%3D","line":134,"updated":"2011-12-15 20:30:48.000000000","message":"Probably shouldn\u0027t add a fault for the instance_uuid if the exception is an InstanceNotFound ?","commit_id":"5670ba11d037daa8f8fa7b0620429faec47a17ee"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"0eab2cd7d3af9e33328d5f06299c0af1a526c822","unresolved":false,"context_lines":[{"line_number":131,"context_line":"            return function(self, context, instance_uuid, *args, **kwargs)"},{"line_number":132,"context_line":"        except Exception, e:"},{"line_number":133,"context_line":"            with utils.save_and_reraise_exception():"},{"line_number":134,"context_line":"                self.add_instance_fault_from_exc(context, instance_uuid, e)"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    return decorated_function"},{"line_number":137,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8dQ%3D","line":134,"in_reply_to":"AAAAC3%2F%2F8dg%3D","updated":"2011-12-15 20:55:23.000000000","message":"The instance_uuid field in the instance_faults table is a foreign key to instances.uuid. So from my understanding, this would error but the original exception is saved and would be returned. However I didn\u0027t even think about this until now.\n\nThis should work as is but perhaps we should explicitly catch InstanceNotFound exceptions and not do this.","commit_id":"5670ba11d037daa8f8fa7b0620429faec47a17ee"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"624df9d7af39a83600de3a0a6ddf76b582b72db8","unresolved":false,"context_lines":[{"line_number":927,"context_line":"                                              instance_id,"},{"line_number":928,"context_line":"                                              task_state\u003dNone,"},{"line_number":929,"context_line":"                                              vm_state\u003dvm_states.ERROR)"},{"line_number":930,"context_line":"                        raise e"},{"line_number":931,"context_line":"                    time.sleep(1)"},{"line_number":932,"context_line":"                    continue"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8dk%3D","line":930,"updated":"2011-12-15 20:30:48.000000000","message":"See the comment above the _instance_update(). It appears the new exception was raised for a reason, but I\u0027m not sure if it\u0027s valid.  Should research.  If it\u0027s not valid, the comment should be removed.","commit_id":"5670ba11d037daa8f8fa7b0620429faec47a17ee"},{"author":{"_account_id":177,"name":"Alex Meade","email":"mr.alex.meade@gmail.com","username":"alex-meade"},"change_message_id":"0eab2cd7d3af9e33328d5f06299c0af1a526c822","unresolved":false,"context_lines":[{"line_number":927,"context_line":"                                              instance_id,"},{"line_number":928,"context_line":"                                              task_state\u003dNone,"},{"line_number":929,"context_line":"                                              vm_state\u003dvm_states.ERROR)"},{"line_number":930,"context_line":"                        raise e"},{"line_number":931,"context_line":"                    time.sleep(1)"},{"line_number":932,"context_line":"                    continue"},{"line_number":933,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8dU%3D","line":930,"in_reply_to":"AAAAC3%2F%2F8dk%3D","updated":"2011-12-15 20:55:23.000000000","message":"Working on this, good catch. I think the intention here is not to give away any potential password information. I will at least add a better exception to generate from this.","commit_id":"5670ba11d037daa8f8fa7b0620429faec47a17ee"}]}