)]}'
{"nova/api/ec2/cloud.py":[{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"4d007dfa930f41d8385fe359d0ebfc473f0eb450","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"        try:"},{"line_number":1088,"context_line":"            instance_type \u003d instance_types.extract_instance_type(instance)"},{"line_number":1089,"context_line":"            type_name \u003d instance_type[\u0027name\u0027]"},{"line_number":1090,"context_line":"        except Exception:"},{"line_number":1091,"context_line":"            type_name \u003d None"},{"line_number":1092,"context_line":"        result[\u0027instanceType\u0027] \u003d type_name"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4FE%3D","line":1090,"updated":"2013-03-07 22:31:33.000000000","message":"I\u0027m always skeptical when exceptions this wide are caught and then never logged. Literally anything could be silently ignored, even very legitimate bugs.\n\nCan this be narrowed down?","commit_id":"82fd58d252d674f8f4ed9dd0835b6356fb49d34b"},{"author":{"_account_id":100,"name":"Johannes Erdfelt","email":"johannes@erdfelt.com","username":"johannes.erdfelt"},"change_message_id":"74f4825e0e33cc53b430cd1d79c79d6463082965","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"        try:"},{"line_number":1088,"context_line":"            instance_type \u003d instance_types.extract_instance_type(instance)"},{"line_number":1089,"context_line":"            type_name \u003d instance_type[\u0027name\u0027]"},{"line_number":1090,"context_line":"        except Exception:"},{"line_number":1091,"context_line":"            type_name \u003d None"},{"line_number":1092,"context_line":"        result[\u0027instanceType\u0027] \u003d type_name"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4CA%3D","line":1090,"in_reply_to":"AAAAN3%2F%2F4Ec%3D","updated":"2013-03-07 22:53:26.000000000","message":"I think it can be removed. If the instance doesn\u0027t have an instance_type then there is something wrong and should fail! :)","commit_id":"82fd58d252d674f8f4ed9dd0835b6356fb49d34b"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"f63e57535f8bb1de226d7e7a89370c89a55dc05f","unresolved":false,"context_lines":[{"line_number":1087,"context_line":"        try:"},{"line_number":1088,"context_line":"            instance_type \u003d instance_types.extract_instance_type(instance)"},{"line_number":1089,"context_line":"            type_name \u003d instance_type[\u0027name\u0027]"},{"line_number":1090,"context_line":"        except Exception:"},{"line_number":1091,"context_line":"            type_name \u003d None"},{"line_number":1092,"context_line":"        result[\u0027instanceType\u0027] \u003d type_name"},{"line_number":1093,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAN3%2F%2F4Ec%3D","line":1090,"in_reply_to":"AAAAN3%2F%2F4FE%3D","updated":"2013-03-07 22:41:42.000000000","message":"As you should be :)\n\nHonestly, I was trying to replicate the behavior of the old code, which seems to account for the fact that instance can *ever* not have an instance_type inside. I think I can actually remove the try entirely and be fine here. What do you think?","commit_id":"82fd58d252d674f8f4ed9dd0835b6356fb49d34b"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"bb47814851af1306dbcd10d82d1320e53582a72d","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"    @staticmethod"},{"line_number":1086,"context_line":"    def _format_instance_type(instance, result):"},{"line_number":1087,"context_line":"        instance_type \u003d instance_types.extract_instance_type(instance)"},{"line_number":1088,"context_line":"        result[\u0027instanceType\u0027] \u003d instance_type[\u0027name\u0027]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    @staticmethod"},{"line_number":1091,"context_line":"    def _format_group_set(instance, result):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F3Pc%3D","line":1088,"updated":"2013-03-08 11:57:15.000000000","message":"Noting the behaviour change here, but it looks reasonable","commit_id":"f81ba052b1cb93eb72bda6a5e5f31d4f3ba49201"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"68bc4fcf89086b5c0755def0c2401348800c7a17","unresolved":false,"context_lines":[{"line_number":1085,"context_line":"    @staticmethod"},{"line_number":1086,"context_line":"    def _format_instance_type(instance, result):"},{"line_number":1087,"context_line":"        instance_type \u003d instance_types.extract_instance_type(instance)"},{"line_number":1088,"context_line":"        result[\u0027instanceType\u0027] \u003d instance_type[\u0027name\u0027]"},{"line_number":1089,"context_line":""},{"line_number":1090,"context_line":"    @staticmethod"},{"line_number":1091,"context_line":"    def _format_group_set(instance, result):"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2F3GQ%3D","line":1088,"in_reply_to":"AAAAN3%2F%2F3Pc%3D","updated":"2013-03-08 14:50:28.000000000","message":"Yeah, Johannes and I already talked about it. I started with replicating the behavior, which he red-flagged. I fixed, and found and fixed other tests that it was covering up :)","commit_id":"f81ba052b1cb93eb72bda6a5e5f31d4f3ba49201"}]}