)]}'
{"bin/nova-all":[{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"31ae6e86dff3fc9e27946b608e51c3adcdf84d8a","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"CONF \u003d cfg.CONF"},{"line_number":53,"context_line":"CONF.import_opt(\u0027enabled_apis\u0027, \u0027nova.service\u0027)"},{"line_number":54,"context_line":"LOG \u003d logging.getLogger(\u0027nova.all\u0027)"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"if __name__ \u003d\u003d \u0027__main__\u0027:"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2us%3D","line":53,"updated":"2013-03-08 19:02:01.000000000","message":"Example of import","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"436214254bfe184010e793268c18e991ce521746","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # FIXME(sirp): Most service configs are defined in nova/service.py, but"},{"line_number":80,"context_line":"        # conductor has set a new precedent of storing these configs"},{"line_number":81,"context_line":"        # nova/\u003cservice\u003e/api.py."},{"line_number":82,"context_line":"        #"},{"line_number":83,"context_line":"        # We should update the existing services to use this new approach so we"},{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2m4%3D","line":81,"updated":"2013-03-08 19:42:12.000000000","message":"Can\u0027t we move all services to this model too, then?","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"30ed24ce1c535aaddbba15840a90a76641e8363b","unresolved":false,"context_lines":[{"line_number":78,"context_line":""},{"line_number":79,"context_line":"        # FIXME(sirp): Most service configs are defined in nova/service.py, but"},{"line_number":80,"context_line":"        # conductor has set a new precedent of storing these configs"},{"line_number":81,"context_line":"        # nova/\u003cservice\u003e/api.py."},{"line_number":82,"context_line":"        #"},{"line_number":83,"context_line":"        # We should update the existing services to use this new approach so we"},{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2lQ%3D","line":81,"in_reply_to":"AAAAN3%2F%2F2m4%3D","updated":"2013-03-08 19:51:42.000000000","message":"Yeah something we should do soon, but IMHO should be its own patch.","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"cf2721b990117a014ac75690aeea39f49bc60f61","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F39M%3D","line":87,"updated":"2013-03-07 23:44:01.000000000","message":"These actually work?  I wouldn\u0027t have thought those config options to have been declared yet (and they\u0027re not imported above).","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"30ed24ce1c535aaddbba15840a90a76641e8363b","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2lI%3D","line":87,"in_reply_to":"AAAAN3%2F%2F2m0%3D","updated":"2013-03-08 19:51:42.000000000","message":"Just pushed a new patch which fixes this.","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"364eccdb950e32ec3d44cc1ed8b5fffc2b4a588d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2tQ%3D","line":87,"in_reply_to":"AAAAN3%2F%2F2uw%3D","updated":"2013-03-08 19:06:48.000000000","message":"Sounds like a good idea to me!","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":1247,"name":"Mark McLoughlin","email":"markmc@redhat.com","username":"markmc"},"change_message_id":"436214254bfe184010e793268c18e991ce521746","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2m0%3D","line":87,"in_reply_to":"AAAAN3%2F%2F2uw%3D","updated":"2013-03-08 19:42:12.000000000","message":"Yep, we should be doing import_opt","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"7aae37048233b422ca29295ab5d60cb5eec2374d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F3uA%3D","line":87,"in_reply_to":"AAAAN3%2F%2F39A%3D","updated":"2013-03-08 03:12:16.000000000","message":"Ah.  I did not expect service to have imported conductor!  Ok.","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":475,"name":"Rick Harris","email":"rick.harris@rackspace.com","username":"rconradharris"},"change_message_id":"9f3e04927bdb3fa135cec4b28d645c76ca9da989","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F39A%3D","line":87,"in_reply_to":"AAAAN3%2F%2F39M%3D","updated":"2013-03-07 23:52:42.000000000","message":"Seems to work. I believe it works b/c:\n\nnova-all imports service\nservice imports conductor\nconductor imports conductor.api\nconductor.api defines CONF.conductor.*","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"},{"author":{"_account_id":1849,"name":"Joe Gordon","email":"joe.gordon0@gmail.com","username":"jogo"},"change_message_id":"31ae6e86dff3fc9e27946b608e51c3adcdf84d8a","unresolved":false,"context_lines":[{"line_number":84,"context_line":"        # don\u0027t have to treat conductor differently here."},{"line_number":85,"context_line":"        if binary \u003d\u003d \u0027nova-conductor\u0027:"},{"line_number":86,"context_line":"            topic \u003d CONF.conductor.topic"},{"line_number":87,"context_line":"            manager \u003d CONF.conductor.manager"},{"line_number":88,"context_line":"        else:"},{"line_number":89,"context_line":"            topic \u003d None"},{"line_number":90,"context_line":"            manager \u003d None"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"AAAAN3%2F%2F2uw%3D","line":87,"in_reply_to":"AAAAN3%2F%2F3uA%3D","updated":"2013-03-08 19:02:01.000000000","message":"I thought we were going down the patch of explicitly importing  options.","commit_id":"7c5faa6d1b0ae9a0528cfc37be2b1478507b1964"}]}