)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update networkinfo cache to include vif_type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vif_type is a new param in legacy_nw_info added at grizzly,  and when upgrade"},{"line_number":10,"context_line":"from folsom to grizzly, the existed instances\u0027s network info cache in the db doesn\u0027t"},{"line_number":11,"context_line":"contain this param, which is needed by vif driver to plug vif to instance."},{"line_number":12,"context_line":"nova-compute ensure vif is pluged to instance when starts. so we need to update"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2F2rk%3D","line":9,"updated":"2013-03-08 19:21:45.000000000","message":"s/at/in/\ns/  / /\ns/upgrade/upgrading/","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Update networkinfo cache to include vif_type."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"vif_type is a new param in legacy_nw_info added at grizzly,  and when upgrade"},{"line_number":10,"context_line":"from folsom to grizzly, the existed instances\u0027s network info cache in the db doesn\u0027t"},{"line_number":11,"context_line":"contain this param, which is needed by vif driver to plug vif to instance."},{"line_number":12,"context_line":"nova-compute ensure vif is pluged to instance when starts. so we need to update"},{"line_number":13,"context_line":"the existed instance\u0027s network info cache before pluging instance\u0027s vif."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2F2rc%3D","line":10,"updated":"2013-03-08 19:21:45.000000000","message":"s/existed/existing/\ns/instances\u0027s/instance\u0027s/","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":9,"context_line":"vif_type is a new param in legacy_nw_info added at grizzly,  and when upgrade"},{"line_number":10,"context_line":"from folsom to grizzly, the existed instances\u0027s network info cache in the db doesn\u0027t"},{"line_number":11,"context_line":"contain this param, which is needed by vif driver to plug vif to instance."},{"line_number":12,"context_line":"nova-compute ensure vif is pluged to instance when starts. so we need to update"},{"line_number":13,"context_line":"the existed instance\u0027s network info cache before pluging instance\u0027s vif."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"fix bug #1152426"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2F2rY%3D","line":12,"updated":"2013-03-08 19:21:45.000000000","message":"Nova compute will try to plug the vif when it starts the instance, so we need to update","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from folsom to grizzly, the existed instances\u0027s network info cache in the db doesn\u0027t"},{"line_number":11,"context_line":"contain this param, which is needed by vif driver to plug vif to instance."},{"line_number":12,"context_line":"nova-compute ensure vif is pluged to instance when starts. so we need to update"},{"line_number":13,"context_line":"the existed instance\u0027s network info cache before pluging instance\u0027s vif."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"fix bug #1152426"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2F2rQ%3D","line":13,"updated":"2013-03-08 19:21:45.000000000","message":"s/existed/existing/\ns/pluging/plugging the/","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"d3bde8cbd24039ce87e6dac2b816fa8f402045ff","unresolved":false,"context_lines":[{"line_number":10,"context_line":"from folsom to grizzly, the existed instances\u0027s network info cache in the db doesn\u0027t"},{"line_number":11,"context_line":"contain this param, which is needed by vif driver to plug vif to instance."},{"line_number":12,"context_line":"nova-compute ensure vif is pluged to instance when starts. so we need to update"},{"line_number":13,"context_line":"the existed instance\u0027s network info cache before pluging instance\u0027s vif."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"fix bug #1152426"},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2F1IM%3D","line":13,"in_reply_to":"AAAAN3%2F%2F2rQ%3D","updated":"2013-03-11 02:56:12.000000000","message":"thanks for your kindly help.","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"}],"nova/compute/manager.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":463,"context_line":"        # Keep compatibility with folsom, update networkinfo and"},{"line_number":464,"context_line":"        # add  vif_type to instance_info_cache."},{"line_number":465,"context_line":"        if legacy_net_info:"},{"line_number":466,"context_line":"            if legacy_net_info[0][1].get(\u0027vif_type\u0027) is None:"},{"line_number":467,"context_line":"            # Call to network API to get instance info.. this will"},{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"},{"line_number":469,"context_line":"                net_info \u003d self._get_instance_nw_info(context, instance)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F2qw%3D","line":466,"updated":"2013-03-08 19:21:45.000000000","message":"Can you merge these lines with an \"and\" to avoid the extra nesting?","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            if legacy_net_info[0][1].get(\u0027vif_type\u0027) is None:"},{"line_number":467,"context_line":"            # Call to network API to get instance info.. this will"},{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"},{"line_number":469,"context_line":"                net_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":470,"context_line":"                legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":471,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F2qk%3D","line":469,"updated":"2013-03-08 19:21:45.000000000","message":"Should we update the cache from this?","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"d3bde8cbd24039ce87e6dac2b816fa8f402045ff","unresolved":false,"context_lines":[{"line_number":466,"context_line":"            if legacy_net_info[0][1].get(\u0027vif_type\u0027) is None:"},{"line_number":467,"context_line":"            # Call to network API to get instance info.. this will"},{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"},{"line_number":469,"context_line":"                net_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":470,"context_line":"                legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":471,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":472,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F1KI%3D","line":469,"in_reply_to":"AAAAN3%2F%2F2qk%3D","updated":"2013-03-11 02:56:12.000000000","message":"I think so, this will update the network info of instance_info_cache table.  we only need to do this for one time  because there is a periodic task updating instance info cache .","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"},{"line_number":469,"context_line":"                net_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":470,"context_line":"                legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":471,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        if instance[\u0027task_state\u0027] \u003d\u003d task_states.RESIZE_MIGRATING:"},{"line_number":474,"context_line":"            # We crashed during resize/migration, so roll back for safety"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F2qg%3D","line":471,"updated":"2013-03-08 19:21:45.000000000","message":"I wonder if it might make sense to just call out to the network api all the time on compute startup to get the freshest network data instead of relying on the cache?","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"d3bde8cbd24039ce87e6dac2b816fa8f402045ff","unresolved":false,"context_lines":[{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"},{"line_number":469,"context_line":"                net_info \u003d self._get_instance_nw_info(context, instance)"},{"line_number":470,"context_line":"                legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":471,"context_line":"        self.driver.plug_vifs(instance, legacy_net_info)"},{"line_number":472,"context_line":""},{"line_number":473,"context_line":"        if instance[\u0027task_state\u0027] \u003d\u003d task_states.RESIZE_MIGRATING:"},{"line_number":474,"context_line":"            # We crashed during resize/migration, so roll back for safety"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F1JQ%3D","line":471,"in_reply_to":"AAAAN3%2F%2F2qg%3D","updated":"2013-03-11 02:56:12.000000000","message":"a periodic task \"_heal_instance_info_cache\" is responsible for updating instance\u0027s network info cache. so I think there is no need to do this all the time on compute startup.","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"8c42035c332c4f0d91fb0af1a9a1367f7dfedba8","unresolved":false,"context_lines":[{"line_number":462,"context_line":"        legacy_net_info \u003d self._legacy_nw_info(net_info)"},{"line_number":463,"context_line":""},{"line_number":464,"context_line":"        # Keep compatibility with folsom, update networkinfo and"},{"line_number":465,"context_line":"        # add  vif_type to instance_info_cache."},{"line_number":466,"context_line":"        if legacy_net_info and legacy_net_info[0][1].get(\u0027vif_type\u0027) is None:"},{"line_number":467,"context_line":"            # Call to network API to get instance info, this will"},{"line_number":468,"context_line":"            # force an update to the instance\u0027s info_cache"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAOH%2F%2F7XI%3D","line":465,"updated":"2013-03-20 17:35:48.000000000","message":"stray space in the comment.","commit_id":"e5e675305b1a2cb61fa23df255538ff98c4c9c6e"}],"nova/tests/fake_network_cache_model.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"126814e57f8b72e12bc79640bdae7030dcb1a417","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    vif \u003d dict("},{"line_number":66,"context_line":"        id\u003d1,"},{"line_number":67,"context_line":"        address\u003d\u0027aa:aa:aa:aa:aa:aa\u0027,"},{"line_number":68,"context_line":"        type\u003d\u0027bridge\u0027,"},{"line_number":69,"context_line":"        network\u003dnew_network())"},{"line_number":70,"context_line":"    vif_dict \u003d vif_dict or {}"},{"line_number":71,"context_line":"    vif.update(vif_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F2qM%3D","line":68,"updated":"2013-03-08 19:21:45.000000000","message":"Adding this doesn\u0027t test the code you added, does it?","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"},{"author":{"_account_id":1313,"name":"yaguang","display_name":"Yaguang Tang","email":"heut2008@gmail.com","username":"heut2008"},"change_message_id":"d3bde8cbd24039ce87e6dac2b816fa8f402045ff","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    vif \u003d dict("},{"line_number":66,"context_line":"        id\u003d1,"},{"line_number":67,"context_line":"        address\u003d\u0027aa:aa:aa:aa:aa:aa\u0027,"},{"line_number":68,"context_line":"        type\u003d\u0027bridge\u0027,"},{"line_number":69,"context_line":"        network\u003dnew_network())"},{"line_number":70,"context_line":"    vif_dict \u003d vif_dict or {}"},{"line_number":71,"context_line":"    vif.update(vif_dict)"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2F1JA%3D","line":68,"in_reply_to":"AAAAN3%2F%2F2qM%3D","updated":"2013-03-11 02:56:12.000000000","message":"this is just to pass unit test, not for testing new added code.","commit_id":"8cd4a7ea61756a4e87b13ad761fe0667a4bf234f"}]}