)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":5638,"name":"Davanum Srinivas","email":"davanum@gmail.com","username":"dims-v"},"change_message_id":"6dde2931f65a5cf10322846fedbf7d325fd0897a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"This extension adds the OS-EXT-IPS-MAC:mac_addr param"},{"line_number":10,"context_line":"so that users can associate the mac address to the ip of the server in"},{"line_number":11,"context_line":"once API call."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"DocImpact"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"AAAAOn%2F%2F%2Fk8%3D","line":11,"updated":"2013-04-08 21:42:00.000000000","message":"once -\u003e one (?)","commit_id":"8044220f503318449b1a8d3e3f7bb15b32e61f8e"}],"nova/api/openstack/common.py":[{"author":{"_account_id":385,"name":"Jason Kölker","email":"jason@koelker.net","username":"jason-koelker"},"change_message_id":"0fad6409b4303eb02a4568a5f5b8729304881586","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                             \u0027mac_address\u0027: \u0027aa:aa:aa:aa:aa:aa\u0027},"},{"line_number":339,"context_line":"                            {\u0027address\u0027: \u00272001::1\u0027,"},{"line_number":340,"context_line":"                             \u0027version\u0027: 6,"},{"line_number":341,"context_line":"                             \u0027mac_address\u0027: \u0027bb:bb:bb:bb:bb:bb\u0027}],"},{"line_number":342,"context_line":"                    \u0027floating_ips\u0027: [{\u0027address\u0027: \u0027172.16.0.1\u0027,"},{"line_number":343,"context_line":"                                      \u0027version\u0027: 4,"},{"line_number":344,"context_line":"                                      \u0027mac_address\u0027: \u0027cc:cc:cc:cc:cc:cc\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F3jY%3D","line":341,"updated":"2013-03-08 07:03:01.000000000","message":"All these macs will actually be aa:aa:aa:aa:aa:aa, since the mac_address is a property of the vif, I would think it makes more sense to expose it in the network document like:\n\n    {\u0027public\u0027: {\u0027ips\u0027: [{\u0027address\u0027: \u002710.0.0.1\u0027,\n                            \u0027version\u0027: 4},\n                           {\u0027address\u0027: \u00272001::1\u0027,\n                             \u0027version\u0027: 6}],\n                  \u0027floating_ips\u0027: [{\u0027address\u0027: \u0027172.16.0.1\u0027,\n                                        \u0027version\u0027: 4},\n                                       {\u0027address\u0027: \u0027172.16.2.1\u0027,\n                                         \u0027version\u0027: 4,}],\n                  \u0027mac_address\u0027: \u0027aa:aa:aa:aa:aa:aa\u0027},\n     ...}\n\nwhich has the benefit of not iterating the ips every time.","commit_id":"464d09cda65134975351356de8c2548eecfe871d"},{"author":{"_account_id":6549,"name":"Zhi Yan Liu","email":"lzy.dev@gmail.com","username":"lzy-dev"},"change_message_id":"7a1d08ee0d7f0b8167b7b1f3674af36710a247c0","unresolved":false,"context_lines":[{"line_number":338,"context_line":"                             \u0027mac_address\u0027: \u0027aa:aa:aa:aa:aa:aa\u0027},"},{"line_number":339,"context_line":"                            {\u0027address\u0027: \u00272001::1\u0027,"},{"line_number":340,"context_line":"                             \u0027version\u0027: 6,"},{"line_number":341,"context_line":"                             \u0027mac_address\u0027: \u0027bb:bb:bb:bb:bb:bb\u0027}],"},{"line_number":342,"context_line":"                    \u0027floating_ips\u0027: [{\u0027address\u0027: \u0027172.16.0.1\u0027,"},{"line_number":343,"context_line":"                                      \u0027version\u0027: 4,"},{"line_number":344,"context_line":"                                      \u0027mac_address\u0027: \u0027cc:cc:cc:cc:cc:cc\u0027},"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAN3%2F%2F3g0%3D","line":341,"in_reply_to":"AAAAN3%2F%2F3jY%3D","updated":"2013-03-08 07:40:47.000000000","message":"1. I\u0027d like correct the doc, \u0027bb..\" is wrong, all macs in here are all \u0027aa..\u0027.\n2. I prefer not move \u0027mac_address\u0027 field out to under the network (\u0027public\u0027 label) section since: a) under current implementation, as we know, each network just have only one vif, so there is only one mac_address field in here, but we need keep api (even the extension) consistent even we change the limitation if os allow more then one vif plunge into one network in future, we should not take care this limitation. b) this is easy enough for client/caller parse the result structure (json and xml).","commit_id":"464d09cda65134975351356de8c2548eecfe871d"}],"nova/api/openstack/compute/contrib/extended_ips_mac.py":[{"author":{"_account_id":1297,"name":"Joshua Harlow","email":"jxharlow@godaddy.com","username":"harlowja"},"change_message_id":"3479fde49bce9fb776f15a66c67f531da9287d06","unresolved":false,"context_lines":[{"line_number":64,"context_line":"            # Attach our slave template to the response object"},{"line_number":65,"context_line":"            resp_obj.attach(xml\u003dExtendedIpsMacServersTemplate())"},{"line_number":66,"context_line":"            servers \u003d list(resp_obj.obj[\u0027servers\u0027])"},{"line_number":67,"context_line":"            for server in servers:"},{"line_number":68,"context_line":"                db_instance \u003d req.get_db_instance(server[\u0027id\u0027])"},{"line_number":69,"context_line":"                # server[\u0027id\u0027] is guaranteed to be in the cache due to"},{"line_number":70,"context_line":"                # the core API adding it in its \u0027detail\u0027 method."}],"source_content_type":"text/x-python","patch_set":2,"id":"AAAAOX%2F%2F96c%3D","line":67,"updated":"2013-04-04 06:16:08.000000000","message":"Aw durn, another iteration over all the servers. Sad.","commit_id":"55375cebf7caec2de9164fbeac1759a5406d9c5f"}],"nova/tests/integrated/api_samples/OS-EXT-IPS-MAC/servers-detail-resp.json.tpl":[{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"e0fd8bdfcc7bb3580319f3cf7882ebe1b7c97b1f","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"servers\": ["},{"line_number":3,"context_line":"    {    "},{"line_number":4,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":5,"context_line":"            \"updated\": \"%(timestamp)s\","},{"line_number":6,"context_line":"            \"user_id\": \"fake\","}],"source_content_type":"text/x-smarty","patch_set":2,"id":"AAAAOX%2F%2F6lo%3D","line":3,"updated":"2013-04-06 23:55:43.000000000","message":"Trailing whitespace.","commit_id":"55375cebf7caec2de9164fbeac1759a5406d9c5f"},{"author":{"_account_id":67,"name":"Vish Ishaya","email":"vishvananda@gmail.com","username":"vishvananda"},"change_message_id":"dcea30dfa80494471607898a57a1356c9475958e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"{"},{"line_number":2,"context_line":"    \"servers\": ["},{"line_number":3,"context_line":"    {    "},{"line_number":4,"context_line":"            \"status\": \"ACTIVE\","},{"line_number":5,"context_line":"            \"updated\": \"%(timestamp)s\","},{"line_number":6,"context_line":"            \"user_id\": \"fake\","}],"source_content_type":"text/x-smarty","patch_set":5,"id":"AAAAOn%2F%2F%2FpE%3D","line":3,"updated":"2013-04-08 21:17:59.000000000","message":"got some whitespace here","commit_id":"8044220f503318449b1a8d3e3f7bb15b32e61f8e"}]}
