)]}'
{"nova/rpc/impl_carrot.py":[{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f9937f21a9151afa352a706e2ba2302d874f22d6","unresolved":false,"context_lines":[{"line_number":261,"context_line":"        args \u003d message_data.get(\u0027args\u0027, {})"},{"line_number":262,"context_line":"        if not method:"},{"line_number":263,"context_line":"            # NOTE(vish): we may not want to ack here, but that means that bad"},{"line_number":264,"context_line":"            #             messages stay in the queue indefinitely, so for now"},{"line_number":265,"context_line":"            #             we just log the message and send an error string"},{"line_number":266,"context_line":"            #             back to the caller"},{"line_number":267,"context_line":"            LOG.warn(_(\u0027no method for message: %s\u0027) % message_data)"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8QY%3D","line":264,"updated":"2011-12-16 18:43:38.000000000","message":"Seems to me this note from vish can now be deleted? :)","commit_id":"36372dd79a589ebb40a2f6c8b0526469afb8452c"},{"author":{"_account_id":7,"name":"Jay Pipes","email":"jaypipes@gmail.com","username":"jaypipes"},"change_message_id":"f9937f21a9151afa352a706e2ba2302d874f22d6","unresolved":false,"context_lines":[{"line_number":293,"context_line":"            ctxt.reply(ending\u003dTrue)"},{"line_number":294,"context_line":"            ack_callback()"},{"line_number":295,"context_line":"        except Exception as e:"},{"line_number":296,"context_line":"            LOG.exception(\u0027Exception during message handling\u0027)"},{"line_number":297,"context_line":"            ctxt.reply(None, sys.exc_info())"},{"line_number":298,"context_line":"            ack_callback()"},{"line_number":299,"context_line":"        return"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAC3%2F%2F8QU%3D","line":296,"updated":"2011-12-16 18:43:38.000000000","message":"Not your code, but this is missing i18n...","commit_id":"36372dd79a589ebb40a2f6c8b0526469afb8452c"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"97e5379f67d587896a8664599d162cf136cdfe99","unresolved":false,"context_lines":[{"line_number":291,"context_line":"        except Exception as e:"},{"line_number":292,"context_line":"            LOG.exception(_(\"Exception during %s\") % str(method))"},{"line_number":293,"context_line":"            ctxt.reply(None, sys.exc_info())"},{"line_number":294,"context_line":"            ack_callback()"},{"line_number":295,"context_line":"        return"},{"line_number":296,"context_line":""},{"line_number":297,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F7sU%3D","line":294,"updated":"2011-12-20 18:01:48.000000000","message":"Is there some reason you don\u0027t call the ack_callback() after the try?  That would, I would think, eliminate the double call...","commit_id":"1a054b5de04a0b3ff8b190f80305f5547f1905ec"}],"nova/rpc/impl_kombu.py":[{"author":{"_account_id":34,"name":"Todd Willey","email":"todd@ansolabs.com","username":"xtoddx"},"change_message_id":"9760228674da038550fda91897333de959d9c3e2","unresolved":false,"context_lines":[{"line_number":89,"context_line":"        if not callback:"},{"line_number":90,"context_line":"            raise ValueError(\"No callback defined\")"},{"line_number":91,"context_line":"        print \u0027MJW %s.%s\u0027 % (callback.__class__.__module__,"},{"line_number":92,"context_line":"                             callback.__class__.__name__)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"        def _callback(raw_message):"},{"line_number":95,"context_line":"            message \u003d self.channel.message_to_python(raw_message)"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F8S8%3D","line":92,"updated":"2011-12-16 17:27:48.000000000","message":":(","commit_id":"a622eb044fee8689b12a90b649eeecc13a69bbdc"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"97e5379f67d587896a8664599d162cf136cdfe99","unresolved":false,"context_lines":[{"line_number":630,"context_line":"        except Exception as e:"},{"line_number":631,"context_line":"            LOG.exception(_(\"Exception during %s\") % str(method))"},{"line_number":632,"context_line":"            ctxt.reply(None, sys.exc_info())"},{"line_number":633,"context_line":"            ack_callback()"},{"line_number":634,"context_line":"        return"},{"line_number":635,"context_line":""},{"line_number":636,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAC3%2F%2F7sM%3D","line":633,"updated":"2011-12-20 18:01:48.000000000","message":"Ibid.","commit_id":"1a054b5de04a0b3ff8b190f80305f5547f1905ec"}]}