)]}'
{"nova/compute/manager.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"614f6c336707e3a50241099ee537d5c2edc8b6ce","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"                           filters, expected_attrs\u003d[], use_slave\u003dTrue)"},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"        for instance in building_insts:"},{"line_number":1524,"context_line":"            if timeutils.is_older_than(instance.created_at, timeout) \\"},{"line_number":1525,"context_line":"                    and instance.task_state !\u003d task_states.DELETING:"},{"line_number":1526,"context_line":"                    self._set_instance_obj_error_state(context, instance)"},{"line_number":1527,"context_line":"                    LOG.warning(_LW(\"Instance build timed out. Set to error \""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_6eb633de","line":1524,"updated":"2015-11-03 22:05:36.000000000","message":"Don\u0027t use backslashes - wrap the statement in brackets, i.e.\n\n    if (timeutils ... and\n            instance.task_state):","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"53dbd416ff06023df861bb6f20d09b3d2ae660ec","unresolved":false,"context_lines":[{"line_number":1521,"context_line":"                           filters, expected_attrs\u003d[], use_slave\u003dTrue)"},{"line_number":1522,"context_line":""},{"line_number":1523,"context_line":"        for instance in building_insts:"},{"line_number":1524,"context_line":"            if timeutils.is_older_than(instance.created_at, timeout) \\"},{"line_number":1525,"context_line":"                    and instance.task_state !\u003d task_states.DELETING:"},{"line_number":1526,"context_line":"                    self._set_instance_obj_error_state(context, instance)"},{"line_number":1527,"context_line":"                    LOG.warning(_LW(\"Instance build timed out. Set to error \""}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_519e7257","line":1524,"in_reply_to":"fa80f949_6eb633de","updated":"2015-11-03 22:30:19.000000000","message":"pep8 test is not failing. I will do necessary change.","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":16366,"name":"Randall Nortman","email":"openstack@nortman.net","username":"rnortman"},"change_message_id":"f65bd9e5499966861e675e4c5875b9c467fd71c0","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            if (timeutils.is_older_than(instance.created_at, timeout)"},{"line_number":1525,"context_line":"                    and instance.task_state !\u003d task_states.DELETING):"},{"line_number":1526,"context_line":"                    self._set_instance_obj_error_state(context, instance)"},{"line_number":1527,"context_line":"                    LOG.warning(_LW(\"Instance build timed out. Set to error \""},{"line_number":1528,"context_line":"                                \"state.\"), instance\u003dinstance)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def _check_instance_exists(self, context, instance):"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_f4acd736","line":1527,"updated":"2015-12-16 15:10:36.000000000","message":"This is a style gripe only.  The logic is fine, but I don\u0027t like what\u0027s happening with the indentation here.  This block ends up effectively indented by two levels (8 spaces) for no good reason, which I think is a PEP8 violation.  I\u0027m a little surprised this passes the pep8 tests in nova.  But I\u0027d rather it look like this:\n\n            if (timeutils.is_older_than(instance.created_at, timeout)\n                    and instance.task_state !\u003d task_states.DELETING):\n                self._set_instance_obj_error_state(context, instance)\n                LOG.warning(_LW(\"Instance build timed out. Set to error \"\n                                             \"state.\"), instance\u003dinstance)\n\nThere are other ways of handling this situation if you don\u0027t like that.  The above is one of three recommendations in PEP8 (https://www.python.org/dev/peps/pep-0008/#indentation).","commit_id":"737d88b5d226acd9d28c584fbd2ebb521585c069"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"43ddd2ef38b815d288ba0ea43aacd78fad294824","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"                    and instance.task_state !\u003d task_states.DELETING):"},{"line_number":1526,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":1527,"context_line":"                LOG.warning(_LW(\"Instance build timed out. Set to error \""},{"line_number":1528,"context_line":"                                            \"state.\"), instance\u003dinstance)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def _check_instance_exists(self, context, instance):"},{"line_number":1531,"context_line":"        \"\"\"Ensure an instance with the same name is not already present.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_62e305a5","line":1528,"updated":"2016-01-14 17:41:41.000000000","message":"But what if they are stuck in the deleting state? Should we not also move those to the error state also?","commit_id":"4433f7de477239f40695feda5b08d093c732d971"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"367366f3defc8d2940c21adb75bbd2c1317118de","unresolved":false,"context_lines":[{"line_number":1525,"context_line":"                    and instance.task_state !\u003d task_states.DELETING):"},{"line_number":1526,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":1527,"context_line":"                LOG.warning(_LW(\"Instance build timed out. Set to error \""},{"line_number":1528,"context_line":"                                            \"state.\"), instance\u003dinstance)"},{"line_number":1529,"context_line":""},{"line_number":1530,"context_line":"    def _check_instance_exists(self, context, instance):"},{"line_number":1531,"context_line":"        \"\"\"Ensure an instance with the same name is not already present.\"\"\""}],"source_content_type":"text/x-python","patch_set":8,"id":"da6ed579_1b7b94f6","line":1528,"in_reply_to":"da6ed579_62e305a5","updated":"2016-01-14 18:41:47.000000000","message":"I am not sure if is there any scenario where instance\u0027s vm state is \"building\" and instance\u0027s task state is \"deleting\" forever. \n\nI think, this can happen only when some of resources/services are not available. In that case, while \"Building\" itself, it gets assigned to \"error\" state immediately. \n\nPlease correct me if I am wrong.","commit_id":"4433f7de477239f40695feda5b08d093c732d971"},{"author":{"_account_id":11428,"name":"Ajaya Agrawal","email":"ajku.agr@gmail.com","username":"ajayaa"},"change_message_id":"dd503adbe98e619828d293e474667d183b4e4fa5","unresolved":false,"context_lines":[{"line_number":1530,"context_line":"                    and instance.task_state !\u003d task_states.DELETING):"},{"line_number":1531,"context_line":"                self._set_instance_obj_error_state(context, instance)"},{"line_number":1532,"context_line":"                LOG.warning(_LW(\"Instance build timed out. Set to error \""},{"line_number":1533,"context_line":"                                            \"state.\"), instance\u003dinstance)"},{"line_number":1534,"context_line":""},{"line_number":1535,"context_line":"    def _check_instance_exists(self, context, instance):"},{"line_number":1536,"context_line":"        \"\"\"Ensure an instance with the same name is not already present.\"\"\""}],"source_content_type":"text/x-python","patch_set":9,"id":"5a5ae5dd_ff8a75be","line":1533,"range":{"start_line":1533,"start_character":0,"end_line":1533,"end_character":44},"updated":"2016-02-04 18:31:08.000000000","message":"unnecessary space.","commit_id":"ffde02691015274fe455a440557326c504194c43"}],"nova/tests/unit/compute/test_compute.py":[{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"614f6c336707e3a50241099ee537d5c2edc8b6ce","unresolved":false,"context_lines":[{"line_number":6626,"context_line":"                                mock_save, mock_instance_get_all_by_filters):"},{"line_number":6627,"context_line":"        self.flags(instance_build_timeout\u003d30)"},{"line_number":6628,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":6629,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6632,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_6e04f37d","line":6629,"updated":"2015-11-03 22:05:36.000000000","message":"where does this 60 second value come from? Is it tied to default_timeout? If so, can default_timeout ever change? You may want to load the variable from CONF if so.","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e5ca387d29866116c63a4fd142779b40739c4969","unresolved":false,"context_lines":[{"line_number":6626,"context_line":"                                mock_save, mock_instance_get_all_by_filters):"},{"line_number":6627,"context_line":"        self.flags(instance_build_timeout\u003d30)"},{"line_number":6628,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":6629,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6632,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_a99ab612","line":6629,"in_reply_to":"fa80f949_515d12e8","updated":"2015-11-09 16:41:56.000000000","message":"So this is an example of a magic number. The tests are full of them and they\u0027re universally recognised as a bad thing. However, at least you\u0027re being consistent (I\u0027d do the same) so no point blocking on this","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"53dbd416ff06023df861bb6f20d09b3d2ae660ec","unresolved":false,"context_lines":[{"line_number":6626,"context_line":"                                mock_save, mock_instance_get_all_by_filters):"},{"line_number":6627,"context_line":"        self.flags(instance_build_timeout\u003d30)"},{"line_number":6628,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":6629,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6630,"context_line":""},{"line_number":6631,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6632,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_515d12e8","line":6629,"in_reply_to":"fa80f949_6e04f37d","updated":"2015-11-03 22:30:19.000000000","message":"I am setting instance_build_timeout \u003d 30 in self.flags(). Hence, for unit test it would never change.\nFor instances in list, I have added \"created_at\" with current time - 60 seconds. So build timeout value is static for test  and creation time is 60 before current time. Now, we can run test for these \"Building\" instances for which instance build has timed out.","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"614f6c336707e3a50241099ee537d5c2edc8b6ce","unresolved":false,"context_lines":[{"line_number":6652,"context_line":"        instances.append(fake_instance.fake_db_instance(**deleting_instance))"},{"line_number":6653,"context_line":"        # define return value for mocked object"},{"line_number":6654,"context_line":"        mock_instance_get_all_by_filters.return_value \u003d instances"},{"line_number":6655,"context_line":"        # run the function"},{"line_number":6656,"context_line":"        self.compute._check_instance_build_time(ctxt)"},{"line_number":6657,"context_line":""},{"line_number":6658,"context_line":"        # check against assertions"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_4e032f74","line":6655,"updated":"2015-11-03 22:05:36.000000000","message":"get rid of these kinds of comments: if it\u0027s obvious from the code then we don\u0027t need the comments","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":18335,"name":"Pushkar Umaranikar","email":"pushkar.umaranikar@intel.com","username":"pushkarumaranikar"},"change_message_id":"53dbd416ff06023df861bb6f20d09b3d2ae660ec","unresolved":false,"context_lines":[{"line_number":6652,"context_line":"        instances.append(fake_instance.fake_db_instance(**deleting_instance))"},{"line_number":6653,"context_line":"        # define return value for mocked object"},{"line_number":6654,"context_line":"        mock_instance_get_all_by_filters.return_value \u003d instances"},{"line_number":6655,"context_line":"        # run the function"},{"line_number":6656,"context_line":"        self.compute._check_instance_build_time(ctxt)"},{"line_number":6657,"context_line":""},{"line_number":6658,"context_line":"        # check against assertions"}],"source_content_type":"text/x-python","patch_set":4,"id":"fa80f949_51b0b2f4","line":6655,"in_reply_to":"fa80f949_4e032f74","updated":"2015-11-03 22:30:19.000000000","message":"I will remove this comment.","commit_id":"d019505071cbe7ee5e609f139907b37671e0c80e"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"599959208b465d103a46579f9ef7c0e5b2607abb","unresolved":false,"context_lines":[{"line_number":6636,"context_line":"        mock_instance_get_all_by_filters.return_value \u003d instances"},{"line_number":6637,"context_line":"        self.compute._check_instance_build_time(ctxt)"},{"line_number":6638,"context_line":""},{"line_number":6639,"context_line":"        # check against assertions"},{"line_number":6640,"context_line":"        mock_instance_get_all_by_filters.assert_called_once_with(ctxt, filters,"},{"line_number":6641,"context_line":"                                            sort_key,"},{"line_number":6642,"context_line":"                                            sort_dir,"}],"source_content_type":"text/x-python","patch_set":5,"id":"da85f559_e97e7ead","line":6639,"updated":"2015-11-09 16:42:30.000000000","message":"This is another example of a meaningless comment. I know what you\u0027re trying to do here :) however, if you want comments then why not explain why you chose 60 seconds for a timeout above? Comments should focus on the *why*, rather than the *what* IMO.","commit_id":"830d163aa01f8d3ea54ef161097516240921f337"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"594a1a34bacd65c7dcdb7a98861a8a2920a9b75a","unresolved":false,"context_lines":[{"line_number":6607,"context_line":"    def test_instance_build_timeout_deleting_instances(self,"},{"line_number":6608,"context_line":"                                mock_save, mock_instance_get_all_by_filters):"},{"line_number":6609,"context_line":"        # Tests that the instance which is failed to build in configured"},{"line_number":6610,"context_line":"        # buid timeout value and has vm_state as \u0027deleting\u0027 is not set to"},{"line_number":6611,"context_line":"        # an error state."},{"line_number":6612,"context_line":"        self.flags(instance_build_timeout\u003d30)"},{"line_number":6613,"context_line":"        ctxt \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_dc3b2c37","line":6610,"updated":"2015-11-09 21:54:13.000000000","message":"s/buid/build","commit_id":"1d525581c7390316063692a9c0959b96e18c8238"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"594a1a34bacd65c7dcdb7a98861a8a2920a9b75a","unresolved":false,"context_lines":[{"line_number":6614,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6615,"context_line":""},{"line_number":6616,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6617,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"},{"line_number":6618,"context_line":"        deleting_instance \u003d {"},{"line_number":6619,"context_line":"            \u0027created_at\u0027: created_at,"},{"line_number":6620,"context_line":"            \u0027uuid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_5c165ca8","line":6617,"updated":"2015-11-09 21:54:13.000000000","message":"delete","commit_id":"1d525581c7390316063692a9c0959b96e18c8238"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"594a1a34bacd65c7dcdb7a98861a8a2920a9b75a","unresolved":false,"context_lines":[{"line_number":6621,"context_line":"            \u0027task_state\u0027: task_states.DELETING"},{"line_number":6622,"context_line":"        }"},{"line_number":6623,"context_line":"        deleting_instance.update(filters)"},{"line_number":6624,"context_line":""},{"line_number":6625,"context_line":"        # expired instances"},{"line_number":6626,"context_line":"        expired_instances \u003d []"},{"line_number":6627,"context_line":"        for x in range(2):"}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_1c10d4a7","line":6624,"updated":"2015-11-09 21:54:13.000000000","message":"delete","commit_id":"1d525581c7390316063692a9c0959b96e18c8238"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"594a1a34bacd65c7dcdb7a98861a8a2920a9b75a","unresolved":false,"context_lines":[{"line_number":6632,"context_line":""},{"line_number":6633,"context_line":"        sort_key \u003d \u0027created_at\u0027"},{"line_number":6634,"context_line":"        sort_dir \u003d \u0027desc\u0027"},{"line_number":6635,"context_line":"        # copy all instances to instance list."},{"line_number":6636,"context_line":"        instances \u003d list(expired_instances)"},{"line_number":6637,"context_line":"        instances.append(fake_instance.fake_db_instance(**deleting_instance))"},{"line_number":6638,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"da85f559_bc274811","line":6635,"updated":"2015-11-09 21:54:13.000000000","message":"delete","commit_id":"1d525581c7390316063692a9c0959b96e18c8238"},{"author":{"_account_id":16366,"name":"Randall Nortman","email":"openstack@nortman.net","username":"rnortman"},"change_message_id":"f65bd9e5499966861e675e4c5875b9c467fd71c0","unresolved":false,"context_lines":[{"line_number":6629,"context_line":"        # an error state."},{"line_number":6630,"context_line":"        self.flags(instance_build_timeout\u003d30)"},{"line_number":6631,"context_line":"        ctxt \u003d context.get_admin_context()"},{"line_number":6632,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6633,"context_line":""},{"line_number":6634,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6635,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_cf42623e","line":6632,"updated":"2015-12-16 15:10:36.000000000","message":"The above is correct, but this would be more clear:\n\ncreated_at \u003d timeutils.utcnow() - datetime.timedelta(seconds\u003d60)","commit_id":"737d88b5d226acd9d28c584fbd2ebb521585c069"},{"author":{"_account_id":16366,"name":"Randall Nortman","email":"openstack@nortman.net","username":"rnortman"},"change_message_id":"f65bd9e5499966861e675e4c5875b9c467fd71c0","unresolved":false,"context_lines":[{"line_number":6632,"context_line":"        created_at \u003d timeutils.utcnow() + datetime.timedelta(seconds\u003d-60)"},{"line_number":6633,"context_line":""},{"line_number":6634,"context_line":"        filters \u003d {\u0027vm_state\u0027: vm_states.BUILDING, \u0027host\u0027: CONF.host}"},{"line_number":6635,"context_line":"        # instance with task_as \u0027building\u0027 and vm_state as \u0027building\u0027"},{"line_number":6636,"context_line":"        deleting_instance \u003d {"},{"line_number":6637,"context_line":"            \u0027created_at\u0027: created_at,"},{"line_number":6638,"context_line":"            \u0027uuid\u0027: str(uuid.uuid4()),"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_6f780e90","line":6635,"updated":"2015-12-16 15:10:36.000000000","message":"The above comment is wrong and also unnecessary as it doesn\u0027t add information or explain something potentially confusing.  I suggest you delete it, but if you keep it, change this:\n\n    task_as \u0027building\u0027\n\nto:\n\n    task_state \u0027deleting\u0027\n\nIn order to make it correct.","commit_id":"737d88b5d226acd9d28c584fbd2ebb521585c069"},{"author":{"_account_id":16366,"name":"Randall Nortman","email":"openstack@nortman.net","username":"rnortman"},"change_message_id":"f65bd9e5499966861e675e4c5875b9c467fd71c0","unresolved":false,"context_lines":[{"line_number":6646,"context_line":"            instance \u003d {\u0027uuid\u0027: str(uuid.uuid4()), \u0027created_at\u0027: created_at}"},{"line_number":6647,"context_line":"            instance.update(filters)"},{"line_number":6648,"context_line":"            (expired_instances"},{"line_number":6649,"context_line":"                .append(fake_instance.fake_db_instance(**instance)))"},{"line_number":6650,"context_line":""},{"line_number":6651,"context_line":"        sort_key \u003d \u0027created_at\u0027"},{"line_number":6652,"context_line":"        sort_dir \u003d \u0027desc\u0027"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_ef787e2d","line":6649,"updated":"2015-12-16 15:10:36.000000000","message":"This is not a common style for continuing long lines.  This is better:\n\n\t            expired_instances.append(\n                        fake_instance.fake_db_instance(**instance))\n\nIf that second line is still too long, you can split it in the same way:\n\n\t            expired_instances.append(\n                        fake_instance.fake_db_instance(\n                            **instance))","commit_id":"737d88b5d226acd9d28c584fbd2ebb521585c069"},{"author":{"_account_id":16366,"name":"Randall Nortman","email":"openstack@nortman.net","username":"rnortman"},"change_message_id":"f65bd9e5499966861e675e4c5875b9c467fd71c0","unresolved":false,"context_lines":[{"line_number":6649,"context_line":"                .append(fake_instance.fake_db_instance(**instance)))"},{"line_number":6650,"context_line":""},{"line_number":6651,"context_line":"        sort_key \u003d \u0027created_at\u0027"},{"line_number":6652,"context_line":"        sort_dir \u003d \u0027desc\u0027"},{"line_number":6653,"context_line":"        # copy all instances to instance list."},{"line_number":6654,"context_line":"        instances \u003d list(expired_instances)"},{"line_number":6655,"context_line":"        instances.append(fake_instance.fake_db_instance(**deleting_instance))"}],"source_content_type":"text/x-python","patch_set":7,"id":"5a710552_af727647","line":6652,"updated":"2015-12-16 15:10:36.000000000","message":"Assigning these strings to local variables sort_key and sort_dir accomplishes nothing, as the strings are not used here more than once.  Just put the literal strings in the argument list below and eliminate the local variables.","commit_id":"737d88b5d226acd9d28c584fbd2ebb521585c069"}]}