)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"54ae2cb3225a6d755519c46494a73e5d37354b76","unresolved":false,"context_lines":[{"line_number":2902,"context_line":""},{"line_number":2903,"context_line":"    return result"},{"line_number":2904,"context_line":""},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"@require_context"},{"line_number":2907,"context_line":"@main_context_manager.reader"},{"line_number":2908,"context_line":"def network_get(context, network_id, project_only\u003d\u0027allow_none\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"3a7e1126_43dba54f","line":2905,"updated":"2015-12-18 14:41:17.000000000","message":"do we still need @require_context in addition to this? Also when would we not need it?","commit_id":"69cf16fa32693c07c8383522ed5191eeb8840236"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"f0622bf5def682643b451091f80d6d5d357b102f","unresolved":false,"context_lines":[{"line_number":2902,"context_line":""},{"line_number":2903,"context_line":"    return result"},{"line_number":2904,"context_line":""},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"@require_context"},{"line_number":2907,"context_line":"@main_context_manager.reader"},{"line_number":2908,"context_line":"def network_get(context, network_id, project_only\u003d\u0027allow_none\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"9a68dd71_aafe1d69","line":2905,"in_reply_to":"3a7e1126_43dba54f","updated":"2016-01-21 16:36:57.000000000","message":"Good point Sean! \nRemoving of \u0027@require_context\u0027 seems not related to switching to enginefacade. After small irc chat with John Garbutt we decided that it can be good a follow up cleanup patch. Seems that this decorator is not needed now because without the context nothing will work (because we get session from the context)","commit_id":"69cf16fa32693c07c8383522ed5191eeb8840236"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c118444f3c4a8cdd4ec1446b3c6bce559c52612f","unresolved":false,"context_lines":[{"line_number":2902,"context_line":""},{"line_number":2903,"context_line":"    return result"},{"line_number":2904,"context_line":""},{"line_number":2905,"context_line":""},{"line_number":2906,"context_line":"@require_context"},{"line_number":2907,"context_line":"@main_context_manager.reader"},{"line_number":2908,"context_line":"def network_get(context, network_id, project_only\u003d\u0027allow_none\u0027):"}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_c65ff70c","line":2905,"in_reply_to":"9a68dd71_aafe1d69","updated":"2016-02-03 16:39:58.000000000","message":"Sean, the simple answer from what I can see is that we always need the context for pretty much any db method.  I\u0027m not sure why we have this decorator though since any sensible functional test should weed out not passing the context if required.  I\u0027m in favor of removing this decorator, but not in this patch.","commit_id":"69cf16fa32693c07c8383522ed5191eeb8840236"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"24b69dd1fd2a7ba46f7c4db4b4582f764df3d5af","unresolved":false,"context_lines":[{"line_number":4389,"context_line":""},{"line_number":4390,"context_line":""},{"line_number":4391,"context_line":"@require_context"},{"line_number":4392,"context_line":"@main_context_manager.writer"},{"line_number":4393,"context_line":"def project_get_networks(context, project_id, associate\u003dTrue):"},{"line_number":4394,"context_line":"    # NOTE(tr3buchet): as before this function will associate"},{"line_number":4395,"context_line":"    # a project with a network if it doesn\u0027t have one and"}],"source_content_type":"text/x-python","patch_set":10,"id":"7a5de9d1_8fb2f992","line":4392,"updated":"2016-01-30 09:15:13.000000000","message":"its evil that this is a writer, but it really is.","commit_id":"69cf16fa32693c07c8383522ed5191eeb8840236"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"c118444f3c4a8cdd4ec1446b3c6bce559c52612f","unresolved":false,"context_lines":[{"line_number":4402,"context_line":"        if not associate:"},{"line_number":4403,"context_line":"            return []"},{"line_number":4404,"context_line":""},{"line_number":4405,"context_line":"        return [network_associate(context, project_id)]"},{"line_number":4406,"context_line":""},{"line_number":4407,"context_line":"    return result"},{"line_number":4408,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"5a5ae5dd_6b360c05","line":4405,"updated":"2016-02-03 16:39:58.000000000","message":"Wow, this is terrible.","commit_id":"69cf16fa32693c07c8383522ed5191eeb8840236"}]}