)]}'
{"nova/cmd/manage.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"657c873478ec07a947c901ef9fe0477d1fff53b0","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_6c5108d8","line":1390,"updated":"2015-10-29 17:21:03.000000000","message":"Doesn\u0027t this overwrite everything from config.parse_args? I don\u0027t think we want that. Maybe you need to just append the nova-manage specific ones.  I\u0027m not sure how well oslo.log handles duplicates in the list though (I wish it were a dict rather than a list).","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"e37268546057bff467015ad23edd69dc504f739c","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a26ad4f_4ae8ac10","line":1390,"updated":"2015-10-29 18:54:13.000000000","message":"No, it seems to only override the specified argument, i.e. \u0027default_log_levels\u0027 in this case. You can see that other arguments are ignored here:\n\n    https://github.com/openstack/oslo.log/blob/master/oslo_log/log.py#L262\n\nand only opts specified by the user are overriden here:\n   https://github.com/openstack/oslo.config/blob/e208b50/oslo_config/cfg.py#L600\n\nNote that we\u0027re already not appending to this variable Nova in general: we override it entirely:\n\n    https://github.com/openstack/nova/blob/76fe5bf/nova/config.py#L50\n\nI can\u0027t see any method to append to configuration variables (rather than completely overwriting it) in \u0027oslo_config\u0027. Assuming I haven\u0027t missed anything, the only options seem to be (a) duplicate everything in \u0027nova/config.py\u0027 but with the additional setting, or (b) add this setting in \u0027nova/config.py\u0027. The latter makes far more sense, IMO, as I can\u0027t see who\u0027d want \u0027debug\u0027-level logging from their DB.","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"3cea001acdddbba5fbe3352df0b6d86c9c2c7e5c","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_c5d27100","line":1390,"in_reply_to":"1a26ad4f_4ae8ac10","updated":"2015-11-04 20:55:05.000000000","message":"My point was you\u0027re overwriting what\u0027s done here:\n\nhttps://github.com/openstack/nova/blob/76fe5bf/nova/config.py#L50\n\nWhich we get to via config.parse_args on the line above.\n\nI don\u0027t want to duplicate everything from:\n\nhttps://github.com/openstack/nova/blob/76fe5bf/nova/config.py#L35\n\nIn here, but I was wondering if we could just take that and add the oslo_db entry to it here if it\u0027s not already in the list.\n\nWe could see what others think about your option (b) which was your previous change.","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"bc76d54a77c257f2bc6c6550d7407caa8c31c2c9","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_5603990d","line":1390,"in_reply_to":"fa80f949_40274fb6","updated":"2015-11-04 22:06:52.000000000","message":"Shouldn\u0027t we be running non verbose by default? Which would dump all the DEBUG bits.\n\nWhile I\u0027m fine with raising oslo.db logging to default INFO, most of the rest of the tools start with INFO as the default and only enable DEBUG if DEBUG is set (in the config file for services). I feel like that would be appropriate here as well.","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"af56d3754ddbfd3858d8868ac868583a07d7fb58","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_40274fb6","line":1390,"in_reply_to":"fa80f949_45bd2167","updated":"2015-11-04 21:07:19.000000000","message":"I poked through n-api/n-cpu/n-cond logs and didn\u0027t really see much useful oslo_db debug logging going on, e.g.:\n\nhttp://logs.openstack.org/71/240271/2/check/gate-tempest-dsvm-full/8f41289/logs/screen-n-api.txt.gz\n\nSo I think I\u0027d be fine with reverting to PS1 and defaulting to INFO level.","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"ceb8d0c34b64b9a4c75e3060cacef50480f30afd","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_963021ea","line":1390,"in_reply_to":"fa80f949_5603990d","updated":"2015-11-04 22:08:44.000000000","message":"oslo changed to verbose\u003dTrue by default at some point in Liberty, if that\u0027s what you mean.","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"ed8dc745a1e7aa80e3a83748f25b33b2177e3b4e","unresolved":false,"context_lines":[{"line_number":1387,"context_line":"    CONF.register_cli_opt(category_opt)"},{"line_number":1388,"context_line":"    try:"},{"line_number":1389,"context_line":"        config.parse_args(sys.argv)"},{"line_number":1390,"context_line":"        logging.set_defaults(default_log_levels\u003d_DEFAULT_LOG_LEVELS)"},{"line_number":1391,"context_line":"        logging.setup(CONF, \"nova\")"},{"line_number":1392,"context_line":"    except cfg.ConfigFilesNotFoundError:"},{"line_number":1393,"context_line":"        cfgfile \u003d CONF.config_file[-1] if CONF.config_file else None"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_45bd2167","line":1390,"in_reply_to":"fa80f949_c5d27100","updated":"2015-11-04 21:01:58.000000000","message":"Oh, then yes I overwrite that. Unfortunately I\u0027m just not aware of any way to append options: there\u0027s no `logging.set_level(app, level)` command. I could submit a oslo_logging patch to add this function but there\u0027s no guarantee that it will be accepted. Even if it is, it\u0027ll be a while before we can use it.\n\nI think (b) is still the best option. If I want to pursue this, I presume I should rollback to the previous change and see what another core and other reviewers think?","commit_id":"ae8a25d9a723f0739dc3b6d74330590d7032158a"}],"nova/config.py":[{"author":{"_account_id":6873,"name":"Matt Riedemann","email":"mriedem.os@gmail.com","username":"mriedem"},"change_message_id":"5fe5ca52eda1fb996a6e546cbf9c58dd3de846e1","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                       \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":39,"context_line":"                       \u0027urllib3.connectionpool\u003dWARN\u0027, \u0027websocket\u003dWARN\u0027,"},{"line_number":40,"context_line":"                       \u0027keystonemiddleware\u003dWARN\u0027, \u0027routes.middleware\u003dWARN\u0027,"},{"line_number":41,"context_line":"                       \u0027stevedore\u003dWARN\u0027, \u0027glanceclient\u003dWARN\u0027, \u0027oslo_db\u003dWARN\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"_DEFAULT_LOGGING_CONTEXT_FORMAT \u003d (\u0027%(asctime)s.%(msecs)03d %(process)d \u0027"},{"line_number":44,"context_line":"                                   \u0027%(levelname)s %(name)s [%(request_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_c7ea7cac","line":41,"updated":"2015-10-29 15:48:40.000000000","message":"Hmm, we use INFO for oslo_messaging so I\u0027m inclined to see how that looks first, do you still get a bunch of extraneous stuff with INFO?\n\nAlternatively, can we adjust the logging level context only for things coming in through nova-manage?  Like can we pass in custom log levels to parse_args here?\n\nhttps://github.com/openstack/nova/blob/master/nova/cmd/manage.py#L1387","commit_id":"2654eeb17e00eee47537639ceadab449d2f32e41"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"85fe12ef0590ee770ac8e6be2c9926309ba9084c","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                       \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":39,"context_line":"                       \u0027urllib3.connectionpool\u003dWARN\u0027, \u0027websocket\u003dWARN\u0027,"},{"line_number":40,"context_line":"                       \u0027keystonemiddleware\u003dWARN\u0027, \u0027routes.middleware\u003dWARN\u0027,"},{"line_number":41,"context_line":"                       \u0027stevedore\u003dWARN\u0027, \u0027glanceclient\u003dWARN\u0027, \u0027oslo_db\u003dWARN\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"_DEFAULT_LOGGING_CONTEXT_FORMAT \u003d (\u0027%(asctime)s.%(msecs)03d %(process)d \u0027"},{"line_number":44,"context_line":"                                   \u0027%(levelname)s %(name)s [%(request_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_224a3ec6","line":41,"in_reply_to":"1a26ad4f_425e5a13","updated":"2015-10-29 16:09:16.000000000","message":"What do you know: it is possible. Still not sure if \u0027oslo_db\u0027 should be logging so gratuitously for every module but the bug *is* filed against \u0027nova-manage\u0027 alone","commit_id":"2654eeb17e00eee47537639ceadab449d2f32e41"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"34d7a6107fed84a449c2a078fe0404bf0abe3e5e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"                       \u0027requests.packages.urllib3.connectionpool\u003dWARN\u0027,"},{"line_number":39,"context_line":"                       \u0027urllib3.connectionpool\u003dWARN\u0027, \u0027websocket\u003dWARN\u0027,"},{"line_number":40,"context_line":"                       \u0027keystonemiddleware\u003dWARN\u0027, \u0027routes.middleware\u003dWARN\u0027,"},{"line_number":41,"context_line":"                       \u0027stevedore\u003dWARN\u0027, \u0027glanceclient\u003dWARN\u0027, \u0027oslo_db\u003dWARN\u0027]"},{"line_number":42,"context_line":""},{"line_number":43,"context_line":"_DEFAULT_LOGGING_CONTEXT_FORMAT \u003d (\u0027%(asctime)s.%(msecs)03d %(process)d \u0027"},{"line_number":44,"context_line":"                                   \u0027%(levelname)s %(name)s [%(request_id)s \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_425e5a13","line":41,"in_reply_to":"1a26ad4f_c7ea7cac","updated":"2015-10-29 15:58:37.000000000","message":"I initially chose `INFO` but noticed `sqlalchemy\u003dWARN` and thought that more apt. `INFO` achieves the same goals, however.\n\nI don\u0027t think it\u0027s possible to configure the logging early enough to hide these messages: see Jay\u0027s comments on a previous attempt:\n\n    https://review.openstack.org/#/c/109934/1/nova/cmd/manage.py\n\nBased on this, it seems the messages appear as soon as we import the \u0027oslo_db\u0027 module. This seems to be related to this bug:\n\n    https://bugs.launchpad.net/nova/+bug/1354403\n\nI\u0027ll try achieve what you\u0027re asking for, but I think it might be necessary to configure logging *and then* import `oslo_db` to do so. Probably not a good idea as mixing import statements with code is frowned upon, in my experience.","commit_id":"2654eeb17e00eee47537639ceadab449d2f32e41"}]}