)]}'
{"nova/api/openstack/compute/contrib/services.py":[{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"d4b126986e863c02c8c48436901e509b87f69f70","unresolved":false,"context_lines":[{"line_number":122,"context_line":"            svc \u003d self.host_api.service_update(context, host, binary,"},{"line_number":123,"context_line":"                                               {\u0027disabled\u0027: disabled})"},{"line_number":124,"context_line":"        except exception.ServiceNotFound as exc:"},{"line_number":125,"context_line":"            raise webob.exc.HTTPNotFound(str(exc))"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        return {\u0027service\u0027: {\u0027host\u0027: host, \u0027binary\u0027: binary, \u0027status\u0027: status}}"},{"line_number":128,"context_line":""}],"source_content_type":"text/x-python","patch_set":10,"id":"AAAAOH%2F%2Fyag%3D","line":125,"updated":"2013-03-27 14:55:54.000000000","message":"Might not want to use the message out of the string.  Currently\nfor remote exceptions this is going to show a traceback in python-novaclient:\n\nhttps://review.openstack.org/#/c/25387/","commit_id":"b6959db4bc3976d0997a90451b511e1292e652e6"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8343c2c19ae6a3e0f9861ad19cb570171372710f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        else:"},{"line_number":123,"context_line":"            raise webob.exc.HTTPNotFound(_(\"Unknown action\"))"},{"line_number":124,"context_line":""},{"line_number":125,"context_line":"        status \u003d id + \u0027d\u0027"},{"line_number":126,"context_line":""},{"line_number":127,"context_line":"        try:"},{"line_number":128,"context_line":"            host \u003d body[\u0027host\u0027]"}],"source_content_type":"text/x-python","patch_set":27,"id":"AAAAOn%2F%2Fwrk%3D","line":125,"updated":"2013-04-24 13:15:57.000000000","message":"It looks like this was moved unnecessarily","commit_id":"732bcdb9502aca5c6b38966bd1e53c79236300da"}],"nova/cells/manager.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7552662e44c8f3b3a14eee58c297af692f4ffc40","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    messages."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Scheduling requests get passed to the scheduler class."},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAOX%2F%2F%2FfQ%3D","line":68,"updated":"2013-04-03 11:04:07.000000000","message":"Does this not need updating?","commit_id":"db569d7ec7cba962e26158d0ec456fd19a0e13ac"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"2a41826fbcc451b3fdda54448b80cbecb16cc676","unresolved":false,"context_lines":[{"line_number":65,"context_line":"    messages."},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    Scheduling requests get passed to the scheduler class."},{"line_number":68,"context_line":"    \"\"\""},{"line_number":69,"context_line":"    RPC_API_VERSION \u003d \u00271.6\u0027"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    def __init__(self, *args, **kwargs):"}],"source_content_type":"text/x-python","patch_set":17,"id":"AAAAOX%2F%2F%2BAg%3D","line":68,"in_reply_to":"AAAAOX%2F%2F%2FfQ%3D","updated":"2013-04-04 04:31:27.000000000","message":"Done","commit_id":"db569d7ec7cba962e26158d0ec456fd19a0e13ac"}],"nova/cells/rpcapi.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"e145e4b1e5f7af1641dbacabfb688f419512e284","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        return self.call(ctxt, self.make_msg("},{"line_number":196,"context_line":"            \u0027service_update\u0027, host_name\u003dhost_name,"},{"line_number":197,"context_line":"             binary\u003dbinary, params_to_update\u003dparams_to_update),"},{"line_number":198,"context_line":"             version\u003d\u00271.6\u0027)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def proxy_rpc_to_manager(self, ctxt, rpc_message, topic, call\u003dFalse,"},{"line_number":201,"context_line":"                             timeout\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2F3dU%3D","line":198,"updated":"2013-03-22 20:19:04.000000000","message":"Should be v1.7","commit_id":"83bcb52ae9ab68a94a01ab16735be0ff0ac4ef07"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"6b9a1e36b51dd7f067fd07631620c115cd92d1d5","unresolved":false,"context_lines":[{"line_number":195,"context_line":"        return self.call(ctxt, self.make_msg("},{"line_number":196,"context_line":"            \u0027service_update\u0027, host_name\u003dhost_name,"},{"line_number":197,"context_line":"             binary\u003dbinary, params_to_update\u003dparams_to_update),"},{"line_number":198,"context_line":"             version\u003d\u00271.6\u0027)"},{"line_number":199,"context_line":""},{"line_number":200,"context_line":"    def proxy_rpc_to_manager(self, ctxt, rpc_message, topic, call\u003dFalse,"},{"line_number":201,"context_line":"                             timeout\u003dNone):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2F3NI%3D","line":198,"in_reply_to":"AAAAOH%2F%2F3dU%3D","updated":"2013-03-23 01:29:38.000000000","message":"Done","commit_id":"83bcb52ae9ab68a94a01ab16735be0ff0ac4ef07"}],"nova/compute/api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"e145e4b1e5f7af1641dbacabfb688f419512e284","unresolved":false,"context_lines":[{"line_number":2572,"context_line":"        service \u003d db.service_get_by_args(context, host_name, binary)"},{"line_number":2573,"context_line":"        if not service:"},{"line_number":2574,"context_line":"            raise exception.ServiceByHostAndBinaryNotFound("},{"line_number":2575,"context_line":"                host_name\u003dhost_name, binary\u003dbinary)"},{"line_number":2576,"context_line":"        return db.service_update(context, service[\u0027id\u0027], params_to_update)"},{"line_number":2577,"context_line":""},{"line_number":2578,"context_line":"    def instance_get_all_by_host(self, context, host_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2F3dM%3D","line":2575,"updated":"2013-03-22 20:19:04.000000000","message":"No need for this new exception.  db.service_get_by_args() will raise HostBinaryNotFound already.","commit_id":"83bcb52ae9ab68a94a01ab16735be0ff0ac4ef07"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"6b9a1e36b51dd7f067fd07631620c115cd92d1d5","unresolved":false,"context_lines":[{"line_number":2572,"context_line":"        service \u003d db.service_get_by_args(context, host_name, binary)"},{"line_number":2573,"context_line":"        if not service:"},{"line_number":2574,"context_line":"            raise exception.ServiceByHostAndBinaryNotFound("},{"line_number":2575,"context_line":"                host_name\u003dhost_name, binary\u003dbinary)"},{"line_number":2576,"context_line":"        return db.service_update(context, service[\u0027id\u0027], params_to_update)"},{"line_number":2577,"context_line":""},{"line_number":2578,"context_line":"    def instance_get_all_by_host(self, context, host_name):"}],"source_content_type":"text/x-python","patch_set":7,"id":"AAAAOH%2F%2F3NA%3D","line":2575,"in_reply_to":"AAAAOH%2F%2F3dM%3D","updated":"2013-03-23 01:29:38.000000000","message":"Done","commit_id":"83bcb52ae9ab68a94a01ab16735be0ff0ac4ef07"}],"nova/compute/cells_api.py":[{"author":{"_account_id":1030,"name":"Chris Behrens","email":"cbehrens@codestud.com","username":"cbehrens"},"change_message_id":"b21a667988dcb04bbd3c2c98242be1925972367c","unresolved":false,"context_lines":[{"line_number":645,"context_line":"        # Here the path to the cell is embedded in the service_id"},{"line_number":646,"context_line":"        return self._cast_to_cells(context, host_name,"},{"line_number":647,"context_line":"                                   \u0027service_update\u0027, binary, params_to_update)"},{"line_number":648,"context_line":""},{"line_number":649,"context_line":"    def instance_get_all_by_host(self, context, host_name):"},{"line_number":650,"context_line":"        \"\"\"Get all instances by host.  Host might have a cell prepended"},{"line_number":651,"context_line":"        to it, so we\u0027ll need to strip it out.  We don\u0027t need to proxy"}],"source_content_type":"text/x-python","patch_set":3,"id":"AAAAN3%2F%2Fv%2Fw%3D","line":648,"updated":"2013-03-13 21:03:47.000000000","message":"I would prefer we add explicit cells methods for these instead of generic \u0027call_host_api_method\u0027 calls.  I want to move away from having to re-call any sort of API in child cells.","commit_id":"0dd756bb115fe7e217c3fc91ac6fb3ab6584d20a"}],"nova/exception.py":[{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"ed98dae5a523836882977773ffbf424a08d4a687","unresolved":false,"context_lines":[{"line_number":865,"context_line":"    message \u003d _(\"Cell is not known for instance %(instance_uuid)s\")"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"class HostUnknownCell(NotFound):"},{"line_number":869,"context_line":"    message \u003d _(\"Cell is not known for host %(full_host_name)s\")"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOn%2F%2Fyc0%3D","line":868,"updated":"2013-04-23 12:07:03.000000000","message":"Good catch. Removed.","commit_id":"d757f4ba90ab633c5736a8d10abcd5871c5bbc64"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"1f5f1d0596f3f95c71d290a7435cc38f197b5481","unresolved":false,"context_lines":[{"line_number":865,"context_line":"    message \u003d _(\"Cell is not known for instance %(instance_uuid)s\")"},{"line_number":866,"context_line":""},{"line_number":867,"context_line":""},{"line_number":868,"context_line":"class HostUnknownCell(NotFound):"},{"line_number":869,"context_line":"    message \u003d _(\"Cell is not known for host %(full_host_name)s\")"},{"line_number":870,"context_line":""},{"line_number":871,"context_line":""}],"source_content_type":"text/x-python","patch_set":26,"id":"AAAAOn%2F%2Fzog%3D","line":868,"updated":"2013-04-22 18:57:31.000000000","message":"I might be missing something, but I don\u0027t see where this gets used?","commit_id":"d757f4ba90ab633c5736a8d10abcd5871c5bbc64"}],"nova/tests/cells/test_cells_messaging.py":[{"author":{"_account_id":5652,"name":"David Ripton","email":"dripton@redhat.com","username":"dripton"},"change_message_id":"7cdf9e442a2d60ab87664aec913a8f87cf1b34de","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake_user\u0027, \u0027fake_project\u0027,"},{"line_number":762,"context_line":"                                      is_admin\u003dTrue)"},{"line_number":763,"context_line":"        # We use the real DB for this test, as its too hard to reach the"},{"line_number":764,"context_line":"        # host_api to mock out it\u0027s DB methods"},{"line_number":765,"context_line":"        db.service_create(ctxt, fake_service)"},{"line_number":766,"context_line":"        db.compute_node_create(ctxt, fake_compute)"},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOH%2F%2FuWk%3D","line":764,"updated":"2013-04-01 13:14:58.000000000","message":"its","commit_id":"1fe7b950bcdcc0db7a2a0388f5e70844f7b86a36"},{"author":{"_account_id":4419,"name":"Matthew Sherborne","email":"msherborne+openstack@gmail.com","username":"msherborne+openstack"},"change_message_id":"311002412681526394f4c56a52e61fa31a018657","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake_user\u0027, \u0027fake_project\u0027,"},{"line_number":762,"context_line":"                                      is_admin\u003dTrue)"},{"line_number":763,"context_line":"        # We use the real DB for this test, as its too hard to reach the"},{"line_number":764,"context_line":"        # host_api to mock out it\u0027s DB methods"},{"line_number":765,"context_line":"        db.service_create(ctxt, fake_service)"},{"line_number":766,"context_line":"        db.compute_node_create(ctxt, fake_compute)"},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOH%2F%2Ft5U%3D","line":764,"in_reply_to":"AAAAOH%2F%2FuWQ%3D","updated":"2013-04-01 20:42:44.000000000","message":"haha, yeah I got it exactly wrong, 100% consistently wrong. Awesome :)\n\nThanks guys for your great attention to detail.\n\nDone..","commit_id":"1fe7b950bcdcc0db7a2a0388f5e70844f7b86a36"},{"author":{"_account_id":2835,"name":"Brian Elliott","email":"bdelliott@gmail.com","username":"belliott"},"change_message_id":"fc2474313bb1694751d04bf013c9e3f2bb768686","unresolved":false,"context_lines":[{"line_number":761,"context_line":"        ctxt \u003d context.RequestContext(\u0027fake_user\u0027, \u0027fake_project\u0027,"},{"line_number":762,"context_line":"                                      is_admin\u003dTrue)"},{"line_number":763,"context_line":"        # We use the real DB for this test, as its too hard to reach the"},{"line_number":764,"context_line":"        # host_api to mock out it\u0027s DB methods"},{"line_number":765,"context_line":"        db.service_create(ctxt, fake_service)"},{"line_number":766,"context_line":"        db.compute_node_create(ctxt, fake_compute)"},{"line_number":767,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"AAAAOH%2F%2FuWQ%3D","line":764,"in_reply_to":"AAAAOH%2F%2FuWk%3D","updated":"2013-04-01 13:26:39.000000000","message":"actually:\n\n1st one should be: it\u0027s (contraction)\n2nd one should be: its\n\nbut i\u0027m going to +1 :)","commit_id":"1fe7b950bcdcc0db7a2a0388f5e70844f7b86a36"}]}