)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d49fda17302827b479c708b4c92b1c3e1106813","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"    # Filter the query"},{"line_number":2055,"context_line":"    query_prefix \u003d _exact_instance_filter(query_prefix,"},{"line_number":2056,"context_line":"                                filters, exact_match_filter_names)"},{"line_number":2057,"context_line":"    if query_prefix is None:"},{"line_number":2058,"context_line":"        return []"},{"line_number":2059,"context_line":"    query_prefix \u003d _regex_instance_filter(query_prefix, filters)"},{"line_number":2060,"context_line":"    query_prefix \u003d _tag_instance_filter(context, query_prefix, filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_2239abf2","line":2057,"updated":"2015-11-01 12:25:19.000000000","message":"can you please add in specific test here","commit_id":"d40dbcda651638ed0c16e9c47b1a13735d717a27"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"45ce2859a4fdc454c51770f4c45205b2c4d34a09","unresolved":false,"context_lines":[{"line_number":2054,"context_line":"    # Filter the query"},{"line_number":2055,"context_line":"    query_prefix \u003d _exact_instance_filter(query_prefix,"},{"line_number":2056,"context_line":"                                filters, exact_match_filter_names)"},{"line_number":2057,"context_line":"    if query_prefix is None:"},{"line_number":2058,"context_line":"        return []"},{"line_number":2059,"context_line":"    query_prefix \u003d _regex_instance_filter(query_prefix, filters)"},{"line_number":2060,"context_line":"    query_prefix \u003d _tag_instance_filter(context, query_prefix, filters)"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_609c7b5d","line":2057,"in_reply_to":"1a26ad4f_2239abf2","updated":"2015-11-01 17:24:56.000000000","message":"Done","commit_id":"d40dbcda651638ed0c16e9c47b1a13735d717a27"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d49fda17302827b479c708b4c92b1c3e1106813","unresolved":false,"context_lines":[{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"def instance_get_all_by_grantee_security_groups(context, group_ids):"},{"line_number":2406,"context_line":"    if not group_ids:"},{"line_number":2407,"context_line":"        return []"},{"line_number":2408,"context_line":"    return _instances_fill_metadata(context,"},{"line_number":2409,"context_line":"        _instance_get_all_query(context)."},{"line_number":2410,"context_line":"            join(models.Instance.security_groups)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_e22733c8","line":2407,"updated":"2015-11-01 12:25:19.000000000","message":"ditto for the test","commit_id":"d40dbcda651638ed0c16e9c47b1a13735d717a27"},{"author":{"_account_id":16907,"name":"Diana Clarke","email":"diana.joan.clarke@gmail.com","username":"diana-clarke"},"change_message_id":"45ce2859a4fdc454c51770f4c45205b2c4d34a09","unresolved":false,"context_lines":[{"line_number":2404,"context_line":""},{"line_number":2405,"context_line":"def instance_get_all_by_grantee_security_groups(context, group_ids):"},{"line_number":2406,"context_line":"    if not group_ids:"},{"line_number":2407,"context_line":"        return []"},{"line_number":2408,"context_line":"    return _instances_fill_metadata(context,"},{"line_number":2409,"context_line":"        _instance_get_all_query(context)."},{"line_number":2410,"context_line":"            join(models.Instance.security_groups)."}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_65dfad0d","line":2407,"in_reply_to":"1a26ad4f_e22733c8","updated":"2015-11-01 17:24:56.000000000","message":"Done","commit_id":"d40dbcda651638ed0c16e9c47b1a13735d717a27"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"2d49fda17302827b479c708b4c92b1c3e1106813","unresolved":false,"context_lines":[{"line_number":6371,"context_line":""},{"line_number":6372,"context_line":"def _instance_pcidevs_get_multi(context, instance_uuids, session\u003dNone):"},{"line_number":6373,"context_line":"    if not instance_uuids:"},{"line_number":6374,"context_line":"        return []"},{"line_number":6375,"context_line":"    return model_query(context, models.PciDevice, session\u003dsession).\\"},{"line_number":6376,"context_line":"        filter_by(status\u003d\u0027allocated\u0027).\\"},{"line_number":6377,"context_line":"        filter(models.PciDevice.instance_uuid.in_(instance_uuids))"}],"source_content_type":"text/x-python","patch_set":1,"id":"1a26ad4f_a22dbba9","line":6374,"updated":"2015-11-01 12:25:19.000000000","message":"ditto","commit_id":"d40dbcda651638ed0c16e9c47b1a13735d717a27"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"1a635d24320acd7845b21bb83594cbb493a14737","unresolved":false,"context_lines":[{"line_number":2215,"context_line":"                    query \u003d query.filter(column_attr.any(value\u003dv))"},{"line_number":2216,"context_line":"        elif isinstance(value, (list, tuple, set, frozenset)):"},{"line_number":2217,"context_line":"            if not value:"},{"line_number":2218,"context_line":"                return None  # empty IN-predicate; short circuit"},{"line_number":2219,"context_line":"            # Looking for values in a list; apply to query directly"},{"line_number":2220,"context_line":"            column_attr \u003d getattr(model, key)"},{"line_number":2221,"context_line":"            query \u003d query.filter(column_attr.in_(value))"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_4ce25b05","line":2218,"updated":"2015-11-16 19:11:13.000000000","message":"So, it took me writing several comments about how this was wrong to realize it was right. If you respin, a comment about how any one filter that asserts presence in an empty list obviates all the rest would help slow-witted people like me.","commit_id":"eed9d70b2dea8a5829c06016ee9cae660b2048d8"}]}