)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"3e4c4a82a14fcbe5a6edfcfd65176b89d904b6f8","unresolved":false,"context_lines":[{"line_number":12,"context_line":"order to launch the instance on the destination host. This patch fixes"},{"line_number":13,"context_line":"Bug #1153599."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"Bug #1153599"},{"line_number":16,"context_line":"Change-Id: I86c1b697fe5c7d6e4a6c689f75fd5cf737cef5d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"AAAAN3%2F%2F0ac%3D","line":15,"updated":"2013-03-11 15:27:25.000000000","message":"No need to list the bug twice.","commit_id":"28b3bd57f7671fec4307438da0711c102884bfd6"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cd21def88bebfb2990bb55064f0425c21fa63f75","unresolved":false,"context_lines":[{"line_number":14,"context_line":"functionality for PowerVM. Bug #1133058 is for tracking these test cases"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Bug #1153599"},{"line_number":17,"context_line":"Bug #1133058"},{"line_number":18,"context_line":"Change-Id: I86c1b697fe5c7d6e4a6c689f75fd5cf737cef5d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2Fysw%3D","line":17,"updated":"2013-03-12 14:07:25.000000000","message":"Would you mind removing these? They\u0027re already mentioned in the paragraph above, which means we have all the linkage necessary.","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"14f745d63cf9b4a5a75c0449764ca1de16a4ebe1","unresolved":false,"context_lines":[{"line_number":14,"context_line":"functionality for PowerVM. Bug #1133058 is for tracking these test cases"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Bug #1153599"},{"line_number":17,"context_line":"Bug #1133058"},{"line_number":18,"context_line":"Change-Id: I86c1b697fe5c7d6e4a6c689f75fd5cf737cef5d4"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"AAAAN3%2F%2Fyro%3D","line":17,"in_reply_to":"AAAAN3%2F%2Fysw%3D","updated":"2013-03-12 14:43:14.000000000","message":"Done","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"}],"nova/tests/test_powervm.py":[{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"cd21def88bebfb2990bb55064f0425c21fa63f75","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                                    \u0027some_key \u0027,"},{"line_number":385,"context_line":"                                    \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                    \u0027 fake_user@compute_host_2:some\u0027,"},{"line_number":387,"context_line":"                                    \u0027/image/path\u0027])"},{"line_number":388,"context_line":"            self.assertEqual(expected_cmd, cmd)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2Fys4%3D","line":387,"updated":"2013-03-12 14:07:25.000000000","message":"I think it\u0027s really confusing to join on the empty string, and especially confusing to mix and match the leading or trailing spaces in these string pieces which actually make it work.\n\nCan you build the long path first and then join on \u0027 \u0027 like one would think?","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"f5545d7de881895537e28bcad9629c067bd2d221","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                                    \u0027some_key \u0027,"},{"line_number":385,"context_line":"                                    \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                    \u0027 fake_user@compute_host_2:some\u0027,"},{"line_number":387,"context_line":"                                    \u0027/image/path\u0027])"},{"line_number":388,"context_line":"            self.assertEqual(expected_cmd, cmd)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2Fykc%3D","line":387,"in_reply_to":"AAAAN3%2F%2FymA%3D","updated":"2013-03-12 15:12:01.000000000","message":"Done","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"},{"author":{"_account_id":4393,"name":"Dan Smith","email":"dms@danplanet.com","username":"danms"},"change_message_id":"dedc0b4b2be4414698a2fc0875a91e3de8c6439d","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                                    \u0027some_key \u0027,"},{"line_number":385,"context_line":"                                    \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                    \u0027 fake_user@compute_host_2:some\u0027,"},{"line_number":387,"context_line":"                                    \u0027/image/path\u0027])"},{"line_number":388,"context_line":"            self.assertEqual(expected_cmd, cmd)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2FymA%3D","line":387,"in_reply_to":"AAAAN3%2F%2Fync%3D","updated":"2013-03-12 14:59:46.000000000","message":"No, Join your list like you\u0027re doing, but on \u0027 \u0027 instead of the empty string (and remove the spaces in the string pieces. I assumed the reason you were joining on the empty string is because two of the pieces needed to not be separated by a space, presumably because something would wrap. However you get around that is fine (either building the path in a string first and putting that in the join, or just formatting your code differently to avoid the long line altogether. Regardless, I think this should join the string pieces on \u0027 \u0027, however you want to accomplish that.","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"14f745d63cf9b4a5a75c0449764ca1de16a4ebe1","unresolved":false,"context_lines":[{"line_number":384,"context_line":"                                    \u0027some_key \u0027,"},{"line_number":385,"context_line":"                                    \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                    \u0027 fake_user@compute_host_2:some\u0027,"},{"line_number":387,"context_line":"                                    \u0027/image/path\u0027])"},{"line_number":388,"context_line":"            self.assertEqual(expected_cmd, cmd)"},{"line_number":389,"context_line":""},{"line_number":390,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":4,"id":"AAAAN3%2F%2Fync%3D","line":387,"in_reply_to":"AAAAN3%2F%2Fys4%3D","updated":"2013-03-12 14:43:14.000000000","message":"By building the long path first would you like me to build the command in a dictionary and then call the join on space on the dictionary?","commit_id":"fb997fad687dda18103406cbd79405d8a97d853d"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self):"},{"line_number":111,"context_line":"        self.connection_data \u003d common.Connection(host\u003d\u0027fake_compute_1\u0027,"},{"line_number":112,"context_line":"                                                 username\u003d\u0027fake_user\u0027,"},{"line_number":113,"context_line":"                                                 password\u003d\u0027fake_pass\u0027)"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFs%3D","line":112,"updated":"2013-03-12 18:21:34.000000000","message":"Can you indent these two lines under the bracket above please?","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":109,"context_line":""},{"line_number":110,"context_line":"    def __init__(self):"},{"line_number":111,"context_line":"        self.connection_data \u003d common.Connection(host\u003d\u0027fake_compute_1\u0027,"},{"line_number":112,"context_line":"                                                 username\u003d\u0027fake_user\u0027,"},{"line_number":113,"context_line":"                                                 password\u003d\u0027fake_pass\u0027)"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCs%3D","line":112,"in_reply_to":"AAAAN3%2F%2FyFs%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            pass"},{"line_number":330,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":331,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":332,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":333,"context_line":"        blockdev_op \u003d self.powervm_connection._powervm._disk_adapter"},{"line_number":334,"context_line":"        file_path \u003d blockdev_op.migrate_volume(lv_name, src_host, dest,"},{"line_number":335,"context_line":"                                               image_path, inst_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFk%3D","line":332,"updated":"2013-03-12 18:21:34.000000000","message":"Why can\u0027t these two fakes just be one? Something like fake_noop()?","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":329,"context_line":"            pass"},{"line_number":330,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":331,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":332,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":333,"context_line":"        blockdev_op \u003d self.powervm_connection._powervm._disk_adapter"},{"line_number":334,"context_line":"        file_path \u003d blockdev_op.migrate_volume(lv_name, src_host, dest,"},{"line_number":335,"context_line":"                                               image_path, inst_name)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCw%3D","line":332,"in_reply_to":"AAAAN3%2F%2FyFk%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            pass"},{"line_number":347,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":348,"context_line":"                       \u0027_copy_device_to_file\u0027,"},{"line_number":349,"context_line":"                       fake_copy_device_to_file)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        def fake_run_vios_command_as_root(*args, **kwargs):"},{"line_number":352,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFc%3D","line":349,"updated":"2013-03-12 18:21:34.000000000","message":"Reuse fake_noop as well here.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":346,"context_line":"            pass"},{"line_number":347,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":348,"context_line":"                       \u0027_copy_device_to_file\u0027,"},{"line_number":349,"context_line":"                       fake_copy_device_to_file)"},{"line_number":350,"context_line":""},{"line_number":351,"context_line":"        def fake_run_vios_command_as_root(*args, **kwargs):"},{"line_number":352,"context_line":"            pass"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCk%3D","line":349,"in_reply_to":"AAAAN3%2F%2FyFc%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            pass"},{"line_number":353,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":354,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":355,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":356,"context_line":"        blockdev_op \u003d self.powervm_connection._powervm._disk_adapter"},{"line_number":357,"context_line":"        file_path \u003d blockdev_op.migrate_volume(lv_name, src_host, dest,"},{"line_number":358,"context_line":"                                               image_path)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFg%3D","line":355,"updated":"2013-03-12 18:21:34.000000000","message":"Ditto.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":352,"context_line":"            pass"},{"line_number":353,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":354,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":355,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":356,"context_line":"        blockdev_op \u003d self.powervm_connection._powervm._disk_adapter"},{"line_number":357,"context_line":"        file_path \u003d blockdev_op.migrate_volume(lv_name, src_host, dest,"},{"line_number":358,"context_line":"                                               image_path)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCg%3D","line":355,"in_reply_to":"AAAAN3%2F%2FyFg%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":376,"context_line":"            pass"},{"line_number":377,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":378,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":379,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":382,"context_line":"            cmd \u003d args[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFY%3D","line":379,"updated":"2013-03-12 18:21:34.000000000","message":"Ditto.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":376,"context_line":"            pass"},{"line_number":377,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":378,"context_line":"                       \u0027run_vios_command_as_root\u0027,"},{"line_number":379,"context_line":"                       fake_run_vios_command_as_root)"},{"line_number":380,"context_line":""},{"line_number":381,"context_line":"        def fake_run_vios_command(*args, **kwargs):"},{"line_number":382,"context_line":"            cmd \u003d args[0]"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyBg%3D","line":379,"in_reply_to":"AAAAN3%2F%2FyFY%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            exp_cmd \u003d \u0027 \u0027.join([\u0027scp -o \"StrictHostKeyChecking no\" -i\u0027,"},{"line_number":384,"context_line":"                                \u0027some_key\u0027,"},{"line_number":385,"context_line":"                                \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                \u0027fake_user@compute_host_2:some/image/path\u0027])"},{"line_number":387,"context_line":"            self.assertEqual(exp_cmd, cmd)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFU%3D","line":386,"updated":"2013-03-12 18:21:34.000000000","message":"Why use join here instead of just constructing the string?","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":383,"context_line":"            exp_cmd \u003d \u0027 \u0027.join([\u0027scp -o \"StrictHostKeyChecking no\" -i\u0027,"},{"line_number":384,"context_line":"                                \u0027some_key\u0027,"},{"line_number":385,"context_line":"                                \u0027some/image/path/logical-vol-name_rsz.gz\u0027,"},{"line_number":386,"context_line":"                                \u0027fake_user@compute_host_2:some/image/path\u0027])"},{"line_number":387,"context_line":"            self.assertEqual(exp_cmd, cmd)"},{"line_number":388,"context_line":""},{"line_number":389,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyBM%3D","line":386,"in_reply_to":"AAAAN3%2F%2FyFU%3D","updated":"2013-03-12 18:45:48.000000000","message":"Here I was just thinking that it would be easier to break the string into smaller strings and ensure that a space is placed where it needs to be in the command that is getting built. I can change this to a single hard coded string if you think that would be best.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    def test_get_resize_name(self):"},{"line_number":398,"context_line":"        inst_name \u003d \u0027instance-00000001\u0027"},{"line_number":399,"context_line":"        expected_name \u003d \u0027rsz_instance-00000001\u0027"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFM%3D","line":400,"updated":"2013-03-12 18:21:34.000000000","message":"Remove this blank line.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":397,"context_line":"    def test_get_resize_name(self):"},{"line_number":398,"context_line":"        inst_name \u003d \u0027instance-00000001\u0027"},{"line_number":399,"context_line":"        expected_name \u003d \u0027rsz_instance-00000001\u0027"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCc%3D","line":400,"in_reply_to":"AAAAN3%2F%2FyFM%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        expected_name \u003d \u0027rsz_instance-00000001\u0027"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(expected_name, result)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_get_long_resize_name(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFQ%3D","line":402,"updated":"2013-03-12 18:21:34.000000000","message":"Remove this blank line.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":399,"context_line":"        expected_name \u003d \u0027rsz_instance-00000001\u0027"},{"line_number":400,"context_line":""},{"line_number":401,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":402,"context_line":""},{"line_number":403,"context_line":"        self.assertEqual(expected_name, result)"},{"line_number":404,"context_line":""},{"line_number":405,"context_line":"    def test_get_long_resize_name(self):"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCY%3D","line":402,"in_reply_to":"AAAAN3%2F%2FyFQ%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    def test_get_long_resize_name(self):"},{"line_number":406,"context_line":"        inst_name \u003d \u0027some_really_long_instance_name_00000001\u0027"},{"line_number":407,"context_line":"        expected_name \u003d \u0027rsz__really_long_instance_name_00000001\u0027"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFA%3D","line":408,"updated":"2013-03-12 18:21:34.000000000","message":"Remove this blank line.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":405,"context_line":"    def test_get_long_resize_name(self):"},{"line_number":406,"context_line":"        inst_name \u003d \u0027some_really_long_instance_name_00000001\u0027"},{"line_number":407,"context_line":"        expected_name \u003d \u0027rsz__really_long_instance_name_00000001\u0027"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCU%3D","line":408,"in_reply_to":"AAAAN3%2F%2FyFA%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"3d1689e9586139a1f75410de7d091896b8f4312e","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        expected_name \u003d \u0027rsz__really_long_instance_name_00000001\u0027"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyFE%3D","line":410,"updated":"2013-03-12 18:21:34.000000000","message":"Remove this blank line.","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"460cda611599d4b85e3c48819e7c55cca5b4344b","unresolved":false,"context_lines":[{"line_number":407,"context_line":"        expected_name \u003d \u0027rsz__really_long_instance_name_00000001\u0027"},{"line_number":408,"context_line":""},{"line_number":409,"context_line":"        result \u003d self.powervm_connection._get_resize_name(inst_name)"},{"line_number":410,"context_line":""},{"line_number":411,"context_line":"        self.assertEqual(expected_name, result)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAN3%2F%2FyCQ%3D","line":410,"in_reply_to":"AAAAN3%2F%2FyFE%3D","updated":"2013-03-12 18:45:48.000000000","message":"Done","commit_id":"889455d7e7d260765f7bd10f602c37651f7d39e5"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"bbccd4ab765e7b6769e26afdf063a20441caa279","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def __init__(self):"},{"line_number":111,"context_line":"        self.connection_data \u003d common.Connection(host\u003d\u0027fake_compute_1\u0027,"},{"line_number":112,"context_line":"                                                 username\u003d\u0027fake_user\u0027,"},{"line_number":113,"context_line":"                                                 password\u003d\u0027fake_pass\u0027)"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _create_logical_volume(self, size):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2FwSI%3D","line":113,"updated":"2013-03-13 18:45:37.000000000","message":"These indents need to be two spaces more.","commit_id":"47cf519007ea4b3c1d5dfe579a4436597ea186a7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bbcc27eb17b2fd1caa47f2799087b77104e36ca8","unresolved":false,"context_lines":[{"line_number":110,"context_line":"    def __init__(self):"},{"line_number":111,"context_line":"        self.connection_data \u003d common.Connection(host\u003d\u0027fake_compute_1\u0027,"},{"line_number":112,"context_line":"                                                 username\u003d\u0027fake_user\u0027,"},{"line_number":113,"context_line":"                                                 password\u003d\u0027fake_pass\u0027)"},{"line_number":114,"context_line":"        pass"},{"line_number":115,"context_line":""},{"line_number":116,"context_line":"    def _create_logical_volume(self, size):"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2FvmA%3D","line":113,"in_reply_to":"AAAAN3%2F%2FwSI%3D","updated":"2013-03-14 04:07:36.000000000","message":"Done","commit_id":"47cf519007ea4b3c1d5dfe579a4436597ea186a7"},{"author":{"_account_id":2271,"name":"Michael Still","email":"mikal@stillhq.com","username":"mikalstill"},"change_message_id":"bbccd4ab765e7b6769e26afdf063a20441caa279","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        src_host \u003d \u0027compute_host_1\u0027"},{"line_number":337,"context_line":"        dest \u003d \u0027compute_host_1\u0027"},{"line_number":338,"context_line":"        image_path \u003d \u0027some/image/path\u0027"},{"line_number":339,"context_line":"        fake_noop \u003d lambda *args, **kwargs: None"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":342,"context_line":"                       \u0027_copy_device_to_file\u0027, fake_noop)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2FwRs%3D","line":339,"updated":"2013-03-13 18:45:37.000000000","message":"Why keep redefining fake_noop?","commit_id":"47cf519007ea4b3c1d5dfe579a4436597ea186a7"},{"author":{"_account_id":5046,"name":"Lance Bragstad","email":"lbragstad@redhat.com","username":"ldbragst"},"change_message_id":"bbcc27eb17b2fd1caa47f2799087b77104e36ca8","unresolved":false,"context_lines":[{"line_number":336,"context_line":"        src_host \u003d \u0027compute_host_1\u0027"},{"line_number":337,"context_line":"        dest \u003d \u0027compute_host_1\u0027"},{"line_number":338,"context_line":"        image_path \u003d \u0027some/image/path\u0027"},{"line_number":339,"context_line":"        fake_noop \u003d lambda *args, **kwargs: None"},{"line_number":340,"context_line":""},{"line_number":341,"context_line":"        self.stubs.Set(self.powervm_connection._powervm._disk_adapter,"},{"line_number":342,"context_line":"                       \u0027_copy_device_to_file\u0027, fake_noop)"}],"source_content_type":"text/x-python","patch_set":6,"id":"AAAAN3%2F%2Fvls%3D","line":339,"in_reply_to":"AAAAN3%2F%2FwRs%3D","updated":"2013-03-14 04:07:36.000000000","message":"In this case we define fake_noop so that it is independent in each test case. Treating this noop like a variable in each case to keep a level of isolation between test cases. Instead of having it be global and causing a number of tests to fail if the global fake_noop is changed.","commit_id":"47cf519007ea4b3c1d5dfe579a4436597ea186a7"}]}