)]}'
{"nova/db/sqlalchemy/api.py":[{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"817038a5df724ac80107cd08a5210894a5a52eaf","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                soft_delete(synchronize_session\u003dFalse)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"@main_context_manager.reader"},{"line_number":445,"context_line":"def service_get(context, service_id):"},{"line_number":446,"context_line":"    query \u003d model_query(context, models.Service).filter_by(id\u003dservice_id)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":12,"id":"3a7e1126_c57c35ee","line":444,"updated":"2015-12-21 13:51:42.000000000","message":"this is not \u0027allow_async\u0027 because it is not really used with \u0027use_slave\u0027 in service object function (moreover \u0027get_by_id\u0027 method doesn\u0027t have \u0027use_slave\u0027 arg)","commit_id":"915635a4d4192505ad759c94e575736c222e4f8f"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"5d610b0a4848d9c7da915c9b8965a2b508e1ab3e","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                soft_delete(synchronize_session\u003dFalse)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"@main_context_manager.reader"},{"line_number":445,"context_line":"def service_get(context, service_id):"},{"line_number":446,"context_line":"    query \u003d model_query(context, models.Service).filter_by(id\u003dservice_id)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":13,"id":"3a7e1126_7f6b65b7","line":444,"range":{"start_line":444,"start_character":22,"end_line":444,"end_character":28},"updated":"2015-12-22 09:49:42.000000000","message":"this is not \u0027allow_async\u0027 because it is not really used with \u0027use_slave\u0027 in service object function (moreover \u0027get_by_id\u0027 method doesn\u0027t have \u0027use_slave\u0027 arg)","commit_id":"e8132fdd782907c8f7bfa058387a44007dfbdf10"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"30ed0cad13617fd2862756abc0b52c8d48eefb81","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                soft_delete(synchronize_session\u003dFalse)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"@main_context_manager.reader"},{"line_number":445,"context_line":"def service_get(context, service_id):"},{"line_number":446,"context_line":"    query \u003d model_query(context, models.Service).filter_by(id\u003dservice_id)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"ba63e191_5c99721e","line":444,"updated":"2016-01-19 20:44:57.000000000","message":"Why not allow_async here?","commit_id":"49c1f363eb23c24c00fe6dd550ba9e097772b091"},{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"3d69d974d1fa0ae52b7f068466e78ceee1d7c35d","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                soft_delete(synchronize_session\u003dFalse)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"@main_context_manager.reader"},{"line_number":445,"context_line":"def service_get(context, service_id):"},{"line_number":446,"context_line":"    query \u003d model_query(context, models.Service).filter_by(id\u003dservice_id)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a68dd71_c2e4da0e","line":444,"in_reply_to":"9a68dd71_e1cfaab1","updated":"2016-01-20 16:44:14.000000000","message":"Okay, makes sense.","commit_id":"49c1f363eb23c24c00fe6dd550ba9e097772b091"},{"author":{"_account_id":10618,"name":"Pavel Kholkin","email":"p.v.holkin@mail.ru","username":"pkholkin"},"change_message_id":"f45ff16df4683ab321d625bc09a266b9028eb37e","unresolved":false,"context_lines":[{"line_number":441,"context_line":"                soft_delete(synchronize_session\u003dFalse)"},{"line_number":442,"context_line":""},{"line_number":443,"context_line":""},{"line_number":444,"context_line":"@main_context_manager.reader"},{"line_number":445,"context_line":"def service_get(context, service_id):"},{"line_number":446,"context_line":"    query \u003d model_query(context, models.Service).filter_by(id\u003dservice_id)"},{"line_number":447,"context_line":""}],"source_content_type":"text/x-python","patch_set":15,"id":"9a68dd71_e1cfaab1","line":444,"in_reply_to":"ba63e191_5c99721e","updated":"2016-01-20 13:42:10.000000000","message":"Andrew, we found only one usage of \u0027db.service_get()\u0027 here https://github.com/openstack/nova/blob/master/nova/objects/service.py#L205-L208.\n\nLooking on this method we saw that \u0027use_slave\u0027 wasn\u0027t really used anywhere in this method, so we decided to leave it as @reader.","commit_id":"49c1f363eb23c24c00fe6dd550ba9e097772b091"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"7e8aef3122a49a12be338452cb993eea54a35d1b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    return result"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":""},{"line_number":458,"context_line":"def service_get(context, service_id, use_slave\u003dFalse):"},{"line_number":459,"context_line":"    return _service_get(context, service_id,"},{"line_number":460,"context_line":"                        use_slave\u003duse_slave)"},{"line_number":461,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"7a5de9d1_af53356a","side":"PARENT","line":458,"updated":"2016-01-30 08:58:17.000000000","message":"ah, so we drop use_slave as its not used now, OK.","commit_id":"1ab0ee1258aab3fc963704c2970d0b5bc293cc86"}],"nova/objects/service.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e6f0b6a29628208b5f183715ef3821ec3bc12ca9","unresolved":false,"context_lines":[{"line_number":217,"context_line":"        return cls._from_db_object(context, cls(), db_service)"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"    @base.remotable_classmethod"},{"line_number":220,"context_line":"    def get_by_compute_host(cls, context, host):"},{"line_number":221,"context_line":"        db_service \u003d db.service_get_by_compute_host(context, host)"},{"line_number":222,"context_line":"        return cls._from_db_object(context, cls(), db_service)"},{"line_number":223,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_a47b18bd","line":220,"updated":"2015-11-12 12:40:26.000000000","message":"I don\u0027t think we are allowed to do this, it breaks upgrade and requires a major version bump. Not sure why the tests don\u0027t catch that :(\n\nI think we could just ignore the argument.","commit_id":"8d7fb143a0b41f1a3ccf9c3dcc711a47852db0cb"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"e6f0b6a29628208b5f183715ef3821ec3bc12ca9","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    # Version 1.16: Service version 1.18"},{"line_number":317,"context_line":"    # Version 1.17: Service version 1.19"},{"line_number":318,"context_line":"    # Version 1.18: Service version 1.20"},{"line_number":319,"context_line":"    VERSION \u003d \u00271.18\u0027"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":"    fields \u003d {"},{"line_number":322,"context_line":"        \u0027objects\u0027: fields.ListOfObjectsField(\u0027Service\u0027),"}],"source_content_type":"text/x-python","patch_set":8,"id":"da85f559_0443046d","line":319,"updated":"2015-11-12 12:40:26.000000000","message":"Do we need to do that still? maybe I guess.","commit_id":"8d7fb143a0b41f1a3ccf9c3dcc711a47852db0cb"}]}