)]}'
{"nova/api/openstack/common.py":[{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"ce2a5056b802010c32b089a9f869624d4762a053","unresolved":false,"context_lines":[{"line_number":244,"context_line":"    :kwarg max_limit: The maximum number of items to return from \u0027items\u0027"},{"line_number":245,"context_line":"    \"\"\""},{"line_number":246,"context_line":"    if max_limit is None:"},{"line_number":247,"context_line":"        max_limit \u003d CONF.osapi_max_limit"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    offset \u003d request.GET.get(\"offset\", 0)"},{"line_number":250,"context_line":"    limit \u003d request.GET.get(\u0027limit\u0027, max_limit)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_ecd0eecb","line":247,"updated":"2015-11-03 21:37:23.000000000","message":"nit:\nmax_limit \u003d max_limit or CONF.osapi_max_limit","commit_id":"2fcf4fd79f9faf3d930d49d829b1138aa05a12f8"},{"author":{"_account_id":2750,"name":"Sean Dague","email":"sean@dague.net","username":"sdague"},"change_message_id":"d410bf38e0c1971f2d3a40e04686da781c6f63ea","unresolved":false,"context_lines":[{"line_number":260,"context_line":"    return items[offset:range_end]"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":""},{"line_number":263,"context_line":"def get_limit_and_marker(request, max_limit\u003dNone):"},{"line_number":264,"context_line":"    \"\"\"get limited parameter from request.\"\"\""},{"line_number":265,"context_line":"    if max_limit is None:"},{"line_number":266,"context_line":"        max_limit \u003d CONF.osapi_max_limit"}],"source_content_type":"text/x-python","patch_set":1,"id":"ba8a016a_2b86f265","line":263,"updated":"2015-11-20 13:59:34.000000000","message":"I actually find no uses in the code where max_limit is set (except tests), so we should just remove the parameter from these functions and use the CONF directly in the body.","commit_id":"2fcf4fd79f9faf3d930d49d829b1138aa05a12f8"},{"author":{"_account_id":16929,"name":"Giridhar Jayavelu","email":"gjayavelu@vmware.com","username":"gjayavelu"},"change_message_id":"ce2a5056b802010c32b089a9f869624d4762a053","unresolved":false,"context_lines":[{"line_number":263,"context_line":"def get_limit_and_marker(request, max_limit\u003dNone):"},{"line_number":264,"context_line":"    \"\"\"get limited parameter from request.\"\"\""},{"line_number":265,"context_line":"    if max_limit is None:"},{"line_number":266,"context_line":"        max_limit \u003d CONF.osapi_max_limit"},{"line_number":267,"context_line":""},{"line_number":268,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":269,"context_line":"    limit \u003d params.get(\u0027limit\u0027, max_limit)"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_0cd692c5","line":266,"updated":"2015-11-03 21:37:23.000000000","message":"same as above","commit_id":"2fcf4fd79f9faf3d930d49d829b1138aa05a12f8"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"f00ac959fbb8497b74fb07283d3bd8db50fc298a","unresolved":false,"context_lines":[{"line_number":256,"context_line":"    \"\"\"Get limited parameter from request.\"\"\""},{"line_number":257,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":258,"context_line":"    limit \u003d min(CONF.osapi_max_limit,"},{"line_number":259,"context_line":"                params.get(\u0027limit\u0027) or CONF.osapi_max_limit)"},{"line_number":260,"context_line":"    marker \u003d params.get(\u0027marker\u0027, None)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    return limit, marker"}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_8723fca6","line":259,"updated":"2015-11-23 16:42:44.000000000","message":"nit: max_limit was a nice local (though not a good arg)","commit_id":"5ac3159dd95d5e3dad6486a1ae453460662c84d1"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"f00ac959fbb8497b74fb07283d3bd8db50fc298a","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":258,"context_line":"    limit \u003d min(CONF.osapi_max_limit,"},{"line_number":259,"context_line":"                params.get(\u0027limit\u0027) or CONF.osapi_max_limit)"},{"line_number":260,"context_line":"    marker \u003d params.get(\u0027marker\u0027, None)"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"    return limit, marker"},{"line_number":263,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"ba8a016a_e71d2867","line":260,"updated":"2015-11-23 16:42:44.000000000","message":"nit: don\u0027t need \", None\"","commit_id":"5ac3159dd95d5e3dad6486a1ae453460662c84d1"},{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"f212b9dded52c4064ca0dc49aad3e7c08bba330c","unresolved":false,"context_lines":[{"line_number":255,"context_line":"def get_limit_and_marker(request):"},{"line_number":256,"context_line":"    \"\"\"Get limited parameter from request.\"\"\""},{"line_number":257,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":258,"context_line":"    limit \u003d min(CONF.osapi_max_limit, params.get(\u0027limit\u0027, max_limit))"},{"line_number":259,"context_line":"    marker \u003d params.get(\u0027marker\u0027, None)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    return limit, marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_ffa0a0a7","line":258,"updated":"2015-12-03 18:20:15.000000000","message":"Where is \u0027max_limit\u0027 defined?","commit_id":"d7b5730f7cea275601a1893d4554dd32fb3053d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2527a07d756ac1207482890f0d3cc249ee0b96e2","unresolved":false,"context_lines":[{"line_number":255,"context_line":"def get_limit_and_marker(request):"},{"line_number":256,"context_line":"    \"\"\"Get limited parameter from request.\"\"\""},{"line_number":257,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":258,"context_line":"    limit \u003d min(CONF.osapi_max_limit, params.get(\u0027limit\u0027, max_limit))"},{"line_number":259,"context_line":"    marker \u003d params.get(\u0027marker\u0027, None)"},{"line_number":260,"context_line":""},{"line_number":261,"context_line":"    return limit, marker"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_05d676c5","line":258,"in_reply_to":"7a740942_ffa0a0a7","updated":"2015-12-03 20:15:06.000000000","message":"Typo. Don\u0027t ask how I managed this, heh","commit_id":"d7b5730f7cea275601a1893d4554dd32fb3053d4"},{"author":{"_account_id":8688,"name":"Alexis Lee","email":"openstack@lxsli.co.uk","username":"lxsli"},"change_message_id":"19a00962efcd90c58cb5fbe89d834a3e3eeb0c9c","unresolved":false,"context_lines":[{"line_number":247,"context_line":"    params \u003d get_pagination_params(request)"},{"line_number":248,"context_line":"    offset \u003d params.get(\u0027offset\u0027, 0)"},{"line_number":249,"context_line":"    limit \u003d min(CONF.osapi_max_limit,"},{"line_number":250,"context_line":"                params.get(\u0027limit\u0027) or CONF.osapi_max_limit)"},{"line_number":251,"context_line":""},{"line_number":252,"context_line":"    return items[offset:(offset + limit)]"},{"line_number":253,"context_line":""}],"source_content_type":"text/x-python","patch_set":7,"id":"7a740942_fe8831c7","line":250,"updated":"2015-12-07 12:05:22.000000000","message":"nit: this (and below) would be very slightly nicer as:\n\n  limit \u003d CONF.osapi_max_limit\n  limit \u003d min(limit, params.get(\u0027limit\u0027) or limit)","commit_id":"4e8759f444afa8b837145f82cfb5f6f6481378c4"}],"nova/tests/unit/api/openstack/test_common.py":[{"author":{"_account_id":1063,"name":"Ed Leafe","email":"ed@leafe.com","username":"ed-leafe"},"change_message_id":"f212b9dded52c4064ca0dc49aad3e7c08bba330c","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class PaginationParamsTest(test.NoDBTestCase):"},{"line_number":235,"context_line":"    \"\"\"Unit tests for the `nova.api.openstack.common.get_pagination_params`."},{"line_number":236,"context_line":"    \"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_no_params(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_bfdc5847","line":235,"updated":"2015-12-03 18:20:15.000000000","message":"Not sure why this needed to be changed like this. At the very least, you should add back the word \u0027method\u0027 at the end of the sentence.","commit_id":"d7b5730f7cea275601a1893d4554dd32fb3053d4"},{"author":{"_account_id":15334,"name":"Stephen Finucane","display_name":"stephenfin","email":"stephenfin@redhat.com","username":"sfinucan"},"change_message_id":"2527a07d756ac1207482890f0d3cc249ee0b96e2","unresolved":false,"context_lines":[{"line_number":232,"context_line":""},{"line_number":233,"context_line":""},{"line_number":234,"context_line":"class PaginationParamsTest(test.NoDBTestCase):"},{"line_number":235,"context_line":"    \"\"\"Unit tests for the `nova.api.openstack.common.get_pagination_params`."},{"line_number":236,"context_line":"    \"\"\""},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"    def test_no_params(self):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7a740942_451d5e72","line":235,"in_reply_to":"7a740942_bfdc5847","updated":"2015-12-03 20:15:06.000000000","message":"Yup - another thing that shouldn\u0027t have been included.","commit_id":"d7b5730f7cea275601a1893d4554dd32fb3053d4"}]}