)]}'
{"bin/nova-manage":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":1025,"context_line":"                           help\u003d\u0027destanation node\u0027)"},{"line_number":1026,"context_line":"    @args(\u0027--disk_over_commit\u0027, dest\u003d\u0027disk_over_commit\u0027,"},{"line_number":1027,"context_line":"                           metavar\u003d\u0027\u003covercommit flag\u003e\u0027,"},{"line_number":1028,"context_line":"                           help\u003d\u0027Not overcommit by default flag Flase\u0027)"},{"line_number":1029,"context_line":"    def block_migration(self, ec2_id, dest, disk_over_commit\u003dFalse):"},{"line_number":1030,"context_line":"        \"\"\"Migrates a running instance to a new machine with storage data.\"\"\""},{"line_number":1031,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"AAAAD3%2F%2F%2FAY%3D","line":1028,"updated":"2012-01-11 16:42:54.000000000","message":"How about:\n\n    help\u003d\u0027Allow overcommit (default False)\u0027","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"}],"nova/compute/manager.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":1670,"context_line":"           Implementation nova/virt/libvirt/connection."},{"line_number":1671,"context_line":""},{"line_number":1672,"context_line":"        :param context: security context"},{"line_number":1673,"context_line":"        :param : instance_name"},{"line_number":1674,"context_line":"        \"\"\""},{"line_number":1675,"context_line":"        return self.driver.get_instance_disk_info(instance_name)"},{"line_number":1676,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2FAU%3D","line":1673,"updated":"2012-01-11 16:42:54.000000000","message":"Try something like this:\n\n    \"\"\"Gets information about an instance\u0027s current disk.\n\n    Implemented by nova.virt.libvirt.connection\n\n    :param context: security context\n    :param instance_name: instance name\n    \"\"\"","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":1680,"context_line":""},{"line_number":1681,"context_line":"        :param context: security context"},{"line_number":1682,"context_line":"        :param instance_id: nova.db.sqlalchemy.models.Instance.Id"},{"line_number":1683,"context_line":"        :param block_migration: True in case of block_migration"},{"line_number":1684,"context_line":""},{"line_number":1685,"context_line":"        \"\"\""},{"line_number":1686,"context_line":"        if not time:"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2FAI%3D","line":1683,"updated":"2012-01-11 16:42:54.000000000","message":"I\u0027m not sure why you changed this; the original doc seems clear enough.  If anything, I\u0027d rather see the original doc (\"if true, prepare for block migration\") copied into all the other function docstrings that reference the block_migration parameter.","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"}],"nova/db/sqlalchemy/migrate_repo/versions/068_block_migration.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":24,"context_line":""},{"line_number":25,"context_line":"# Add disk_available_least column to compute_nodes table"},{"line_number":26,"context_line":"# The size that deducted real nstance disk size from"},{"line_number":27,"context_line":"# the total size of the virtual disk of all instances."},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"compute_nodes \u003d Table(\u0027compute_nodes\u0027, meta,"},{"line_number":30,"context_line":"        Column(\u0027id\u0027, Integer(), primary_key\u003dTrue, nullable\u003dFalse))"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2Fs%3D","line":27,"updated":"2012-01-11 16:42:54.000000000","message":"I\u0027m afraid I can\u0027t understand this last sentence well enough to suggest an improved wording...","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"}],"nova/scheduler/driver.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"39742bd12569497617d537896cc5ff220f5c4803","unresolved":false,"context_lines":[{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":""},{"line_number":24,"context_line":"import datetime"},{"line_number":25,"context_line":"import inspect"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"from nova import db"},{"line_number":28,"context_line":"from nova import exception"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7t8%3D","line":25,"updated":"2011-12-20 17:34:08.000000000","message":"Where are these imports used?","commit_id":"d20128f7a7cdc1a3115f7031cdf665ae560167cb"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":175,"context_line":"        :param context:"},{"line_number":176,"context_line":"        :param instance_id:"},{"line_number":177,"context_line":"        :param dest: destination host"},{"line_number":178,"context_line":"        :param block_migration: True in case of block_migration."},{"line_number":179,"context_line":"        :param disk_over_commit: True in case of real(not virtual) disk size"},{"line_number":180,"context_line":"                                  must be considered."},{"line_number":181,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2Fg%3D","line":178,"updated":"2012-01-11 16:42:54.000000000","message":"See my prior comments regarding block_migration documentation.","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":177,"context_line":"        :param dest: destination host"},{"line_number":178,"context_line":"        :param block_migration: True in case of block_migration."},{"line_number":179,"context_line":"        :param disk_over_commit: True in case of real(not virtual) disk size"},{"line_number":180,"context_line":"                                  must be considered."},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"        :return:"},{"line_number":183,"context_line":"            The host where instance is running currently."}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2FY%3D","line":180,"updated":"2012-01-11 16:42:54.000000000","message":"How about something like:\n\n    :param disk_over_commit: if True, consider real (not virtual) disk size.","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":421,"context_line":"        # but it is bigger up to 100G. Therefore, an admin sometimes"},{"line_number":422,"context_line":"        # has to consider an instance is bigger up to 100G."},{"line_number":423,"context_line":"        # if overcommit is True, scheduler consider using 100G,"},{"line_number":424,"context_line":"        # otherwise, use 10M."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        # Reflesh compute_nodes table"},{"line_number":427,"context_line":"        topic \u003d db.queue_get_for(context, FLAGS.compute_topic, dest)"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2B4%3D","line":424,"updated":"2012-01-11 16:42:54.000000000","message":"I\u0027m having trouble understanding this paragraph well enough to suggest an appropriate replacement...","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":423,"context_line":"        # if overcommit is True, scheduler consider using 100G,"},{"line_number":424,"context_line":"        # otherwise, use 10M."},{"line_number":425,"context_line":""},{"line_number":426,"context_line":"        # Reflesh compute_nodes table"},{"line_number":427,"context_line":"        topic \u003d db.queue_get_for(context, FLAGS.compute_topic, dest)"},{"line_number":428,"context_line":"        rpc.call(context, topic,"},{"line_number":429,"context_line":"                 {\"method\": \"update_available_resource\"})"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2B0%3D","line":426,"updated":"2012-01-11 16:42:54.000000000","message":"Do you mean \"Refresh compute_nodes table\"?","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":454,"context_line":"            for info in disk_infos:"},{"line_number":455,"context_line":"                necessary +\u003d int(info[\u0027virt_disk_size\u0027])"},{"line_number":456,"context_line":""},{"line_number":457,"context_line":"        # examination available disk size \u003e necessary disk size."},{"line_number":458,"context_line":"        if (available - necessary) \u003c 0:"},{"line_number":459,"context_line":"            instance_id \u003d ec2utils.id_to_ec2_id(instance_ref[\u0027id\u0027])"},{"line_number":460,"context_line":"            reason \u003d _(\"Unable to migrate %(instance_id)s to %(dest)s: \""}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2Bw%3D","line":457,"updated":"2012-01-11 16:42:54.000000000","message":"\"Check that available disk \u003e necessary disk\"","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"}],"nova/scheduler/multi.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"39742bd12569497617d537896cc5ff220f5c4803","unresolved":false,"context_lines":[{"line_number":20,"context_line":"\"\"\""},{"line_number":21,"context_line":"Scheduler that allows routing some calls to one driver and others to another."},{"line_number":22,"context_line":"\"\"\""},{"line_number":23,"context_line":"import inspect"},{"line_number":24,"context_line":"from nova import flags"},{"line_number":25,"context_line":"from nova import utils"},{"line_number":26,"context_line":"from nova.scheduler import driver"}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7t4%3D","line":23,"updated":"2011-12-20 17:34:08.000000000","message":"1) I don\u0027t see inspect used anywhere.\n\n2) This import is not separated from the others.","commit_id":"d20128f7a7cdc1a3115f7031cdf665ae560167cb"}],"nova/virt/libvirt/connection.py":[{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"39742bd12569497617d537896cc5ff220f5c4803","unresolved":false,"context_lines":[{"line_number":51,"context_line":"import tempfile"},{"line_number":52,"context_line":"import time"},{"line_number":53,"context_line":"import uuid"},{"line_number":54,"context_line":"import socket"},{"line_number":55,"context_line":"from xml.dom import minidom"},{"line_number":56,"context_line":"from xml.etree import ElementTree"},{"line_number":57,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"AAAAC3%2F%2F7to%3D","line":54,"updated":"2011-12-20 17:34:08.000000000","message":"1) Where is this import used?\n\n2) It is not placed in the correct order.","commit_id":"d20128f7a7cdc1a3115f7031cdf665ae560167cb"},{"author":{"_account_id":679,"name":"Kevin L. Mitchell","email":"klmitch@mit.edu","username":"klmitch"},"change_message_id":"3317e3e166efe6a5c8c9059df5131be3c8b0eed5","unresolved":false,"context_lines":[{"line_number":1910,"context_line":"             when block_migration command given disk_over_commit param"},{"line_number":1911,"context_line":"             is FALSE."},{"line_number":1912,"context_line":"            The size that deducted real nstance disk size from the total"},{"line_number":1913,"context_line":"             size of the virtual disk of all instances."},{"line_number":1914,"context_line":""},{"line_number":1915,"context_line":"        \"\"\""},{"line_number":1916,"context_line":"        # available size of the disk"}],"source_content_type":"text/x-python","patch_set":5,"id":"AAAAD3%2F%2F%2B%2Bo%3D","line":1913,"updated":"2012-01-11 16:42:54.000000000","message":"I\u0027m afraid I don\u0027t understand this docstring well enough to suggest an alternative phrasing.  I will point out that the formatting is kind of messed up: there should be no space between the opening triple-quote (\u0027\"\"\"\u0027) and the summary, and in general we format the remaining lines to line up with the left edge of the triple-quote, not the right edge.  Finally, paragraphs are separated from one another with blank lines, not with hanging indents.","commit_id":"96cd2bd33524f2e65553567645c649b802ea3944"}]}