)]}'
{"nova/objects/block_device.py":[{"author":{"_account_id":5441,"name":"Andrew Laski","email":"andrew@lascii.com","username":"alaski"},"change_message_id":"7fe7ca8590d786e3aee355a82ba26d9ee83b7ee7","unresolved":false,"context_lines":[{"line_number":206,"context_line":"            # NOTE(alaski): If the device name has just been set this bdm"},{"line_number":207,"context_line":"            # likely does not exist in the parent cell and we should create it."},{"line_number":208,"context_line":"            # If this is a modification of the device name we should update"},{"line_number":209,"context_line":"            # rather than create which is why None is used here instead of True"},{"line_number":210,"context_line":"            if (\u0027device_name\u0027 in updates and"},{"line_number":211,"context_line":"                    self.bdm_field_is_new(\u0027device_name\u0027)):"},{"line_number":212,"context_line":"                create \u003d True"}],"source_content_type":"text/x-python","patch_set":1,"id":"fa80f949_21d31106","line":209,"updated":"2015-11-05 14:42:48.000000000","message":"The second half of this comment should be updated.","commit_id":"88141c7e943b6c7bc0020c197bc41f4b5996d462"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1cc10917bfc6155cecd082cb14d56f5226bf3e3","unresolved":false,"context_lines":[{"line_number":115,"context_line":"            block_device_obj.instance \u003d my_inst"},{"line_number":116,"context_line":""},{"line_number":117,"context_line":"        block_device_obj._context \u003d context"},{"line_number":118,"context_line":"        block_device_obj.obj_reset_changes()"},{"line_number":119,"context_line":"        return block_device_obj"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    def _create(self, context, update_or_create\u003dFalse):"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_778a221d","line":118,"updated":"2015-11-06 03:31:11.000000000","message":"Here","commit_id":"9540c813d3d38e9ea5dba5369fc8f3165834a76a"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1cc10917bfc6155cecd082cb14d56f5226bf3e3","unresolved":false,"context_lines":[{"line_number":199,"context_line":"                                                 updates, legacy\u003dFalse)"},{"line_number":200,"context_line":"        if not updated:"},{"line_number":201,"context_line":"            raise exception.BDMNotFound(id\u003dself.id)"},{"line_number":202,"context_line":"        self._from_db_object(self._context, self, updated)"},{"line_number":203,"context_line":"        cell_type \u003d cells_opts.get_cell_type()"},{"line_number":204,"context_line":"        if cell_type \u003d\u003d \u0027compute\u0027:"},{"line_number":205,"context_line":"            create \u003d False"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_f797f245","line":202,"updated":"2015-11-06 03:31:11.000000000","message":"Here","commit_id":"9540c813d3d38e9ea5dba5369fc8f3165834a76a"},{"author":{"_account_id":12898,"name":"Tony Breeds","email":"tony@bakeyournoodle.com","username":"tonyb"},"change_message_id":"a1cc10917bfc6155cecd082cb14d56f5226bf3e3","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            # rather than create."},{"line_number":210,"context_line":"            if (\u0027device_name\u0027 in updates and"},{"line_number":211,"context_line":"                    self.bdm_field_is_new(\u0027device_name\u0027)):"},{"line_number":212,"context_line":"                create \u003d True"},{"line_number":213,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":214,"context_line":"            cells_api.bdm_update_or_create_at_top(self._context, self,"},{"line_number":215,"context_line":"                    create\u003dcreate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_177cf61d","line":212,"updated":"2015-11-06 03:31:11.000000000","message":"We don\u0027t get here in the unit tests because _from_db_object() calls obj_reset_changes() which calls _reset_tracking() so the device_name is already in _orig_fields","commit_id":"9540c813d3d38e9ea5dba5369fc8f3165834a76a"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"4fad006b0810370e44e0613370c04541ced6a8e5","unresolved":false,"context_lines":[{"line_number":209,"context_line":"            # rather than create."},{"line_number":210,"context_line":"            if (\u0027device_name\u0027 in updates and"},{"line_number":211,"context_line":"                    self.bdm_field_is_new(\u0027device_name\u0027)):"},{"line_number":212,"context_line":"                create \u003d True"},{"line_number":213,"context_line":"            cells_api \u003d cells_rpcapi.CellsAPI()"},{"line_number":214,"context_line":"            cells_api.bdm_update_or_create_at_top(self._context, self,"},{"line_number":215,"context_line":"                    create\u003dcreate)"}],"source_content_type":"text/x-python","patch_set":2,"id":"fa80f949_330fc438","line":212,"in_reply_to":"fa80f949_177cf61d","updated":"2015-11-06 09:50:59.000000000","message":"Fair point. I feel we should think about another way to call the update rather than looking if the field is new.","commit_id":"9540c813d3d38e9ea5dba5369fc8f3165834a76a"}]}