)]}'
{"nova/network/neutronv2/api.py":[{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"e958a648bf538a1b80d7da0e6726f67112582a34","unresolved":false,"context_lines":[{"line_number":1467,"context_line":"        # If a neutron plugin does not implement the L3 API a 404 from"},{"line_number":1468,"context_line":"        # list_floatingips will be raised."},{"line_number":1469,"context_line":"        except neutron_client_exc.NeutronClientException as e:"},{"line_number":1470,"context_line":"            if e.status_code \u003d\u003d 404:"},{"line_number":1471,"context_line":"                return []"},{"line_number":1472,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":1473,"context_line":"                LOG.exception(_LE(\u0027Unable to access floating IP for %s\u0027),"}],"source_content_type":"text/x-python","patch_set":3,"id":"da85f559_d6b0118e","line":1470,"updated":"2015-11-09 10:05:44.000000000","message":"In the latest Neutron client this exists - https://github.com/openstack/python-neutronclient/blob/master/neutronclient/common/exceptions.py#L87\n\nhttps://github.com/openstack/python-neutronclient/blob/2.6.0/neutronclient/common/exceptions.py\n\nI think at the end of the day the underlying plugin is what is broken. But the change is valid in my opinion","commit_id":"e548ba2d73e5314b647d9524872fad4dd7a0ffd2"},{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84e34773cbd0bdc21564e6a6997de4285afcc0d6","unresolved":false,"context_lines":[{"line_number":1468,"context_line":"        # list_floatingips will be raised."},{"line_number":1469,"context_line":"        except neutron_client_exc.NotFound:"},{"line_number":1470,"context_line":"            return []"},{"line_number":1471,"context_line":"        except neutron_client_exc.NeutronClientException as e:"},{"line_number":1472,"context_line":"            # bug/1513879 neutron client is currently using"},{"line_number":1473,"context_line":"            # NeutronClientException when there is no L3 API"},{"line_number":1474,"context_line":"            if e.status_code \u003d\u003d 404:"}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_1fcdc1b6","line":1471,"updated":"2015-11-11 16:57:05.000000000","message":"love this bit","commit_id":"cbbbaa93aeeb7c7902867842ac8890928894cf96"}],"nova/tests/unit/network/test_neutronv2.py":[{"author":{"_account_id":782,"name":"John Garbutt","email":"john@johngarbutt.com","username":"johngarbutt"},"change_message_id":"84e34773cbd0bdc21564e6a6997de4285afcc0d6","unresolved":false,"context_lines":[{"line_number":3588,"context_line":"        # neutronclient doesn\u0027t raise NotFound in this scenario, it raises a"},{"line_number":3589,"context_line":"        # NeutronClientException with status_code\u003d404"},{"line_number":3590,"context_line":"        notfound \u003d exceptions.NeutronClientException(status_code\u003d404)"},{"line_number":3591,"context_line":"        mock_nc.list_floatingips.side_effect \u003d notfound"},{"line_number":3592,"context_line":"        fips \u003d self.api.get_floating_ips_by_project(self.context)"},{"line_number":3593,"context_line":"        self.assertEqual([], fips)"},{"line_number":3594,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"da85f559_3fd2055d","line":3591,"updated":"2015-11-11 16:57:05.000000000","message":"shouldn\u0027t this be additional unit test, so we test both the old and new code paths?","commit_id":"cbbbaa93aeeb7c7902867842ac8890928894cf96"}]}